All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: kerneldoc warnings squelched
Date: Wed, 12 Jun 2019 18:25:31 +0300	[thread overview]
Message-ID: <20190612152531.GP5942@intel.com> (raw)
In-Reply-To: <20190612151311.30295-1-chris@chris-wilson.co.uk>

On Wed, Jun 12, 2019 at 04:13:11PM +0100, Chris Wilson wrote:
> drivers/gpu/drm/i915//gem/i915_gem_shrinker.c:142: warning: Function parameter or member 'shrink' not described in 'i915_gem_shrink'
> drivers/gpu/drm/i915//gem/i915_gem_shrinker.c:142: warning: Excess function parameter 'flags' description in 'i915_gem_shrink'
> 
> drivers/gpu/drm/i915//intel_display.c:13443: warning: Function parameter or member '_state' not described in 'intel_atomic_check'
> drivers/gpu/drm/i915//intel_display.c:13443: warning: Excess function parameter 'state' description in 'intel_atomic_check'
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 2 +-
>  drivers/gpu/drm/i915/intel_display.c         | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c b/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c
> index 1b93bc334630..e15f37bef36a 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c
> @@ -114,7 +114,7 @@ static void try_to_writeback(struct drm_i915_gem_object *obj,
>   * @i915: i915 device
>   * @target: amount of memory to make available, in pages
>   * @nr_scanned: optional output for number of pages scanned (incremental)
> - * @flags: control flags for selecting cache types
> + * @shrink: control flags for selecting cache types
>   *
>   * This function is the main interface to the shrinker. It will try to release
>   * up to @target pages of main memory backing storage from buffer objects.
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 1b1ddb48ca7a..e681ed99cdf2 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13436,7 +13436,7 @@ static int calc_watermark_data(struct intel_atomic_state *state)
>  /**
>   * intel_atomic_check - validate state object
>   * @dev: drm device
> - * @state: state to validate
> + * @_state: state to validate
>   */

Not sure most of these docs are actually useful. But too lazy to
look through all of them to check.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>  static int intel_atomic_check(struct drm_device *dev,
>  			      struct drm_atomic_state *_state)
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-06-12 15:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 15:13 [PATCH] drm/i915: kerneldoc warnings squelched Chris Wilson
2019-06-12 15:25 ` Ville Syrjälä [this message]
2019-06-12 16:44 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-06-12 17:08 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-14 11:51 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190612152531.GP5942@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.