From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D8EBC31E45 for ; Thu, 13 Jun 2019 05:47:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C70E2133D for ; Thu, 13 Jun 2019 05:47:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PVYemzAa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="woqgM20A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C70E2133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DNRdcnIvhwOCxE40/sm6Csxmq+pBgAgOXooRBq9dHD8=; b=PVYemzAae8zxlo nJbJYpKTSu+aJK0AiqrFx6S2thtm6dJA4k0KnycmD43c+gonyvmg/YHKEqZ9UoOkXmpqov3IplmEr /FhNDyeBDDfeDzfZ30wSkxQNr1p3hHRySJFMyLScFtcEX2ynMVp+yPwgsPMrAPfJHvylI+ZgTMKCE PdD5OcGwSKEwHcSJKpSABS60w2ZuIpeQFvkcWuL4GoOV6aCJl9wjkkAlXV0wzY1Go6WnVnK+LlC/X jR/C8/jQBbguVZ6Ex1E6/coNP21dYBinHleXOVq19rhqFXbIxe25tRIfSJCVghKDSTkU6Z42AUjJF M72A+1MVHkIyqwRcc/vw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbIaB-0004DW-Qq; Thu, 13 Jun 2019 05:47:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbIa7-0004D3-M3 for linux-mtd@lists.infradead.org; Thu, 13 Jun 2019 05:47:29 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7816B2084D; Thu, 13 Jun 2019 05:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560404846; bh=p2txWP7VMrpJAMTDy1gy0dhEGma8/h5lA/7cI8LgzKc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=woqgM20AXAtrj2GHHrBcVxZPIn7Ybqal3ITnAUkvcIQ53ryn/bDLDAB324sGyUemS jOji6NkhjBZhHGkZcYMK8k7RobSrpTQ+TkJ14o1h7ASnea9D5Y4qk09oE4aBiIaC5M iy+YRulcJQqTArM4ZMGis8ShiXqcekZPg/AhguG0= Date: Thu, 13 Jun 2019 07:47:23 +0200 From: Greg Kroah-Hartman To: Richard Weinberger Subject: Re: [PATCH] ubifs: no need to check return value of debugfs_create functions Message-ID: <20190613054723.GC19717@kroah.com> References: <20190612152120.GA17450@kroah.com> <1642440141.89874.1560365637583.JavaMail.zimbra@nod.at> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1642440141.89874.1560365637583.JavaMail.zimbra@nod.at> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_224727_745423_A800762D X-CRM114-Status: GOOD ( 12.86 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd , Adrian Hunter , Artem Bityutskiy Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Jun 12, 2019 at 08:53:57PM +0200, Richard Weinberger wrote: > Greg, > = > ----- Urspr=FCngliche Mail ----- > > Von: "Greg Kroah-Hartman" > > An: "richard" , "Artem Bityutskiy" , "Adrian Hunter" > > CC: "linux-mtd" > > Gesendet: Mittwoch, 12. Juni 2019 17:21:20 > > Betreff: [PATCH] ubifs: no need to check return value of debugfs_create= functions > = > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > = > why is it bad if we handle errors from debugfs? Because there is no need to? If debugfs fails, there is nothing that a user can do about it :) > At least a nice log message a la "sorry, no ubifs debuging for you" > would be nice to have. I think the lack of a debugfs file is kind of obvious :) Anyway, the point is that there is no need to check for return values from debugfs, and the logic of the non-debugfs code should not do anything different if debugfs is acting up or not. thanks, greg k-h ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/