From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v5] drm/vc4: fix fb references in async update Date: Thu, 13 Jun 2019 09:51:12 +0200 Message-ID: <20190613075112.GE19685@kroah.com> References: <156007492924468@kroah.com> <20190610131859.7616-1-helen.koike@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 54F9889760 for ; Thu, 13 Jun 2019 07:51:15 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190610131859.7616-1-helen.koike@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Helen Koike Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKdW4gMTAsIDIwMTkgYXQgMTA6MTg6NTlBTSAtMDMwMCwgSGVsZW4gS29pa2Ugd3Jv dGU6Cj4gY29tbWl0IGMxNmI4NTU1OWRjZmI1YTM0OGNjMDg1YTdiNGM3NWVkNDliMDVlMmMgdXBz dHJlYW0uCj4gCj4gQXN5bmMgdXBkYXRlIGNhbGxiYWNrcyBhcmUgZXhwZWN0ZWQgdG8gc2V0IHRo ZSBvbGRfZmIgaW4gdGhlIG5ld19zdGF0ZQo+IHNvIHByZXBhcmUvY2xlYW51cCBmcmFtZWJ1ZmZl cnMgYXJlIGJhbGFuY2VkLgo+IAo+IENhbGxpbmcgZHJtX2F0b21pY19zZXRfZmJfZm9yX3BsYW5l KCkgKHdoaWNoIGdldHMgYSByZWZlcmVuY2Ugb2YgdGhlIG5ldwo+IGZiIGFuZCBwdXQgdGhlIG9s ZCBmYikgaXMgbm90IHJlcXVpcmVkLCBhcyBpdCdzIHRha2VuIGNhcmUgYnkKPiBkcm1fbW9kZV9j dXJzb3JfdW5pdmVyc2FsKCkgd2hlbiBjYWxsaW5nIGRybV9hdG9taWNfaGVscGVyX3VwZGF0ZV9w bGFuZSgpLgo+IAo+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NC4xOSsKPiBGaXhl czogNTM5YzMyMGJmYTk3ICgiZHJtL3ZjNDogdXBkYXRlIGN1cnNvcnMgYXN5bmNocm9ub3VzbHkg dGhyb3VnaCBhdG9taWMiKQo+IFN1Z2dlc3RlZC1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5i cmV6aWxsb25AY29sbGFib3JhLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBIZWxlbiBLb2lrZSA8aGVs ZW4ua29pa2VAY29sbGFib3JhLmNvbT4KPiBSZXZpZXdlZC1ieTogQm9yaXMgQnJlemlsbG9uIDxi b3Jpcy5icmV6aWxsb25AY29sbGFib3JhLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBCb3JpcyBCcmV6 aWxsb24gPGJvcmlzLmJyZXppbGxvbkBjb2xsYWJvcmEuY29tPgo+IExpbms6IGh0dHBzOi8vcGF0 Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC9tc2dpZC8yMDE5MDYwMzE2NTYxMC4yNDYxNC01 LWhlbGVuLmtvaWtlQGNvbGxhYm9yYS5jb20KPiAtLS0KPiAKPiBIaSwKPiAKPiBUaGlzIHBhdGNo IGZhaWxlZCB0byBhcHBseSBvbiBrZXJuZWwgc3RhYmxlIHY0LjE5LCBJJ20gcmUtc2VuZGluZyBp dAo+IGZpeGluZyB0aGUgY29uZmxpY3QuCgpOb3cgYXBwbGllZCwgdGhhbmtzLgoKZ3JlZyBrLWgK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C719C31E4A for ; Thu, 13 Jun 2019 16:34:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFD3320449 for ; Thu, 13 Jun 2019 16:34:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560443687; bh=07bkpKEzMR5J7jcewXkizrrcYdEWtLPi1MRpGfleZ6s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ImRUlfYw93ZayMWlReDuBh46fQ8c5iDTLtSX5MpIuOWiv52mVMNnxnV3lfttxSjUY POsAsThrjJkCD3coNh32k+8xJkEZegv39xpc3ToHq8UCZR92UPZ9ReKPNcFwULKL9A bT3aS1WrsKOabW5GlK7/MRU9Aqhg6kOeoZniYlrg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730771AbfFMQeq (ORCPT ); Thu, 13 Jun 2019 12:34:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:35220 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730762AbfFMHvP (ORCPT ); Thu, 13 Jun 2019 03:51:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB62E20851; Thu, 13 Jun 2019 07:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560412275; bh=07bkpKEzMR5J7jcewXkizrrcYdEWtLPi1MRpGfleZ6s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zxrTPABW1S+WfcBg2HM87A7hR+EswsuArXO1S7J5FhTJdewwfg7Zt19tGJPhUmevv /TS4VgSYlBqPR+jQo5XHwtByyu2WiITcz1hUekXHyNudmSAM7LExXbfUFRikeztr2j 9tb/SIKDVIZdozTkJewVDLE/wCdQFKAa+7xoLtp8= Date: Thu, 13 Jun 2019 09:51:12 +0200 From: Greg KH To: Helen Koike Cc: stable@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@collabora.com Subject: Re: [PATCH v5] drm/vc4: fix fb references in async update Message-ID: <20190613075112.GE19685@kroah.com> References: <156007492924468@kroah.com> <20190610131859.7616-1-helen.koike@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190610131859.7616-1-helen.koike@collabora.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jun 10, 2019 at 10:18:59AM -0300, Helen Koike wrote: > commit c16b85559dcfb5a348cc085a7b4c75ed49b05e2c upstream. > > Async update callbacks are expected to set the old_fb in the new_state > so prepare/cleanup framebuffers are balanced. > > Calling drm_atomic_set_fb_for_plane() (which gets a reference of the new > fb and put the old fb) is not required, as it's taken care by > drm_mode_cursor_universal() when calling drm_atomic_helper_update_plane(). > > Cc: # v4.19+ > Fixes: 539c320bfa97 ("drm/vc4: update cursors asynchronously through atomic") > Suggested-by: Boris Brezillon > Signed-off-by: Helen Koike > Reviewed-by: Boris Brezillon > Signed-off-by: Boris Brezillon > Link: https://patchwork.freedesktop.org/patch/msgid/20190603165610.24614-5-helen.koike@collabora.com > --- > > Hi, > > This patch failed to apply on kernel stable v4.19, I'm re-sending it > fixing the conflict. Now applied, thanks. greg k-h