From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/amd/display: fix compilation error Date: Thu, 13 Jun 2019 10:23:46 +0200 Message-ID: <20190613082346.GH23020@phenom.ffwll.local> References: <20190613023208.GA29690@hari-Inspiron-1545> <20190613024854.GA25104@hari-Inspiron-1545> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190613024854.GA25104@hari-Inspiron-1545> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hariprasad Kelam Cc: linux-kernel@vger.kernel.org, Yongqiang Sun , Charlene Liu , Leo Li , Bhawanpreet Lakha , David Airlie , Gloria Li , amd-gfx@lists.freedesktop.org, Nicholas Kazlauskas , Alex Deucher , Dmytro Laktyushkin , Tony Cheng , dri-devel@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= , Anthony Koo List-Id: amd-gfx.lists.freedesktop.org T24gVGh1LCBKdW4gMTMsIDIwMTkgYXQgMDg6MTg6NTRBTSArMDUzMCwgSGFyaXByYXNhZCBLZWxh bSB3cm90ZToKPiBPbiBXZWQsIEp1biAxMiwgMjAxOSBhdCAxMDozNToyNlBNIC0wNDAwLCBBbGV4 IERldWNoZXIgd3JvdGU6Cj4gPiBPbiBXZWQsIEp1biAxMiwgMjAxOSBhdCAxMDozNCBQTSBIYXJp cHJhc2FkIEtlbGFtCj4gPiA8aGFyaXByYXNhZC5rZWxhbUBnbWFpbC5jb20+IHdyb3RlOgo+ID4g Pgo+ID4gPiB0aGlzIHBhdGNoIGZpeGVzIGJlbG93IGNvbXBpbGF0aW9uIGVycm9yCj4gPiA+Cj4g PiA+IGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL2Rpc3BsYXkvZGMvZGNuMTAvZGNuMTBf aHdfc2VxdWVuY2VyLmM6IEluCj4gPiA+IGZ1bmN0aW9uIOKAmGRjbjEwX2FwcGx5X2N0eF9mb3Jf c3VyZmFjZeKAmToKPiA+ID4gZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlzcGxheS9k Yy9kY24xMC9kY24xMF9od19zZXF1ZW5jZXIuYzoyMzc4OjM6Cj4gPiA+IGVycm9yOiBpbXBsaWNp dCBkZWNsYXJhdGlvbiBvZiBmdW5jdGlvbiDigJh1ZGVsYXnigJkKPiA+ID4gWy1XZXJyb3I9aW1w bGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCj4gPiA+ICAgIHVkZWxheSh1bmRlcmZsb3dfY2hl Y2tfZGVsYXlfdXMpOwo+ID4gPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBIYXJpcHJhc2FkIEtlbGFt IDxoYXJpcHJhc2FkLmtlbGFtQGdtYWlsLmNvbT4KPiA+IAo+ID4gV2hhdCBicmFuY2ggaXMgdGhp cyBwYXRjaCBiYXNlZCBvbj8KPiA+IAo+ID4gQWxleAo+IAo+IEhpIEFsZXgsCj4gCj4gSXQgaXMg b24gbGludXgtbmV4dAoKZHJtLW1pc2MtbmV4dCBoYXMgU2FtJ3MgaGVhZGVyIGNsZWFudXAuIEkg Z3Vlc3Mgd2UgcHVsbCBsaW51eC9kZWxheS5oIGluCmltcGxpY2l0bHkgc29tZXdoZXJlLCBidXQg bm90IGZvciBhbGwgY29uZmlncy4KLURhbmllbAoKPiAKPiBUaGFua3MsCj4gSGFyaXByYXNhZCBr Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2RjbjEwL2Rj bjEwX2h3X3NlcXVlbmNlci5jIHwgMSArCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKykKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxh eS9kYy9kY24xMC9kY24xMF9od19zZXF1ZW5jZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlz cGxheS9kYy9kY24xMC9kY24xMF9od19zZXF1ZW5jZXIuYwo+ID4gPiBpbmRleCBkMjM1Mjk0OS4u MWFjOWE0ZiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2Rj L2RjbjEwL2RjbjEwX2h3X3NlcXVlbmNlci5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvZGlzcGxheS9kYy9kY24xMC9kY24xMF9od19zZXF1ZW5jZXIuYwo+ID4gPiBAQCAtMjMsNiAr MjMsNyBAQAo+ID4gPiAgICoKPiA+ID4gICAqLwo+ID4gPgo+ID4gPiArI2luY2x1ZGUgPGxpbnV4 L2RlbGF5Lmg+Cj4gPiA+ICAjaW5jbHVkZSAiZG1fc2VydmljZXMuaCIKPiA+ID4gICNpbmNsdWRl ICJjb3JlX3R5cGVzLmgiCj4gPiA+ICAjaW5jbHVkZSAicmVzb3VyY2UuaCIKPiA+ID4gLS0KPiA+ ID4gMi43LjQKPiA+ID4KPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiA+ID4gYW1kLWdmeCBtYWlsaW5nIGxpc3QKPiA+ID4gYW1kLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9hbWQtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl ciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4D24C31E45 for ; Thu, 13 Jun 2019 16:31:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8145D21721 for ; Thu, 13 Jun 2019 16:31:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Tx4JYWhF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392504AbfFMQbe (ORCPT ); Thu, 13 Jun 2019 12:31:34 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:43772 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730869AbfFMIXw (ORCPT ); Thu, 13 Jun 2019 04:23:52 -0400 Received: by mail-ed1-f65.google.com with SMTP id w33so29929692edb.10 for ; Thu, 13 Jun 2019 01:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=Bn9xqnDM/Ok90ZnjEVBJg4kKO4htMBt6EOE/1PNGbnY=; b=Tx4JYWhFEQ4paC9UQ1Ati/km78v81wLDRhSY/EalqBBnEClwSXCW9SqfMkR5Vrt97P asT6jG34nVFATlS4QY9GC03yFsuX84G1WiY/34dLIHU4OzW53IBMnx5nM3J8Q9aRFyxv ibza93j6ghZQ06OAwkUKXmZmbeAEPcVcyZX8Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=Bn9xqnDM/Ok90ZnjEVBJg4kKO4htMBt6EOE/1PNGbnY=; b=afdc4XOHoBDgBOmKSJR7+KmjEzkgCIkT5Fk5VSpcLipITbkUK5N6tVEFgyauaTTPUZ K8OGLNuomc0Zv6tC9sRJpLp7dOZcsmln3Evfga+f9OHw9bqaNXe9+EJOnkDDlNzDESG7 h4nmnuBsDQLUbrzRkUgJxBjbfnDVk3rtxqF7dISTv5b3X0JEut1RHkYj+iD+ftxYNcMk xSN1IOOXK98wTN+ysyPGqfTv9jTyw0cN9MAoZtI043mc1jMDvAEhB6kNuaI+Wmyhp0Tq nwT95dZxmU609A5Vi1Djo/WlX2vntWEwYdVetGdPjoRc/ue9kiEHHwnGyr5IdW3fntT+ AA6g== X-Gm-Message-State: APjAAAVqVDTFtqAAILU2KmUvsO6cgPZlblLqpZIxoQMSKx1z2kkK/Jxt m9Wn0oYph52mKTB487i4BPBtlA== X-Google-Smtp-Source: APXvYqwxpvYDtacITPIdTW/7to+7XC+PPO1+2atPD+W6vFoXNBpF2kvJ27BXQ7Kw1crdOAPDQ9j4Lg== X-Received: by 2002:a50:d1d8:: with SMTP id i24mr87310538edg.57.1560414230421; Thu, 13 Jun 2019 01:23:50 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id a3sm669461edr.48.2019.06.13.01.23.48 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 13 Jun 2019 01:23:49 -0700 (PDT) Date: Thu, 13 Jun 2019 10:23:46 +0200 From: Daniel Vetter To: Hariprasad Kelam Cc: Alex Deucher , Harry Wentland , Leo Li , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , Dmytro Laktyushkin , Bhawanpreet Lakha , Tony Cheng , Anthony Koo , Charlene Liu , Nicholas Kazlauskas , Yongqiang Sun , Gloria Li , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/amd/display: fix compilation error Message-ID: <20190613082346.GH23020@phenom.ffwll.local> Mail-Followup-To: Hariprasad Kelam , Alex Deucher , Harry Wentland , Leo Li , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "David (ChunMing) Zhou" , David Airlie , Dmytro Laktyushkin , Bhawanpreet Lakha , Tony Cheng , Anthony Koo , Charlene Liu , Nicholas Kazlauskas , Yongqiang Sun , Gloria Li , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20190613023208.GA29690@hari-Inspiron-1545> <20190613024854.GA25104@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190613024854.GA25104@hari-Inspiron-1545> X-Operating-System: Linux phenom 4.19.0-5-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 13, 2019 at 08:18:54AM +0530, Hariprasad Kelam wrote: > On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote: > > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam > > wrote: > > > > > > this patch fixes below compilation error > > > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In > > > function ‘dcn10_apply_ctx_for_surface’: > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3: > > > error: implicit declaration of function ‘udelay’ > > > [-Werror=implicit-function-declaration] > > > udelay(underflow_check_delay_us); > > > > > > Signed-off-by: Hariprasad Kelam > > > > What branch is this patch based on? > > > > Alex > > Hi Alex, > > It is on linux-next drm-misc-next has Sam's header cleanup. I guess we pull linux/delay.h in implicitly somewhere, but not for all configs. -Daniel > > Thanks, > Hariprasad k > > > --- > > > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c > > > index d2352949..1ac9a4f 100644 > > > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c > > > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c > > > @@ -23,6 +23,7 @@ > > > * > > > */ > > > > > > +#include > > > #include "dm_services.h" > > > #include "core_types.h" > > > #include "resource.h" > > > -- > > > 2.7.4 > > > > > > _______________________________________________ > > > amd-gfx mailing list > > > amd-gfx@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch