From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A7B6C31E45 for ; Thu, 13 Jun 2019 15:23:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E1A62082C for ; Thu, 13 Jun 2019 15:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560439434; bh=ylIuBR5yn6EAKJkZL96zcsc3cHp7vPCBtpQ1H9nxhuw=; h=Date:From:To:Cc:Subject:List-ID:From; b=0J3CQ6zJlImEKJDpRjWs2io+JQ46QnYuomWo2FyX9/8Gfd/Hk8W1lxS24BQL46s4m 7Yn85kFTexc9noiQMr7mXJ3FhVMOp0+66nllpF6sbv6gSIIvyxSpmcMr0fj43JN12f ggR282qDUTbOKIZ08hwGykpaRj9HdumoNfCfMb1U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732705AbfFMPXw (ORCPT ); Thu, 13 Jun 2019 11:23:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:51252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731777AbfFMMYG (ORCPT ); Thu, 13 Jun 2019 08:24:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7AF0821773; Thu, 13 Jun 2019 12:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560428645; bh=ylIuBR5yn6EAKJkZL96zcsc3cHp7vPCBtpQ1H9nxhuw=; h=Date:From:To:Cc:Subject:From; b=bOyO5TaMLcD0owl1N4BpMw+OuphlFIoRdk4t2MUxea63aPdOd4AEEX4AqEpA3dQ7m w5iTYcM5zYoJtkOXRloA2EmL3kF0apL5Bh9eocOjtVdJ8XQiYxb754ToOL69plriSm XLPV4JpzEVCah0M5xam9cIbABra6qCiTXCVOWXes= Date: Thu, 13 Jun 2019 14:24:02 +0200 From: Greg Kroah-Hartman To: Rob Clark , Sean Paul , David Airlie , Daniel Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: [PATCH] msm: no need to check return value of debugfs_create functions Message-ID: <20190613122402.GA30678@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Rob Clark Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/msm/msm_perf.c | 15 ++------------- drivers/gpu/drm/msm/msm_rd.c | 15 ++------------- 2 files changed, 4 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_perf.c b/drivers/gpu/drm/msm/msm_perf.c index 5ab21bd2decb..95948cfe7a12 100644 --- a/drivers/gpu/drm/msm/msm_perf.c +++ b/drivers/gpu/drm/msm/msm_perf.c @@ -205,7 +205,6 @@ int msm_perf_debugfs_init(struct drm_minor *minor) { struct msm_drm_private *priv = minor->dev->dev_private; struct msm_perf_state *perf; - struct dentry *ent; /* only create on first minor: */ if (priv->perf) @@ -220,19 +219,9 @@ int msm_perf_debugfs_init(struct drm_minor *minor) mutex_init(&perf->read_lock); priv->perf = perf; - ent = debugfs_create_file("perf", S_IFREG | S_IRUGO, - minor->debugfs_root, perf, &perf_debugfs_fops); - if (!ent) { - DRM_ERROR("Cannot create /sys/kernel/debug/dri/%pd/perf\n", - minor->debugfs_root); - goto fail; - } - + debugfs_create_file("perf", S_IFREG | S_IRUGO, minor->debugfs_root, + perf, &perf_debugfs_fops); return 0; - -fail: - msm_perf_debugfs_cleanup(priv); - return -1; } void msm_perf_debugfs_cleanup(struct msm_drm_private *priv) diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c index d21172933d92..46f7eb6a7eaa 100644 --- a/drivers/gpu/drm/msm/msm_rd.c +++ b/drivers/gpu/drm/msm/msm_rd.c @@ -244,7 +244,6 @@ static void rd_cleanup(struct msm_rd_state *rd) static struct msm_rd_state *rd_init(struct drm_minor *minor, const char *name) { struct msm_rd_state *rd; - struct dentry *ent; int ret = 0; rd = kzalloc(sizeof(*rd), GFP_KERNEL); @@ -258,20 +257,10 @@ static struct msm_rd_state *rd_init(struct drm_minor *minor, const char *name) init_waitqueue_head(&rd->fifo_event); - ent = debugfs_create_file(name, S_IFREG | S_IRUGO, - minor->debugfs_root, rd, &rd_debugfs_fops); - if (!ent) { - DRM_ERROR("Cannot create /sys/kernel/debug/dri/%pd/%s\n", - minor->debugfs_root, name); - ret = -ENOMEM; - goto fail; - } + debugfs_create_file(name, S_IFREG | S_IRUGO, minor->debugfs_root, rd, + &rd_debugfs_fops); return rd; - -fail: - rd_cleanup(rd); - return ERR_PTR(ret); } int msm_rd_debugfs_init(struct drm_minor *minor) -- 2.22.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: [PATCH] msm: no need to check return value of debugfs_create functions Date: Thu, 13 Jun 2019 14:24:02 +0200 Message-ID: <20190613122402.GA30678@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Rob Clark , Sean Paul , David Airlie , Daniel Vetter Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org V2hlbiBjYWxsaW5nIGRlYnVnZnMgZnVuY3Rpb25zLCB0aGVyZSBpcyBubyBuZWVkIHRvIGV2ZXIg Y2hlY2sgdGhlCnJldHVybiB2YWx1ZS4gIFRoZSBmdW5jdGlvbiBjYW4gd29yayBvciBub3QsIGJ1 dCB0aGUgY29kZSBsb2dpYyBzaG91bGQKbmV2ZXIgZG8gc29tZXRoaW5nIGRpZmZlcmVudCBiYXNl ZCBvbiB0aGlzLgoKQ2M6IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWlsLmNvbT4KQ2M6IFNlYW4g UGF1bCA8c2VhbkBwb29ybHkucnVuPgpDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4Lmll PgpDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgpDYzogbGludXgtYXJtLW1zbUB2 Z2VyLmtlcm5lbC5vcmcKQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKQ2M6IGZy ZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKU2lnbmVkLW9mZi1ieTogR3JlZyBLcm9haC1I YXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KLS0tCiBkcml2ZXJzL2dwdS9kcm0v bXNtL21zbV9wZXJmLmMgfCAxNSArKy0tLS0tLS0tLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS9tc20v bXNtX3JkLmMgICB8IDE1ICsrLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA0IGluc2Vy dGlvbnMoKyksIDI2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9t c20vbXNtX3BlcmYuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX3BlcmYuYwppbmRleCA1YWIy MWJkMmRlY2IuLjk1OTQ4Y2ZlN2ExMiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9t c21fcGVyZi5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX3BlcmYuYwpAQCAtMjA1LDcg KzIwNSw2IEBAIGludCBtc21fcGVyZl9kZWJ1Z2ZzX2luaXQoc3RydWN0IGRybV9taW5vciAqbWlu b3IpCiB7CiAJc3RydWN0IG1zbV9kcm1fcHJpdmF0ZSAqcHJpdiA9IG1pbm9yLT5kZXYtPmRldl9w cml2YXRlOwogCXN0cnVjdCBtc21fcGVyZl9zdGF0ZSAqcGVyZjsKLQlzdHJ1Y3QgZGVudHJ5ICpl bnQ7CiAKIAkvKiBvbmx5IGNyZWF0ZSBvbiBmaXJzdCBtaW5vcjogKi8KIAlpZiAocHJpdi0+cGVy ZikKQEAgLTIyMCwxOSArMjE5LDkgQEAgaW50IG1zbV9wZXJmX2RlYnVnZnNfaW5pdChzdHJ1Y3Qg ZHJtX21pbm9yICptaW5vcikKIAltdXRleF9pbml0KCZwZXJmLT5yZWFkX2xvY2spOwogCXByaXYt PnBlcmYgPSBwZXJmOwogCi0JZW50ID0gZGVidWdmc19jcmVhdGVfZmlsZSgicGVyZiIsIFNfSUZS RUcgfCBTX0lSVUdPLAotCQkJbWlub3ItPmRlYnVnZnNfcm9vdCwgcGVyZiwgJnBlcmZfZGVidWdm c19mb3BzKTsKLQlpZiAoIWVudCkgewotCQlEUk1fRVJST1IoIkNhbm5vdCBjcmVhdGUgL3N5cy9r ZXJuZWwvZGVidWcvZHJpLyVwZC9wZXJmXG4iLAotCQkJCW1pbm9yLT5kZWJ1Z2ZzX3Jvb3QpOwot CQlnb3RvIGZhaWw7Ci0JfQotCisJZGVidWdmc19jcmVhdGVfZmlsZSgicGVyZiIsIFNfSUZSRUcg fCBTX0lSVUdPLCBtaW5vci0+ZGVidWdmc19yb290LAorCQkJICAgIHBlcmYsICZwZXJmX2RlYnVn ZnNfZm9wcyk7CiAJcmV0dXJuIDA7Ci0KLWZhaWw6Ci0JbXNtX3BlcmZfZGVidWdmc19jbGVhbnVw KHByaXYpOwotCXJldHVybiAtMTsKIH0KIAogdm9pZCBtc21fcGVyZl9kZWJ1Z2ZzX2NsZWFudXAo c3RydWN0IG1zbV9kcm1fcHJpdmF0ZSAqcHJpdikKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9tc20vbXNtX3JkLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9yZC5jCmluZGV4IGQyMTE3 MjkzM2Q5Mi4uNDZmN2ViNmE3ZWFhIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL21z bV9yZC5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX3JkLmMKQEAgLTI0NCw3ICsyNDQs NiBAQCBzdGF0aWMgdm9pZCByZF9jbGVhbnVwKHN0cnVjdCBtc21fcmRfc3RhdGUgKnJkKQogc3Rh dGljIHN0cnVjdCBtc21fcmRfc3RhdGUgKnJkX2luaXQoc3RydWN0IGRybV9taW5vciAqbWlub3Is IGNvbnN0IGNoYXIgKm5hbWUpCiB7CiAJc3RydWN0IG1zbV9yZF9zdGF0ZSAqcmQ7Ci0Jc3RydWN0 IGRlbnRyeSAqZW50OwogCWludCByZXQgPSAwOwogCiAJcmQgPSBremFsbG9jKHNpemVvZigqcmQp LCBHRlBfS0VSTkVMKTsKQEAgLTI1OCwyMCArMjU3LDEwIEBAIHN0YXRpYyBzdHJ1Y3QgbXNtX3Jk X3N0YXRlICpyZF9pbml0KHN0cnVjdCBkcm1fbWlub3IgKm1pbm9yLCBjb25zdCBjaGFyICpuYW1l KQogCiAJaW5pdF93YWl0cXVldWVfaGVhZCgmcmQtPmZpZm9fZXZlbnQpOwogCi0JZW50ID0gZGVi dWdmc19jcmVhdGVfZmlsZShuYW1lLCBTX0lGUkVHIHwgU19JUlVHTywKLQkJCW1pbm9yLT5kZWJ1 Z2ZzX3Jvb3QsIHJkLCAmcmRfZGVidWdmc19mb3BzKTsKLQlpZiAoIWVudCkgewotCQlEUk1fRVJS T1IoIkNhbm5vdCBjcmVhdGUgL3N5cy9rZXJuZWwvZGVidWcvZHJpLyVwZC8lc1xuIiwKLQkJCQlt aW5vci0+ZGVidWdmc19yb290LCBuYW1lKTsKLQkJcmV0ID0gLUVOT01FTTsKLQkJZ290byBmYWls OwotCX0KKwlkZWJ1Z2ZzX2NyZWF0ZV9maWxlKG5hbWUsIFNfSUZSRUcgfCBTX0lSVUdPLCBtaW5v ci0+ZGVidWdmc19yb290LCByZCwKKwkJCSAgICAmcmRfZGVidWdmc19mb3BzKTsKIAogCXJldHVy biByZDsKLQotZmFpbDoKLQlyZF9jbGVhbnVwKHJkKTsKLQlyZXR1cm4gRVJSX1BUUihyZXQpOwog fQogCiBpbnQgbXNtX3JkX2RlYnVnZnNfaW5pdChzdHJ1Y3QgZHJtX21pbm9yICptaW5vcikKLS0g CjIuMjIuMAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K RnJlZWRyZW5vIG1haWxpbmcgbGlzdApGcmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5v