From: Kees Cook <keescook@chromium.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 5/5] x86/vsyscall: Change the default vsyscall mode to xonly
Date: Thu, 13 Jun 2019 22:19:23 -0700 [thread overview]
Message-ID: <201906132218.E923F38F@keescook> (raw)
In-Reply-To: <CALCETrUYNavL8pu4jQqJjoT=PdeRyjeoLDn=0r7h=2XsHDMezQ@mail.gmail.com>
On Thu, Jun 13, 2019 at 12:14:50PM -0700, Andy Lutomirski wrote:
> On Mon, Jun 10, 2019 at 1:44 PM Kees Cook <keescook@chromium.org> wrote:
> >
> > On Mon, Jun 10, 2019 at 01:25:31PM -0700, Andy Lutomirski wrote:
> > > The use case for full emulation over xonly is very esoteric. Let's
> > > change the default to the safer xonly mode.
> >
> > Perhaps describe the esoteric cases here (and maybe in the Kconfig help
> > text)? That should a user determine if they actually need it. (What
> > would the failure under xonly look like for someone needing emulate?)
>
> I added it to the Kconfig text.
>
> Right now, the failure will just be a segfault. I could add some
> logic so that it would log "invalid read to vsyscall page -- fix your
> userspace or boot with vsyscall=emulate". Do you think that's
> important?
I think it would be a friendly way to help anyone wondering why
something suddenly started segfaulting, yeah. Just a pr_warn_once() or
something (not a WARN() since it's "intentionally" reachable by
userspace).
--
Kees Cook
prev parent reply other threads:[~2019-06-14 5:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 20:25 [PATCH 0/5] vsyscall xonly mode Andy Lutomirski
2019-06-10 20:25 ` [PATCH 1/5] x86/vsyscall: Remove the vsyscall=native documentation Andy Lutomirski
2019-06-10 20:25 ` [PATCH 2/5] x86/vsyscall: Add a new vsyscall=xonly mode Andy Lutomirski
2019-06-10 20:43 ` Kees Cook
2019-06-13 19:08 ` Andy Lutomirski
2019-06-10 20:25 ` [PATCH 3/5] x86/vsyscall: Document odd #PF's error code for vsyscalls Andy Lutomirski
2019-06-10 20:40 ` Kees Cook
2019-06-13 19:07 ` Andy Lutomirski
2019-06-10 20:25 ` [PATCH 4/5] selftests/x86/vsyscall: Verify that vsyscall=none blocks execution Andy Lutomirski
2019-06-10 20:25 ` [PATCH 5/5] x86/vsyscall: Change the default vsyscall mode to xonly Andy Lutomirski
2019-06-10 20:44 ` Kees Cook
2019-06-13 19:14 ` Andy Lutomirski
2019-06-14 5:19 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201906132218.E923F38F@keescook \
--to=keescook@chromium.org \
--cc=bp@alien8.de \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.