From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 14 Jun 2019 08:43:13 +0200 From: Christoph Hellwig Subject: Re: [PATCH 18/22] mm: mark DEVICE_PUBLIC as broken Message-ID: <20190614064313.GM7246@lst.de> References: <20190613094326.24093-1-hch@lst.de> <20190613094326.24093-19-hch@lst.de> <20190613194430.GY22062@mellanox.com> <20190613195819.GA22062@mellanox.com> <20190614004314.GD783@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190614004314.GD783@iweiny-DESK2.sc.intel.com> Sender: owner-linux-mm@kvack.org To: Ira Weiny Cc: Jason Gunthorpe , Ralph Campbell , "linux-nvdimm@lists.01.org" , "nouveau@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , =?iso-8859-1?B?Suly9G1l?= Glisse , Ben Skeggs , "linux-pci@vger.kernel.org" , Christoph Hellwig List-ID: On Thu, Jun 13, 2019 at 05:43:15PM -0700, Ira Weiny wrote: > yes but the earlier patch: > > [PATCH 03/22] mm: remove hmm_devmem_add_resource > > Removes the only place type is set to MEMORY_DEVICE_PUBLIC. > > So I think it is ok. Frankly I was wondering if we should remove the public > type altogether but conceptually it seems ok. But I don't see any users of it > so... should we get rid of it in the code rather than turning the config off? That was my original idea. But then again Jerome spent a lot of effort putting hooks for it all over the mm and it would seem a little root to just rip this out ASAP. I'll give it some more time, but it it doesn't get used after a few more kernel releases we should nuke it. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 18/22] mm: mark DEVICE_PUBLIC as broken Date: Fri, 14 Jun 2019 08:43:13 +0200 Message-ID: <20190614064313.GM7246@lst.de> References: <20190613094326.24093-1-hch@lst.de> <20190613094326.24093-19-hch@lst.de> <20190613194430.GY22062@mellanox.com> <20190613195819.GA22062@mellanox.com> <20190614004314.GD783@iweiny-DESK2.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190614004314.GD783-J5EW/p2F9lUlb2qzJQmr9q2pdiUAq4bhAL8bYrjMMd8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Ira Weiny Cc: Ralph Campbell , "linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org" , "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , Jason Gunthorpe , Ben Skeggs , "linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Christoph Hellwig List-Id: nouveau.vger.kernel.org T24gVGh1LCBKdW4gMTMsIDIwMTkgYXQgMDU6NDM6MTVQTSAtMDcwMCwgSXJhIFdlaW55IHdyb3Rl Ogo+IDxzaWdoPiAgeWVzIGJ1dCB0aGUgZWFybGllciBwYXRjaDoKPiAKPiBbUEFUQ0ggMDMvMjJd IG1tOiByZW1vdmUgaG1tX2Rldm1lbV9hZGRfcmVzb3VyY2UKPiAKPiBSZW1vdmVzIHRoZSBvbmx5 IHBsYWNlIHR5cGUgaXMgc2V0IHRvIE1FTU9SWV9ERVZJQ0VfUFVCTElDLgo+IAo+IFNvIEkgdGhp bmsgaXQgaXMgb2suICBGcmFua2x5IEkgd2FzIHdvbmRlcmluZyBpZiB3ZSBzaG91bGQgcmVtb3Zl IHRoZSBwdWJsaWMKPiB0eXBlIGFsdG9nZXRoZXIgYnV0IGNvbmNlcHR1YWxseSBpdCBzZWVtcyBv ay4gIEJ1dCBJIGRvbid0IHNlZSBhbnkgdXNlcnMgb2YgaXQKPiBzby4uLiAgc2hvdWxkIHdlIGdl dCByaWQgb2YgaXQgaW4gdGhlIGNvZGUgcmF0aGVyIHRoYW4gdHVybmluZyB0aGUgY29uZmlnIG9m Zj8KClRoYXQgd2FzIG15IG9yaWdpbmFsIGlkZWEuICBCdXQgdGhlbiBhZ2FpbiBKZXJvbWUgc3Bl bnQgYSBsb3Qgb2YgZWZmb3J0CnB1dHRpbmcgaG9va3MgZm9yIGl0IGFsbCBvdmVyIHRoZSBtbSBh bmQgaXQgd291bGQgc2VlbSBhIGxpdHRsZSByb290CnRvIGp1c3QgcmlwIHRoaXMgb3V0IEFTQVAu ICBJJ2xsIGdpdmUgaXQgc29tZSBtb3JlIHRpbWUsIGJ1dCBpdCBpdCBkb2Vzbid0CmdldCB1c2Vk IGFmdGVyIGEgZmV3IG1vcmUga2VybmVsIHJlbGVhc2VzIHdlIHNob3VsZCBudWtlIGl0LgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOb3V2ZWF1IG1haWxp bmcgbGlzdApOb3V2ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXU=