From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 1/8] platform: x86: acer-wmi: no need to check return value of debugfs_create functions Date: Fri, 14 Jun 2019 08:53:39 +0200 Message-ID: <20190614065339.GB21447@kroah.com> References: <20190612121258.19535-1-gregkh@linuxfoundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: Darren Hart , Andy Shevchenko , "Lee, Chun-Yi" , Platform Driver , Linux Kernel Mailing List List-Id: platform-driver-x86.vger.kernel.org On Fri, Jun 14, 2019 at 09:48:04AM +0300, Andy Shevchenko wrote: > On Wed, Jun 12, 2019 at 3:13 PM Greg Kroah-Hartman > wrote: > > > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > > > Also, because there is no need to save the file dentry, remove the > > variable that was saving it and just recursively delete the whole > > directory. > > > > Through which tree you want to proceed this? What ever is easier for you, I can take it through mine, as I have a lot of other patches like this queued up already, or it can go through yours. thanks, greg k-h