From: Steffen Klassert <steffen.klassert@secunet.com>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH] af_key: Fix memory leak in key_notify_policy.
Date: Fri, 14 Jun 2019 12:17:08 +0200 [thread overview]
Message-ID: <20190614101708.GP17989@gauss3.secunet.de> (raw)
In-Reply-To: <20190614101338.hia635sctr6qjmd2@azazel.net>
On Fri, Jun 14, 2019 at 11:13:38AM +0100, Jeremy Sowden wrote:
>
> That reminds me. Stephen Rothwell reported a problem with the "Fixes:"
> tag:
>
> On 2019-05-29, at 07:48:12 +1000, Stephen Rothwell wrote:
> > In commit
> >
> > 7c80eb1c7e2b ("af_key: fix leaks in key_pol_get_resp and dump_sp.")
> >
> > Fixes tag
> >
> > Fixes: 55569ce256ce ("Fix conversion between IPSEC_MODE_xxx and XFRM_MODE_xxx.")
> >
> > has these problem(s):
> >
> > - Subject does not match target commit subject
> > Just use
> > git log -1 --format='Fixes: %h ("%s")'
>
> What's the procedure for fixing this sort of thing? Do you need me to
> do anything?
No, that patch is already commited. We can't change the commit
message anymore. Just keep it in mind for next time.
next prev parent reply other threads:[~2019-06-14 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 8:26 [PATCH] af_key: Fix memory leak in key_notify_policy Young Xiao
2019-06-14 8:53 ` Steffen Klassert
2019-06-14 9:59 ` Jeremy Sowden
2019-06-14 10:13 ` Jeremy Sowden
2019-06-14 10:17 ` Steffen Klassert [this message]
2019-06-14 10:31 ` Jeremy Sowden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614101708.GP17989@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jeremy@azazel.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.