From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Guenter Roeck <groeck@chromium.org>,
Vadim Sukhomlinov <sukhomlinov@google.com>,
apronin@chromium.org, Matthias Kaehlcke <mka@chromium.org>,
Stephen Boyd <swboyd@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-integrity@vger.kernel.org,
Luigi Semenzato <semenzato@chromium.org>
Subject: Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations
Date: Fri, 14 Jun 2019 18:15:05 +0300 [thread overview]
Message-ID: <20190614151451.GA11241@linux.intel.com> (raw)
In-Reply-To: <CAD=FV=UoSV9LKOTMuXKRfgFir+7_qPkuhSLN6XJEKPiRPuJJwg@mail.gmail.com>
On Thu, Jun 13, 2019 at 08:20:41AM -0700, Doug Anderson wrote:
> Found the patch in your tree at
> <http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/41f15a4f02092d531fb34b42a06e9a1603a7df27>.
> I'm decidedly a non-expert here, mostly just wrangling a patch that
> someone else came up with. :-) ...but let's see...
>
> I think you're asking if the "Fixes" looks sane. I guess it depends
> on what you're trying to accomplish. Certainly what you've tagged in
> "Fixes" marks the point where it would be easiest to backport this fix
> to. ...but I think the problem is much older than that patch.
>
> As I understand it, this problem has existed for much longer. I
> believe that ${SUBJECT} patch evolved from an investigation that Luigi
> Semenzato did back in 2013 when we got back some Chromebooks whose
> TPMs claimed that they had been "attacked". Said another way, I
> believe it is an evolution of the patch <https://crrev.com/c/57988>
> ("CHROMIUM: workaround for Infineon TPM broken defensive timeout").
>
> ...so technically someone ought to want this on all old kernels.
> Maybe keep the "Cc: stable" but remove the "Fixes"?
I guess that is what we have to do then.
/Jarkko
next prev parent reply other threads:[~2019-06-14 15:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 22:01 [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations Douglas Anderson
2019-06-12 19:16 ` Jarkko Sakkinen
2019-06-13 13:58 ` Jarkko Sakkinen
2019-06-13 15:20 ` Doug Anderson
2019-06-14 15:15 ` Jarkko Sakkinen [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-07-11 16:29 Douglas Anderson
2019-07-11 16:39 ` Jason Gunthorpe
2019-07-11 16:41 ` Doug Anderson
2019-07-11 17:04 ` Greg KH
2019-07-11 17:17 ` Jason Gunthorpe
2019-07-11 17:26 ` Greg KH
2019-07-11 17:28 ` Doug Anderson
2019-07-12 11:50 ` Greg KH
2019-07-12 15:00 ` Doug Anderson
2019-07-12 15:27 ` Greg KH
2019-08-05 21:05 ` Jarkko Sakkinen
2019-07-12 15:47 ` Jarkko Sakkinen
2019-07-12 15:21 ` Jarkko Sakkinen
2019-07-11 18:35 ` Jarkko Sakkinen
2019-07-11 19:43 ` Jarkko Sakkinen
2019-07-11 19:46 ` Jason Gunthorpe
2019-07-12 3:31 ` Jarkko Sakkinen
2019-07-12 3:35 ` Jarkko Sakkinen
2019-07-12 11:58 ` Jason Gunthorpe
2019-07-11 19:55 ` Doug Anderson
2019-07-11 18:34 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614151451.GA11241@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=apronin@chromium.org \
--cc=arnd@arndb.de \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=peterhuewe@gmx.de \
--cc=semenzato@chromium.org \
--cc=sukhomlinov@google.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.