From: Thierry Reding <thierry.reding@gmail.com>
To: Bitan Biswas <bbiswas@nvidia.com>
Cc: Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Timo Alho <talho@nvidia.com>, Sivaram Nair <sivaramn@nvidia.com>,
Allison Randal <allison@lohutok.net>,
Thomas Gleixner <tglx@linutronix.de>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1] firmware: tegra: early resume bpmp
Date: Fri, 14 Jun 2019 17:48:27 +0200 [thread overview]
Message-ID: <20190614154827.GA26922@ulmo> (raw)
In-Reply-To: <1560515499-1015-1-git-send-email-bbiswas@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]
On Fri, Jun 14, 2019 at 05:31:39AM -0700, Bitan Biswas wrote:
> Early resume Tegra bpmp to fix Xavier clock rate error as follows:
> [ 159.017101] of_serial 3110000.serial: calling platform_pm_resume+0x0/0x58 @ 317, parent: cbb
> [ 159.025501] of_serial 3110000.serial: platform_pm_resume+0x0/0x58 returned 0 after 14 usecs
> [ 159.033694] tegra-i2c 31c0000.i2c: calling platform_pm_resume+0x0/0x58 @ 317, parent: cbb
> [ 159.042254] tegra-i2c 31c0000.i2c: failed changing clock rate: -22
> [ 159.048216] PM: dpm_run_callback(): platform_pm_resume+0x0/0x58 returns -22
> [ 159.055553] tegra-i2c 31c0000.i2c: platform_pm_resume+0x0/0x58 returned -22 after 13072 usecs
> [ 159.063875] PM: Device 31c0000.i2c failed to resume: error -22
>
> Signed-off-by: Bitan Biswas <bbiswas@nvidia.com>
> ---
> drivers/firmware/tegra/bpmp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c
> index dd775e8..de09036 100644
> --- a/drivers/firmware/tegra/bpmp.c
> +++ b/drivers/firmware/tegra/bpmp.c
> @@ -811,7 +811,9 @@ static int __maybe_unused tegra_bpmp_resume(struct device *dev)
> return 0;
> }
>
> -static SIMPLE_DEV_PM_OPS(tegra_bpmp_pm_ops, NULL, tegra_bpmp_resume);
> +const struct dev_pm_ops tegra_bpmp_pm_ops = {
> + .resume_early = tegra_bpmp_resume
> +};
I've changed this to be static while applying to for-5.3/firmware.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-14 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 12:31 [PATCH V1] firmware: tegra: early resume bpmp Bitan Biswas
2019-06-14 12:31 ` Bitan Biswas
2019-06-14 15:48 ` Thierry Reding [this message]
2019-06-14 16:40 ` Bitan Biswas
2019-06-14 16:40 ` Bitan Biswas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614154827.GA26922@ulmo \
--to=thierry.reding@gmail.com \
--cc=allison@lohutok.net \
--cc=bbiswas@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sivaramn@nvidia.com \
--cc=talho@nvidia.com \
--cc=tglx@linutronix.de \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.