From: Saiyam Doshi <saiyamdoshi.in@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: groeck@google.com, linux-kernel@vger.kernel.org,
groeck@chromium.org, adurbin@chromium.org, dlaurie@chromium.org
Subject: Re: [PATCH] gsmi: replace printk with relevant dev_<level>
Date: Fri, 14 Jun 2019 23:46:06 +0530 [thread overview]
Message-ID: <20190614181606.GA4448@ahmlpt0706> (raw)
In-Reply-To: <20190614060919.GA7271@kroah.com>
On Fri, Jun 14, 2019 at 08:09:19AM +0200, Greg KH wrote:
> On Fri, Jun 14, 2019 at 12:27:05AM +0530, Saiyam Doshi wrote:
> > Replace printk() with dev_* macros for logging consistency.
> > In process of replacing printk with dev_err, dev_info etc.,
> > removed unnecessary "out of memory" debug message.
>
> That is multiple things done in the same patch, please break this up
> into a patch series, only doing one "logical" thing per patch.
Agreed. I could have broken it into patch set.
> Note, generic cleanup patches like this are tough to get done in the
> "real" part of the kernel, I strongly recommend you start out in
> drivers/staging/ where these types of changes are welcomed. Get
> experience there and then move out into other areas of the kernel if you
> want to, that way you don't annoy developers/maintainers with basic
> errors like this.
>
> good luck!
Noted. Thanks Greg for feedback and suggestion.
prev parent reply other threads:[~2019-06-14 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 18:57 [PATCH] gsmi: replace printk with relevant dev_<level> Saiyam Doshi
2019-06-14 6:09 ` Greg KH
2019-06-14 18:16 ` Saiyam Doshi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614181606.GA4448@ahmlpt0706 \
--to=saiyamdoshi.in@gmail.com \
--cc=adurbin@chromium.org \
--cc=dlaurie@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.