Re: [PATCH net-next 1/3] net/sched: Introduce action ct

[Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>]

On Fri, Jun 14, 2019 at 11:07:37AM -0700, Cong Wang wrote:
> On Tue, Jun 11, 2019 at 9:44 AM Marcelo Ricardo Leitner
> <marcelo.leitner@gmail.com> wrote:
> > I had suggested to let act_ct handle the above as well, as there is a
> > big chunk of code on both that is pretty similar. There is quite some
> > boilerplate for interfacing with conntrack which is duplicated.
> 
> Why do you want to mix retrieving conntrack info with executing
> conntrack?

To save on the heavy boilerplate for interfacing with conntrack.

> 
> They are totally different things to me, act_ctinfo merely retrieves
> information from conntrack, while this one, act_ct, is supposed to
> move packets to conntrack.

Seems we have a different understanding for "move packets to
conntrack": conntrack will not consume the packets after this.
But after act_ct is executed, if not with the clear flag, skb will now
have the skb->_nfct entry available, on which flower then will be able
to match. So in essence, it is also fetching information from
conntrack.

I see act_ctinfo is a subset of what act_ct is doing.

  Marcelo