From: Wolfram Sang <wsa@the-dreams.de>
To: Bitan Biswas <bbiswas@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shardar Mohammed <smohammed@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Mantravadi Karthik <mkarthik@nvidia.com>
Subject: Re: [PATCH V3] i2c: busses: tegra: Add suspend-resume support
Date: Fri, 14 Jun 2019 23:11:29 +0200 [thread overview]
Message-ID: <20190614211129.GG17899@ninjato> (raw)
In-Reply-To: <1559885867-10190-1-git-send-email-bbiswas@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]
On Thu, Jun 06, 2019 at 10:37:47PM -0700, Bitan Biswas wrote:
> Post suspend I2C registers have power on reset values. Before any
> transfer initialize I2C registers to prevent I2C transfer timeout
> and implement suspend and resume callbacks needed. Fix below errors
> post suspend:
>
> 1) Tegra I2C transfer timeout during jetson tx2 resume:
>
> [ 27.520613] pca953x 1-0074: calling pca953x_resume+0x0/0x1b0 @ 2939, parent: i2c-1
> [ 27.633623] tegra-i2c 3160000.i2c: i2c transfer timed out
> [ 27.639162] pca953x 1-0074: Unable to sync registers 0x3-0x5. -110
> [ 27.645336] pca953x 1-0074: Failed to sync GPIO dir registers: -110
> [ 27.651596] PM: dpm_run_callback(): pca953x_resume+0x0/0x1b0 returns -110
> [ 27.658375] pca953x 1-0074: pca953x_resume+0x0/0x1b0 returned -110 after 127152 usecs
> [ 27.666194] PM: Device 1-0074 failed to resume: error -110
>
> 2) Tegra I2C transfer timeout error on jetson Xavier post resume.
>
> Remove i2c bus lock-unlock calls in resume callback as i2c_mark_adapter_*
> (suspended-resumed) help ensure i2c core calls from client are not
> executed before i2c-tegra resume.
>
> Signed-off-by: Bitan Biswas <bbiswas@nvidia.com>
Applied to for-next, thanks!
Without a maintainer ack, this is an exception this time. Should we add
Dmitry as another maintainer or reviewer at least?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-14 21:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 5:37 [PATCH V3] i2c: busses: tegra: Add suspend-resume support Bitan Biswas
2019-06-07 5:37 ` Bitan Biswas
2019-06-07 6:27 ` Dmitry Osipenko
2019-06-13 12:00 ` Bitan Biswas
2019-06-13 12:00 ` Bitan Biswas
2019-06-14 21:11 ` Wolfram Sang [this message]
2019-06-15 4:36 ` Bitan Biswas
2019-06-15 4:36 ` Bitan Biswas
2019-06-15 4:54 ` Wolfram Sang
2019-06-16 13:56 ` Dmitry Osipenko
2019-06-17 7:02 ` Thierry Reding
2019-06-17 12:16 ` Dmitry Osipenko
2019-06-17 7:09 ` Thierry Reding
2019-06-17 17:58 ` Bitan Biswas
2019-06-17 17:58 ` Bitan Biswas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614211129.GG17899@ninjato \
--to=wsa@the-dreams.de \
--cc=bbiswas@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=skomatineni@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.