All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Saiyam Doshi <saiyamdoshi.in@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH] staging: android: fix style problem
Date: Sat, 15 Jun 2019 19:31:49 +0200	[thread overview]
Message-ID: <20190615173149.GA4914@kroah.com> (raw)
In-Reply-To: <20190614194156.GA21401@ahmlpt0706>

On Sat, Jun 15, 2019 at 01:11:56AM +0530, Saiyam Doshi wrote:
> checkpatch reported "WARNING: line over 80 characters". This
> patch fixes it by aligning function arguments.
> 
> Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com>
> ---
>  drivers/staging/android/ion/ion_chunk_heap.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c
> index 3cdde9c1a717..6aceab2e77e4 100644
> --- a/drivers/staging/android/ion/ion_chunk_heap.c
> +++ b/drivers/staging/android/ion/ion_chunk_heap.c
> @@ -107,7 +107,9 @@ static struct ion_heap_ops chunk_heap_ops = {
>  	.unmap_kernel = ion_heap_unmap_kernel,
>  };
>  
> -struct ion_heap *ion_chunk_heap_create(phys_addr_t base, size_t size, size_t chunk_size)
> +struct ion_heap *ion_chunk_heap_create(phys_addr_t base,
> +				       size_t size,
> +				       size_t chunk_size)

Just break the line at "size_t size,", no need for 3 lines when 2 will
do.

thanks,

greg k-h

      reply	other threads:[~2019-06-15 17:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 19:41 [PATCH] staging: android: fix style problem Saiyam Doshi
2019-06-15 17:31 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190615173149.GA4914@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saiyamdoshi.in@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.