Re: [Warror][ 02/23] ndctl: make MACHINE_ARCH and ignore from libblockdev

[Adrian Bunk <bunk@stusta.de>]

On Sat, Jun 15, 2019 at 10:57:06AM -0700, Armin Kuster wrote:
>...
> --- a/meta-oe/conf/layer.conf
> +++ b/meta-oe/conf/layer.conf
> @@ -51,6 +51,12 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
>    phoronix-test-suite->php \
>  "
>  
> +# Depends on ndctl (through nvdimm PACKAGECONFIG) which depends on MACHINE_ARCH kernel
> +# and making libblockdev MACHINE_ARCH is not an option as python3-blivet, udisks2, gvfs
> +# would be MACHINE_ARCH as well
> +SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
> +  libblockdev->ndctl \
> +"
>  # ttf.inc inherits fontcache which adds fontconfig-utils to RDEPENDS
>  SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
>    terminus-font->fontconfig \
> diff --git a/meta-oe/recipes-core/ndctl/ndctl_v63.bb b/meta-oe/recipes-core/ndctl/ndctl_v63.bb
> index 1f3abf5..61e5302 100644
> --- a/meta-oe/recipes-core/ndctl/ndctl_v63.bb
> +++ b/meta-oe/recipes-core/ndctl/ndctl_v63.bb
> @@ -19,6 +19,9 @@ S = "${WORKDIR}/git"
>  
>  EXTRA_OECONF += "--enable-test --enable-destructive --disable-docs"
>  
> +# Depends on MACHINE_ARCH kernel
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
>...

This looks like another case where the actual problem is an unnecessary 
DEPENDS on virtual/kernel, and the proper fix is to remove that instead.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed