From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yrjan Skrimstad Subject: Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking Date: Sun, 16 Jun 2019 16:43:10 +0200 Message-ID: <20190616144309.GA8174@obi-wan> References: <20190530000819.GA25416@obi-wan> <20190604202149.GA20116@obi-wan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher Cc: David Airlie , LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , Evan Quan , Rex Zhu , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: amd-gfx.lists.freedesktop.org T24gVGh1LCBKdW4gMTMsIDIwMTkgYXQgMDk6NTc6MjRBTSAtMDQwMCwgQWxleCBEZXVjaGVyIHdy b3RlOgo+IFRoZSBwYXRjaCBpcyBmaW5lIGFuZCBJIGNhbiBhcHBseSBpdCAoSSBkb24ndCB0aGlu ayB0aGVyZSBhcmUgYW55Cj4gcmVzdHJpY3Rpb25zIG9uIHNsZWVwaW5nIGluIHN5c2ZzKSwgYnV0 IHRoaXMgY29kZSBvbmx5IGdldHMgZXhlY3V0ZWQKPiB3aGVuIHlvdSBhY3R1YWxseSByZWFkIHRo ZSBwb3dlciBzdGF0dXMgZnJvbSB0aGUgY2FyZCAoZS5nLiwgdmlhIHN5c2ZzCj4gb3IgZGVidWdm cykuICBQcmVzdW1hYmx5IHlvdSBoYXZlIHNvbWV0aGluZyBpbiB1c2Vyc3BhY2UgcG9sbGluZyBv bmUKPiBvZiB0aG9zZSBmaWxlcyBvbiBhIHJlZ3VsYXIgYmFzaXM/Cj4gCj4gQWxleAoKVGhhdCBp cyBhbiBpbnRlcmVzdGluZyBvYnNlcnZhdGlvbiB0byBtZS4gSSBhbSBhY3R1YWxseSBydW5uaW5n CmxtLXNlbnNvcnMsIGFsdGhvdWdoIG9ubHkgZXZlcnkgMTUgc2Vjb25kcy4gSSBzdXBwb3NlIHRo YXQgdGhpcyBtaWdodApiZSB0aGUgcmVhc29uIHRoaXMgaGFwcGVucyB0byBtZS4KCi0gWXJqYW4K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9C88C31E50 for ; Sun, 16 Jun 2019 14:43:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCE2F216FD for ; Sun, 16 Jun 2019 14:43:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727251AbfFPOnR (ORCPT ); Sun, 16 Jun 2019 10:43:17 -0400 Received: from mail.skrimstad.net ([139.162.145.221]:57472 "EHLO mail.skrimstad.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbfFPOnR (ORCPT ); Sun, 16 Jun 2019 10:43:17 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by mail.skrimstad.net (Postfix) with ESMTPA id 9B3DEDE093; Sun, 16 Jun 2019 14:43:12 +0000 (UTC) Date: Sun, 16 Jun 2019 16:43:10 +0200 From: Yrjan Skrimstad To: Alex Deucher Cc: Maling list - DRI developers , David Airlie , LKML , amd-gfx list , Alex Deucher , Evan Quan , Rex Zhu , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking Message-ID: <20190616144309.GA8174@obi-wan> References: <20190530000819.GA25416@obi-wan> <20190604202149.GA20116@obi-wan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: mail.skrimstad.net; auth=pass smtp.auth=yrjan@skrimstad.net smtp.mailfrom=yrjan@skrimstad.net X-Spamd-Bar: / Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 13, 2019 at 09:57:24AM -0400, Alex Deucher wrote: > The patch is fine and I can apply it (I don't think there are any > restrictions on sleeping in sysfs), but this code only gets executed > when you actually read the power status from the card (e.g., via sysfs > or debugfs). Presumably you have something in userspace polling one > of those files on a regular basis? > > Alex That is an interesting observation to me. I am actually running lm-sensors, although only every 15 seconds. I suppose that this might be the reason this happens to me. - Yrjan