All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Robert Hancock <hancock@sedsystems.ca>
Cc: linux-iio@vger.kernel.org, ardeleanalex@gmail.com,
	michal.simek@xilinx.com, knaack.h@gmx.de, pmeerw@pmeerw.net,
	lars@metafoo.de
Subject: Re: [PATCH] iio: adc: xilinx: support all platforms
Date: Sun, 16 Jun 2019 16:20:21 +0100	[thread overview]
Message-ID: <20190616162021.49e60796@archlinux> (raw)
In-Reply-To: <1560183824-19061-1-git-send-email-hancock@sedsystems.ca>

On Mon, 10 Jun 2019 10:23:44 -0600
Robert Hancock <hancock@sedsystems.ca> wrote:

> Since the XADC logic can be used with standalone Xilinx FPGAs, this
> driver can potentially be used with many different platforms, not just
> the Zynq and MicroBlaze platforms this driver was allowed to be built
> for. There should be no platform-specific code in this driver, so just
> delete the platform dependency.
> 
> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
Applied to the togreg branch of iio.git and pushed out as testing
to see if any of us missed anything.  Hopefully the many compiles 0-day
will do on this will highlight if there is anything hiding we haven't thought
of to make this a bad idea (more likely needing a little fix ;)

Jonathan

> ---
> 
> This is an updated version of an earlier patch "iio: adc: xilinx: support all
> ARM platforms", but this one just deletes the platform restriction entirely
> as it seems unnecessary.
> 
>  drivers/iio/adc/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index f96a770..7e32862 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -1085,7 +1085,6 @@ config VIPERBOARD_ADC
>  
>  config XILINX_XADC
>  	tristate "Xilinx XADC driver"
> -	depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST
>  	depends on HAS_IOMEM
>  	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER


      parent reply	other threads:[~2019-06-16 15:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10 16:23 [PATCH] iio: adc: xilinx: support all platforms Robert Hancock
2019-06-11  6:28 ` Ardelean, Alexandru
2019-06-11  6:52   ` Lars-Peter Clausen
2019-06-11  6:57     ` Ardelean, Alexandru
2019-06-16 15:20 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190616162021.49e60796@archlinux \
    --to=jic23@kernel.org \
    --cc=ardeleanalex@gmail.com \
    --cc=hancock@sedsystems.ca \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.