From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2768CC31E53 for ; Mon, 17 Jun 2019 08:34:16 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08B1C2238D for ; Mon, 17 Jun 2019 08:34:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08B1C2238D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id B92E4C3E; Mon, 17 Jun 2019 08:34:15 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 7DFC7C3A for ; Mon, 17 Jun 2019 08:34:14 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 23531828 for ; Mon, 17 Jun 2019 08:34:14 +0000 (UTC) Received: by newverein.lst.de (Postfix, from userid 2407) id D530F68D0E; Mon, 17 Jun 2019 10:33:42 +0200 (CEST) Date: Mon, 17 Jun 2019 10:33:42 +0200 From: Christoph Hellwig To: Dan Carpenter Subject: Re: use exact allocation for dma coherent memory Message-ID: <20190617083342.GA7883@lst.de> References: <20190614134726.3827-1-hch@lst.de> <20190617082148.GF28859@kadam> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190617082148.GF28859@kadam> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Maxime Ripard , Joonas Lahtinen , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Christoph Hellwig , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, David Airlie , linux-media@vger.kernel.org, Intel Linux Wireless , intel-gfx@lists.freedesktop.org, Maarten Lankhorst , Jani Nikula , Ian Abbott , Rodrigo Vivi , Sean Paul , "moderated list:ARM PORT" , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, H Hartley Sweeten , iommu@lists.linux-foundation.org, Daniel Vetter X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org > drivers/infiniband/hw/cxgb4/qp.c > 129 static int alloc_host_sq(struct c4iw_rdev *rdev, struct t4_sq *sq) > 130 { > 131 sq->queue = dma_alloc_coherent(&(rdev->lldi.pdev->dev), sq->memsize, > 132 &(sq->dma_addr), GFP_KERNEL); > 133 if (!sq->queue) > 134 return -ENOMEM; > 135 sq->phys_addr = virt_to_phys(sq->queue); > 136 dma_unmap_addr_set(sq, mapping, sq->dma_addr); > 137 return 0; > 138 } > > Is this a bug? Yes. This will blow up badly on many platforms, as sq->queue might be vmapped, ioremapped, come from a pool without page backing. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: use exact allocation for dma coherent memory Date: Mon, 17 Jun 2019 10:33:42 +0200 Message-ID: <20190617083342.GA7883@lst.de> References: <20190614134726.3827-1-hch@lst.de> <20190617082148.GF28859@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190617082148.GF28859@kadam> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dan Carpenter Cc: Maxime Ripard , Joonas Lahtinen , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Christoph Hellwig , devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Airlie , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Intel Linux Wireless , intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Maarten Lankhorst , Jani Nikula , Ian Abbott , Rodrigo Vivi , Sean Paul , "moderated list:ARM PORT" , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, H Hartley Sweeten , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Daniel Vetter List-Id: linux-rdma@vger.kernel.org > drivers/infiniband/hw/cxgb4/qp.c > 129 static int alloc_host_sq(struct c4iw_rdev *rdev, struct t4_sq *sq) > 130 { > 131 sq->queue = dma_alloc_coherent(&(rdev->lldi.pdev->dev), sq->memsize, > 132 &(sq->dma_addr), GFP_KERNEL); > 133 if (!sq->queue) > 134 return -ENOMEM; > 135 sq->phys_addr = virt_to_phys(sq->queue); > 136 dma_unmap_addr_set(sq, mapping, sq->dma_addr); > 137 return 0; > 138 } > > Is this a bug? Yes. This will blow up badly on many platforms, as sq->queue might be vmapped, ioremapped, come from a pool without page backing. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:34287 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725837AbfFQIeO (ORCPT ); Mon, 17 Jun 2019 04:34:14 -0400 Date: Mon, 17 Jun 2019 10:33:42 +0200 From: Christoph Hellwig Subject: Re: use exact allocation for dma coherent memory Message-ID: <20190617083342.GA7883@lst.de> References: <20190614134726.3827-1-hch@lst.de> <20190617082148.GF28859@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190617082148.GF28859@kadam> Sender: linux-s390-owner@vger.kernel.org List-ID: To: Dan Carpenter Cc: Christoph Hellwig , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Ian Abbott , H Hartley Sweeten , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, Intel Linux Wireless , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, "moderated list:ARM PORT" , linux-media@vger.kernel.org > drivers/infiniband/hw/cxgb4/qp.c > 129 static int alloc_host_sq(struct c4iw_rdev *rdev, struct t4_sq *sq) > 130 { > 131 sq->queue = dma_alloc_coherent(&(rdev->lldi.pdev->dev), sq->memsize, > 132 &(sq->dma_addr), GFP_KERNEL); > 133 if (!sq->queue) > 134 return -ENOMEM; > 135 sq->phys_addr = virt_to_phys(sq->queue); > 136 dma_unmap_addr_set(sq, mapping, sq->dma_addr); > 137 return 0; > 138 } > > Is this a bug? Yes. This will blow up badly on many platforms, as sq->queue might be vmapped, ioremapped, come from a pool without page backing. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C4CEC31E44 for ; Mon, 17 Jun 2019 08:34:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D61652238D for ; Mon, 17 Jun 2019 08:34:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WGRJy7vK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D61652238D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7keYmjtY37CcT3AHRi0hgtako+mhBcWv66B2F63WcXs=; b=WGRJy7vK2A2V4a oLWYCbPhr49kgXjyg71MzK1wC198+2uxE4k9TFPTa7myohgqK+DKvfDYpQNtrbgZl+te3NN/k7Uta rmKa5qW+DgtdgARbBbjoyRbwd9PmVPvDPEMlzTscDdcs+b0J1eBeGesYMseCH8nUd5OwT4GtY3V2b yvhy4sniLOTGA1I4/CegsskQw3wxoIDXCPnXrq6gTVvhdgXGPbK8qp/NfDxozaKm2G3aOneLG33WY OHe4hNHSY0yD8cQWJSkxA71agjj/0SNe8H86BcSg+alFk8a/Vue9r/G8IxBTeoFWSY7OT/aJAeQzy cqRUBFp706R7mAJCQPWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcn5q-0002Fz-Dh; Mon, 17 Jun 2019 08:34:22 +0000 Received: from verein.lst.de ([213.95.11.211] helo=newverein.lst.de) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcn5n-0002Ec-3l for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2019 08:34:20 +0000 Received: by newverein.lst.de (Postfix, from userid 2407) id D530F68D0E; Mon, 17 Jun 2019 10:33:42 +0200 (CEST) Date: Mon, 17 Jun 2019 10:33:42 +0200 From: Christoph Hellwig To: Dan Carpenter Subject: Re: use exact allocation for dma coherent memory Message-ID: <20190617083342.GA7883@lst.de> References: <20190614134726.3827-1-hch@lst.de> <20190617082148.GF28859@kadam> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190617082148.GF28859@kadam> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_013419_303457_EA5B5171 X-CRM114-Status: UNSURE ( 7.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Joonas Lahtinen , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Christoph Hellwig , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, David Airlie , linux-media@vger.kernel.org, Intel Linux Wireless , intel-gfx@lists.freedesktop.org, Maarten Lankhorst , Jani Nikula , Ian Abbott , Rodrigo Vivi , Sean Paul , "moderated list:ARM PORT" , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, H Hartley Sweeten , iommu@lists.linux-foundation.org, Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > drivers/infiniband/hw/cxgb4/qp.c > 129 static int alloc_host_sq(struct c4iw_rdev *rdev, struct t4_sq *sq) > 130 { > 131 sq->queue = dma_alloc_coherent(&(rdev->lldi.pdev->dev), sq->memsize, > 132 &(sq->dma_addr), GFP_KERNEL); > 133 if (!sq->queue) > 134 return -ENOMEM; > 135 sq->phys_addr = virt_to_phys(sq->queue); > 136 dma_unmap_addr_set(sq, mapping, sq->dma_addr); > 137 return 0; > 138 } > > Is this a bug? Yes. This will blow up badly on many platforms, as sq->queue might be vmapped, ioremapped, come from a pool without page backing. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel