From: Tiwei Bie <tiwei.bie@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
Zhihong Wang <zhihong.wang@intel.com>,
dev@dpdk.org, Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/virtio: add Tx preparation
Date: Mon, 17 Jun 2019 16:52:45 +0800 [thread overview]
Message-ID: <20190617085245.GB17273@___> (raw)
In-Reply-To: <1560680229-8166-1-git-send-email-arybchenko@solarflare.com>
On Sun, Jun 16, 2019 at 11:17:08AM +0100, Andrew Rybchenko wrote:
> From: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
>
> Virtio requires pseudo-header checksum in TCP/UDP checksum to do
> offload, but it was lost when Tx prepare is introduced. Also
> rte_validate_tx_offload() should be used to validate Tx offloads.
>
> Also it is incorrect to do virtio_tso_fix_cksum() after prepend
> to mbuf without taking prepended size into account, since layer 2/3/4
> lengths provide incorrect offsets after prepend.
>
> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Thanks,
Tiwei
next prev parent reply other threads:[~2019-06-17 8:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 18:50 [dpdk-dev] [PATCH v2] net/virtio: add Tx preparation Andrew Rybchenko
2019-06-05 1:41 ` Tiwei Bie
2019-06-05 7:28 ` Andrew Rybchenko
2019-06-05 9:37 ` Tiwei Bie
2019-06-16 10:17 ` [dpdk-dev] [PATCH v3 1/2] " Andrew Rybchenko
2019-06-16 10:17 ` [dpdk-dev] [PATCH v3 2/2] net/virtio: move VLAN tag insertion to Tx prepare Andrew Rybchenko
2019-06-17 8:54 ` Tiwei Bie
2019-06-17 11:35 ` Andrew Rybchenko
2019-06-17 8:52 ` Tiwei Bie [this message]
2019-06-17 11:31 ` [dpdk-dev] [PATCH v4 1/2] net/virtio: add Tx preparation Andrew Rybchenko
2019-06-17 11:31 ` [dpdk-dev] [PATCH v4 2/2] net/virtio: move VLAN tag insertion to Tx prepare Andrew Rybchenko
2019-06-18 4:42 ` Tiwei Bie
2019-06-20 9:58 ` Maxime Coquelin
2019-06-20 9:58 ` [dpdk-dev] [PATCH v4 1/2] net/virtio: add Tx preparation Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617085245.GB17273@___ \
--to=tiwei.bie@intel.com \
--cc=Dilshod.Urazov@oktetlabs.ru \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.