From: Mark Brown <broonie@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: tony@atomide.com, lgirdwood@gmail.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, sboyd@kernel.org, nm@ti.com,
vireshk@kernel.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH] regulator: twl: mark vdd1/2 as continuous on twl4030
Date: Mon, 17 Jun 2019 11:31:11 +0100 [thread overview]
Message-ID: <20190617103111.GM5316@sirena.org.uk> (raw)
In-Reply-To: <20190615163314.28173-1-andreas@kemnade.info>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Sat, Jun 15, 2019 at 06:33:14PM +0200, Andreas Kemnade wrote:
> The VDD1/VDD2 regulators on twl4030 are neither defined with
> voltage lists nor with the continuous flag set, so
> regulator_is_supported_voltage() returns false and an error
> before above mentioned commit (which was considered success)
> The result is that after the above mentioned commit cpufreq
> does not work properly e.g. dm3730.
Why is this a good fix and not defining the supported voltages? These
look like fairly standard linear range regulators.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-17 10:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-15 16:33 [PATCH] regulator: twl: mark vdd1/2 as continuous on twl4030 Andreas Kemnade
2019-06-17 10:31 ` Mark Brown [this message]
2019-06-17 11:03 ` Andreas Kemnade
2019-06-17 11:40 ` Mark Brown
2019-06-17 16:27 ` Andreas Kemnade
2019-06-17 17:02 ` Mark Brown
2019-06-17 17:21 ` Andreas Kemnade
2019-06-17 16:32 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617103111.GM5316@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andreas@kemnade.info \
--cc=letux-kernel@openphoenux.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.