From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3 Date: Mon, 17 Jun 2019 18:36:34 +0200 Message-ID: <20190617163634.GA16941@kozik-lap> References: <20190614203144.3850-2-joseph.kogut@gmail.com> <20190614235719.8134-1-joseph.kogut@gmail.com> <20190616085928.GB3826@kozik-lap> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joseph Kogut Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, kgene@kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org T24gTW9uLCBKdW4gMTcsIDIwMTkgYXQgMDk6MTU6MjNBTSAtMDcwMCwgSm9zZXBoIEtvZ3V0IHdy b3RlOgo+IEhpIEtyenlzenRvZiwKPiAKPiBUaGFua3MgZm9yIHRoZSByZXZpZXcuCj4gCj4gT24g U3VuLCBKdW4gMTYsIDIwMTkgYXQgMTo1OSBBTSBLcnp5c3p0b2YgS296bG93c2tpIDxrcnprQGtl cm5lbC5vcmc+IHdyb3RlOgo+ID4KPiA+IE9uIEZyaSwgSnVuIDE0LCAyMDE5IGF0IDA0OjU3OjE5 UE0gLTA3MDAsIEpvc2VwaCBLb2d1dCB3cm90ZToKPiA+ID4gQWRkIGRldmljZSB0cmVlIG5vZGUg Zm9yIG1hbGkgZ3B1IG9uIE9kcm9pZCBYVTMgU29Dcy4KPiA+ID4KPiA+ID4gU2lnbmVkLW9mZi1i eTogSm9zZXBoIEtvZ3V0IDxqb3NlcGgua29ndXRAZ21haWwuY29tPgo+ID4gPiAtLS0KPiA+ID4K PiA+ID4gQ2hhbmdlcyB2MSAtPiB2MjoKPiA+ID4gLSBVc2UgaW50ZXJydXB0IG5hbWUgb3JkZXJp bmcgZnJvbSBiaW5kaW5nIGRvYwo+ID4gPiAtIFNwZWNpZnkgYSBzaW5nbGUgY2xvY2sgZm9yIEdQ VSBub2RlCj4gPiA+IC0gQWRkIGdwdSBvcHAgdGFibGUKPiA+ID4gLSBGaXggd2FybmluZ3MgZnJv bSBJUlFfVFlQRV9OT05FCj4gPiA+Cj4gPiA+ICAuLi4vYm9vdC9kdHMvZXh5bm9zNTQyMi1vZHJv aWR4dTMtY29tbW9uLmR0c2kgfCAyNiArKysrKysrKysrKysrKysrKysrCj4gPgo+ID4gVGhpcyBz aG91bGQgZ28gdG8gZXh5bm9zNTQyMi1vZHJvaWQtY29yZS5kdHNpIGluc3RlYWQsIGJlY2F1c2Ug aXQgaXMKPiA+IGNvbW1vbiB0byBlbnRpcmUgT2Ryb2lkIEV4eW5vczU0MjIgZmFtaWx5IChub3Qg b25seSBYVTMgZmFtaWx5KS4KPiA+Cj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9u cygrKQo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvZXh5bm9zNTQy Mi1vZHJvaWR4dTMtY29tbW9uLmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9leHlub3M1NDIyLW9k cm9pZHh1My1jb21tb24uZHRzaQo+ID4gPiBpbmRleCA5M2E0OGYyZGRhNDkuLmI4YTQyNDZlM2Iz NyAxMDA2NDQKPiA+ID4gLS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMvZXh5bm9zNTQyMi1vZHJvaWR4 dTMtY29tbW9uLmR0c2kKPiA+ID4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvZXh5bm9zNTQyMi1v ZHJvaWR4dTMtY29tbW9uLmR0c2kKPiA+ID4gQEAgLTQ4LDYgKzQ4LDMyIEBACj4gPiA+ICAgICAg ICAgICAgICAgY29vbGluZy1sZXZlbHMgPSA8MCAxMzAgMTcwIDIzMD47Cj4gPiA+ICAgICAgIH07 Cj4gPiA+Cj4gPiA+ICsgICAgIGdwdTogZ3B1QDExODAwMDAwIHsKPiA+ID4gKyAgICAgICAgICAg ICBjb21wYXRpYmxlID0gInNhbXN1bmcsZXh5bm9zLW1hbGkiLCAiYXJtLG1hbGktdDYyOCI7Cj4g Pgo+ID4gVGhpcyBpcyBjb21tb24gdG8gYWxsIEV4eW5vczU0MnggY2hpcHMgc28gaXQgc2hvdWxk IGdvIHRvCj4gPiBleHlub3M1NDIwLmR0c2kuIEhlcmUgeW91IHdvdWxkIG5lZWQgdG8gb25seSBl bmFibGUgaXQgYW5kIHByb3ZpZGUKPiA+IHJlZ3VsYXRvci4KPiA+Cj4gCj4gVG8gY2xhcmlmeSwg d2hpY2ggcGllY2VzIGFyZSBzcGVjaWZpYyB0byB0aGUgT2Ryb2lkIEV4eW5vcyA1NDIyCj4gZmFt aWx5LCBhbmQgd2hpY2ggYXJlIGNvbW1vbiB0byB0aGUgZW50aXJlIEV4eW5vcyA1NDJ4IGZhbWls eT8gSSdtCj4gdGhpbmtpbmcgdGhlIGdwdSBub2RlIGlzIGNvbW1vbiB0byB0aGUgNTQyeCBmYW1p bHksIGluY2x1ZGluZyB0aGUKPiBpbnRlcnJ1cHRzIGFuZCBjbG9jaywgYW5kIHRoZSByZWd1bGF0 b3IgYW5kIG9wcCB0YWJsZSBhcmUgc3BlY2lmaWMgdG8KPiB0aGUgT2Ryb2lkIDU0MjI/CgpPcHAg dGFibGUgZGVwZW5kcyAtIGl0IG1pZ2h0IGNvbW1vbiB0byBFeHlub3M1NDJ4IChhcyBhbGwgdXNl IHRoZSBzYW1lCk1hbGkpIG9yIHNwZWNpZmljIHRvIGJvYXJkcyAoYmVjYXVzZSB0aGVyZSBpcyBP ZHJvaWQgWFUzIExpdGUgd2l0aApFeHlub3M1NDIyIHdvcmtpbmcgb24gbG93ZXIgZnJlcXVlbmNp ZXMpLgoKU28gZmFyIHRoZSBDUFUgYW5kIGFsbCBidXMgT1BQIHRhYmxlcyB3ZXJlIHB1dCBpbiBl eHlub3M1NDIwLmR0c2kgc28gSQpndWVzcyB0aGlzIGNhbiBnbyB0aGVyZSBhcyB3ZWxsLgoKRm9y IHRoZSByZXN0IG9mIHByb3BlcnRpZXMgeW91IHdlcmUgY29ycmVjdC4KCj4gCj4gPiBQcm9iYWJs eSB0aGlzIHNob3VsZCBiZSBhbHNvIGFzc29jaWF0ZWQgd2l0aCB0bXVfZ3B1IGFzIGEgY29vbGlu ZyBkZXZpY2UKPiA+IChpZiBNYWxpIHJlZ2lzdGVycyBhIGNvb2xpbmcgZGV2aWNlLi4uKS4gT3Ro ZXJ3aXNlIHRoZSB0bXVfZ3B1IGlzIG5vdAo+ID4gcmVhbGx5IHVzZWQgZm9yIGl0Lgo+ID4KPiAK PiBXZSBoYXZlIHR3byBvcGVyYXRpbmcgcGVyZm9ybWFuY2UgcG9pbnRzIGZvciB0aGUgR1BVLCBi dXQgSSdtIG5vdCBzdXJlCj4gYXQgd2hhdCB0ZW1wZXJhdHVyZSB3ZSBzaG91bGQgdHJpcCB0aGUg bG93ZXIgb3BwLiBMb29raW5nIGF0IHRoZSB0cmlwCj4gdGVtcGVyYXR1cmVzIGZvciB0aGUgQ1BV LCB3ZSBoYXZlIGZvdXIgYWxlcnRzLCBhbmQgb25lIGNyaXRpY2FsIHRyaXAuCj4gVGhlIGhpZ2hl c3QgYWxlcnQgaXMgODUgQywgd291bGQgaXQgYmUgcmVhc29uYWJsZSB0byB0cmlnZ2VyIHRoZSBs b3dlcgo+IEdQVSBvcHAgYXQgdGhpcyB0ZW1wZXJhdHVyZT8gU2hvdWxkIGl0IHRyaWdnZXIgc29v bmVyPwoKVGhlIGhpZ2hlc3QgdHJpcCBwb2ludCBpcyAxMjAgQyBhbmQgaXQgaXMgY3JpdGljYWwu IEluIGdlbmVyYWwgSSB3b3VsZApmb2xsb3cgdGhlIENQVSB0cmlwIHBvaW50cyAoc28gZmFuIHNo b3VsZCBzdGFydCB3b3JraW5nIGF0IDUwIGRlZ3JlZXMpLgpVbmxlc3MgeW91IGhhdmUgc29tZSBv dGhlciBkYXRhIGFib3V0IHJlY29tbWVuZGVkIHRyaXAgcG9pbnRzLiBVc2VmdWwgaXMKdmVuZG9y IGtlcm5lbCAoZnJvbSBTYW1zdW5nLCBmcm9tIEhhcmQgS2VybmVsKS4KCj4gCj4gPiA+ICsgICAg ICAgICAgICAgcmVnID0gPDB4MTE4MDAwMDAgMHg1MDAwPjsKPiA+ID4gKyAgICAgICAgICAgICBp bnRlcnJ1cHRzID0gPEdJQ19TUEkgMjE5IElSUV9UWVBFX0xFVkVMX0hJR0g+LAo+ID4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICA8R0lDX1NQSSA3NCAgSVJRX1RZUEVfTEVWRUxfSElHSD4s Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIDxHSUNfU1BJIDExNyBJUlFfVFlQRV9M RVZFTF9ISUdIPjsKPiA+ID4gKyAgICAgICAgICAgICBpbnRlcnJ1cHQtbmFtZXMgPSAiam9iIiwg Im1tdSIsICJncHUiOwo+ID4gPiArICAgICAgICAgICAgIGNsb2NrcyA9IDwmY2xvY2sgQ0xLX0cz RD47Cj4gPiA+ICsgICAgICAgICAgICAgbWFsaS1zdXBwbHkgPSA8JmJ1Y2s0X3JlZz47Cj4gPgo+ ID4gUGxlYXNlIGNoZWNrIGlmIGFsd2F5cy1vbiBwcm9wZXJ0eSBjb3VsZCBiZSByZW1vdmVkIGZy b20gYnVjazQuCj4gCj4gSSd2ZSBjaGVja2VkLCBhbmQgdGhpcyBwcm9wZXJ0eSBjYW4gYmUgcmVt b3ZlZCBzYWZlbHkuCj4gCj4gPiBBbHNvLCB3aGF0IGFib3V0IExETzI3PyBJdCBzaG91bGQgYmUg dXNlZCBhcyB3ZWxsIChtYXliZSB0aHJvdWdoCj4gPiB2ZW5kb3Itc3BlY2lmaWMgcHJvcGVydGll cyB3aGljaCB3b3VsZCBqdXN0aWZ5IHRoZSBuZWVkIG9mIG5ldyB2ZW5kb3IKPiA+IGNvbXBhdGli bGUpLgo+ID4KPiAKPiBJJ20gdW5zdXJlIGhvdyBMRE8yNyBpcyB1c2VkLCBjYW4geW91IGVsYWJv cmF0ZT8KCkl0IGlzIHN1cHBseWluZyB0aGUgVkREX0czRFMgKHdpdGggYSBub3RlICJTUkFNIHBv d2VyIikuIEkgZG8gbm90IGhhdmUKYW55IG1vcmUgZGF0YSBvbiBpdC4gSG93ZXZlciBJIGRpZCBu b3QgY2hlY2sgaW4gdmVuZG9yIGtlcm5lbCBmb3IgaXQuCgpCZXN0IHJlZ2FyZHMsCktyenlzenRv ZgoKCj4gCj4gQmVzdCwKPiBKb3NlcGgKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFC07C31E5B for ; Mon, 17 Jun 2019 16:36:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B646220644 for ; Mon, 17 Jun 2019 16:36:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gFpf8nMt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B646220644 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aIzmufBuwMT6fSVA2yEwMVVqKifvlxSoGhpsn4O4NQk=; b=gFpf8nMtbsMydQ IQQ8iDyenKpy6r92dYQm3QMqr5PWE34iKhC+JJ0Md4SR9LRrpKua3wzIpaiCcek67p+mPeievuAdY HIdegwJpwawAhlfhkXeWSh5r36Rgwcgu0+6Lz5ppJrviOQmAMjTAMr1Rf4a3dKQC5A3WHgbkYRax/ y6ptbE3tBB46E3SK8sNHKDYMA6KePXo4+OwYb/1EhwM1A07f5FYiRqfoh21h9nq0/Us5xSZpnroEL Vx+1EeDVNoPsk0hU/iEgTsjHN9iR8ogc3XEqmMgkjDYWWxO5GzaEyQ6tM3LuMiCaJFlJq30bVwmRD f82jJ5RmAslbxhVi2q0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcucp-0008C6-6Z; Mon, 17 Jun 2019 16:36:55 +0000 Received: from mail-wr1-f68.google.com ([209.85.221.68]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcuca-0007y3-Bc for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2019 16:36:41 +0000 Received: by mail-wr1-f68.google.com with SMTP id n4so2622633wrs.3 for ; Mon, 17 Jun 2019 09:36:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8Oy70J7E+pU3L/OYvURWRN5oF2aMwufMYC8uJSROz60=; b=DlaA52o9nHISWq1cj3FDQhAADTE120lO9hhtHA5wyDO5Yk/lF2wF7OMk9B/N51XOP7 SlbR5eK8qbhHVEbZ6oL9q0aPxlOU9IbneZXKr97OVy4yZb1mXsu34p82SCddfYUJ/Zgg L57iU6atBaRfeJs8X46+w1Y1j9V9L38vtjMV5U3rkIBkO4SXUAvagOEDYFjsjBwPg5fO OdTwb0e8o4QZ5MQmXIpcNJ/DhD6buHtkYNfMn0NinP0/qrM5b0EjxOEB9cb05NuZJYIs zoFoCFSH8wp90LcPYGR6bFwnRkJGRimwWQ5sUHRa41eU2A/bRdoyySAjdTfLt1P7gT0w 757w== X-Gm-Message-State: APjAAAXgYmHDK9u5bFbkeWxGc8mI9W3CmSBcTcOmXfmuWIwmzoiCLFCr wRoNjm1Lrb0Rkbx/MYFIzDI= X-Google-Smtp-Source: APXvYqydGfrS7r/3YJw8wv4J3mDqQdGECHHJ0dsY/h1rw5+NOYNtFdSPKiuX989ub5GjygD6pPlUhg== X-Received: by 2002:adf:e3cc:: with SMTP id k12mr20423649wrm.159.1560789397834; Mon, 17 Jun 2019 09:36:37 -0700 (PDT) Received: from kozik-lap ([194.230.155.186]) by smtp.googlemail.com with ESMTPSA id e11sm12061602wrc.9.2019.06.17.09.36.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Jun 2019 09:36:37 -0700 (PDT) Date: Mon, 17 Jun 2019 18:36:34 +0200 From: Krzysztof Kozlowski To: Joseph Kogut Subject: Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3 Message-ID: <20190617163634.GA16941@kozik-lap> References: <20190614203144.3850-2-joseph.kogut@gmail.com> <20190614235719.8134-1-joseph.kogut@gmail.com> <20190616085928.GB3826@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_093640_410320_2F94CAC2 X-CRM114-Status: GOOD ( 30.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, kgene@kernel.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 17, 2019 at 09:15:23AM -0700, Joseph Kogut wrote: > Hi Krzysztof, > > Thanks for the review. > > On Sun, Jun 16, 2019 at 1:59 AM Krzysztof Kozlowski wrote: > > > > On Fri, Jun 14, 2019 at 04:57:19PM -0700, Joseph Kogut wrote: > > > Add device tree node for mali gpu on Odroid XU3 SoCs. > > > > > > Signed-off-by: Joseph Kogut > > > --- > > > > > > Changes v1 -> v2: > > > - Use interrupt name ordering from binding doc > > > - Specify a single clock for GPU node > > > - Add gpu opp table > > > - Fix warnings from IRQ_TYPE_NONE > > > > > > .../boot/dts/exynos5422-odroidxu3-common.dtsi | 26 +++++++++++++++++++ > > > > This should go to exynos5422-odroid-core.dtsi instead, because it is > > common to entire Odroid Exynos5422 family (not only XU3 family). > > > > > 1 file changed, 26 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > > index 93a48f2dda49..b8a4246e3b37 100644 > > > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > > @@ -48,6 +48,32 @@ > > > cooling-levels = <0 130 170 230>; > > > }; > > > > > > + gpu: gpu@11800000 { > > > + compatible = "samsung,exynos-mali", "arm,mali-t628"; > > > > This is common to all Exynos542x chips so it should go to > > exynos5420.dtsi. Here you would need to only enable it and provide > > regulator. > > > > To clarify, which pieces are specific to the Odroid Exynos 5422 > family, and which are common to the entire Exynos 542x family? I'm > thinking the gpu node is common to the 542x family, including the > interrupts and clock, and the regulator and opp table are specific to > the Odroid 5422? Opp table depends - it might common to Exynos542x (as all use the same Mali) or specific to boards (because there is Odroid XU3 Lite with Exynos5422 working on lower frequencies). So far the CPU and all bus OPP tables were put in exynos5420.dtsi so I guess this can go there as well. For the rest of properties you were correct. > > > Probably this should be also associated with tmu_gpu as a cooling device > > (if Mali registers a cooling device...). Otherwise the tmu_gpu is not > > really used for it. > > > > We have two operating performance points for the GPU, but I'm not sure > at what temperature we should trip the lower opp. Looking at the trip > temperatures for the CPU, we have four alerts, and one critical trip. > The highest alert is 85 C, would it be reasonable to trigger the lower > GPU opp at this temperature? Should it trigger sooner? The highest trip point is 120 C and it is critical. In general I would follow the CPU trip points (so fan should start working at 50 degrees). Unless you have some other data about recommended trip points. Useful is vendor kernel (from Samsung, from Hard Kernel). > > > > + reg = <0x11800000 0x5000>; > > > + interrupts = , > > > + , > > > + ; > > > + interrupt-names = "job", "mmu", "gpu"; > > > + clocks = <&clock CLK_G3D>; > > > + mali-supply = <&buck4_reg>; > > > > Please check if always-on property could be removed from buck4. > > I've checked, and this property can be removed safely. > > > Also, what about LDO27? It should be used as well (maybe through > > vendor-specific properties which would justify the need of new vendor > > compatible). > > > > I'm unsure how LDO27 is used, can you elaborate? It is supplying the VDD_G3DS (with a note "SRAM power"). I do not have any more data on it. However I did not check in vendor kernel for it. Best regards, Krzysztof > > Best, > Joseph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel