Re: [PATCH] Fix sysfs_notify and kobject_uevent in fan_alarm_notify

[Guenter Roeck <linux@roeck-us.net>]

On Mon, Jun 17, 2019 at 11:33:43AM +0200, cschneider@radiodata.biz wrote:
> From: Christian Schneider <christian@ch-sc.de>
> 
> sysfs_notify and kobject_uevent are passed the wrong kobject.
> that why notifications can't be received and uevents have the wrong path.
> this patch fixes this.
> 
> Signed-off-by: Christian Schneider <cschneider@radiodata.biz>

Applied.

In the future, please version your patches, add a change log,
and reflect the subsystem and driver in the subject line.

Thanks,
Guenter

> ---
>  drivers/hwmon/gpio-fan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c
> index 84753680a4e8..76377791ff0e 100644
> --- a/drivers/hwmon/gpio-fan.c
> +++ b/drivers/hwmon/gpio-fan.c
> @@ -54,8 +54,8 @@ static void fan_alarm_notify(struct work_struct *ws)
>  	struct gpio_fan_data *fan_data =
>  		container_of(ws, struct gpio_fan_data, alarm_work);
>  
> -	sysfs_notify(&fan_data->dev->kobj, NULL, "fan1_alarm");
> -	kobject_uevent(&fan_data->dev->kobj, KOBJ_CHANGE);
> +	sysfs_notify(&fan_data->hwmon_dev->kobj, NULL, "fan1_alarm");
> +	kobject_uevent(&fan_data->hwmon_dev->kobj, KOBJ_CHANGE);
>  }
>  
>  static irqreturn_t fan_alarm_irq_handler(int irq, void *dev_id)