From: Stephen Suryaputra <ssuryaextr@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: Ido Schimmel <idosch@idosch.org>,
netdev@vger.kernel.org, nikolay@cumulusnetworks.com
Subject: Re: [PATCH net-next v3] ipv4: Support multipath hashing on inner IP pkts for GRE tunnel
Date: Mon, 17 Jun 2019 13:08:05 -0400 [thread overview]
Message-ID: <20190617170805.GA5736@ubuntu> (raw)
In-Reply-To: <e56ca29f-8d80-b9ae-112a-4ff55847313d@gmail.com>
On Mon, Jun 17, 2019 at 09:53:06AM -0600, David Ahern wrote:
> On 6/17/19 8:39 AM, Ido Schimmel wrote:
> >
> > Do you plan to add IPv6 support? Would be good to have the same features
> > in both stacks.
>
> we really should be mandating equal support for all new changes like this.
>
I will add that.
> >
> > Also, we have tests for these sysctls under
> > tools/testing/selftests/net/forwarding/router_multipath.sh
> >
> > Can you add a test for this change as well? You'll probably need to
> > create a new file given the topology created by router_multipath.sh does
> > not include tunnels.
I never looked at the selftests scripts, but will attempt.
Stephen.
prev parent reply other threads:[~2019-06-17 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 18:38 [PATCH net-next v3] ipv4: Support multipath hashing on inner IP pkts for GRE tunnel Stephen Suryaputra
2019-06-14 10:55 ` Nikolay Aleksandrov
2019-06-15 2:43 ` David Miller
2019-06-17 14:39 ` Ido Schimmel
2019-06-17 15:53 ` David Ahern
2019-06-17 17:08 ` Stephen Suryaputra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617170805.GA5736@ubuntu \
--to=ssuryaextr@gmail.com \
--cc=dsahern@gmail.com \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.