From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4955C31E5B for ; Mon, 17 Jun 2019 18:05:52 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A6BA208C0 for ; Mon, 17 Jun 2019 18:05:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A6BA208C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45SJzc4dfZzDqY4 for ; Tue, 18 Jun 2019 04:05:48 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=permerror (mailfrom) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45SJx84swHzDqPC for ; Tue, 18 Jun 2019 04:03:38 +1000 (AEST) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x5HI3QhV012161; Mon, 17 Jun 2019 13:03:26 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x5HI3PGf012160; Mon, 17 Jun 2019 13:03:25 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 17 Jun 2019 13:03:25 -0500 From: Segher Boessenkool To: Andreas Schwab Subject: Re: [PATCH] powerpc/32s: fix suspend/resume when IBATs 4-7 are used Message-ID: <20190617180325.GB7313@gate.crashing.org> References: <4291e0dd36aafff58bec429ac5355d10206c72d6.1560751738.git.christophe.leroy@c-s.fr> <87y32040h0.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y32040h0.fsf@igel.home> User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jun 17, 2019 at 06:53:47PM +0200, Andreas Schwab wrote: > AS arch/powerpc/kernel/swsusp_32.o > arch/powerpc/kernel/swsusp_32.S: Assembler messages: > arch/powerpc/kernel/swsusp_32.S:109: Error: invalid bat number > arch/powerpc/kernel/swsusp_32.S:111: Error: invalid bat number (etc.) It needs to be compiled for some specific machine, like -m750cl for example, not just -many. It probably should keep using mtspr, instead. Segher From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67140C31E5B for ; Mon, 17 Jun 2019 18:05:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 480BA208C0 for ; Mon, 17 Jun 2019 18:05:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727511AbfFQSDv (ORCPT ); Mon, 17 Jun 2019 14:03:51 -0400 Received: from gate.crashing.org ([63.228.1.57]:50407 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbfFQSDt (ORCPT ); Mon, 17 Jun 2019 14:03:49 -0400 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x5HI3QhV012161; Mon, 17 Jun 2019 13:03:26 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x5HI3PGf012160; Mon, 17 Jun 2019 13:03:25 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 17 Jun 2019 13:03:25 -0500 From: Segher Boessenkool To: Andreas Schwab Cc: Christophe Leroy , linuxppc-dev@lists.ozlabs.org, Paul Mackerras , linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/32s: fix suspend/resume when IBATs 4-7 are used Message-ID: <20190617180325.GB7313@gate.crashing.org> References: <4291e0dd36aafff58bec429ac5355d10206c72d6.1560751738.git.christophe.leroy@c-s.fr> <87y32040h0.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y32040h0.fsf@igel.home> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 17, 2019 at 06:53:47PM +0200, Andreas Schwab wrote: > AS arch/powerpc/kernel/swsusp_32.o > arch/powerpc/kernel/swsusp_32.S: Assembler messages: > arch/powerpc/kernel/swsusp_32.S:109: Error: invalid bat number > arch/powerpc/kernel/swsusp_32.S:111: Error: invalid bat number (etc.) It needs to be compiled for some specific machine, like -m750cl for example, not just -many. It probably should keep using mtspr, instead. Segher