From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Felipe Balbi <balbi@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
linux-usb@vger.kernel.org, Simon Horman <horms@verge.net.au>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v7 3/7] usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller
Date: Tue, 18 Jun 2019 08:47:43 +0200 [thread overview]
Message-ID: <20190618064743.GA22269@kroah.com> (raw)
In-Reply-To: <1559296800-5610-4-git-send-email-biju.das@bp.renesas.com>
On Fri, May 31, 2019 at 10:59:56AM +0100, Biju Das wrote:
> Driver for TI HD3SS3220 USB Type-C DRP port controller.
>
> The driver currently registers the port and supports data role swapping.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
I tried to apply this, but get the following build error:
drivers/usb/typec/hd3ss3220.c: In function hd3ss3220_probe:
drivers/usb/typec/hd3ss3220.c:179:23: error: implicit declaration of function fwnode_usb_role_switch_get; did you mean usb_role_switch_get? [-Werror=implicit-function-declaration]
hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector);
^~~~~~~~~~~~~~~~~~~~~~~~~~
usb_role_switch_get
drivers/usb/typec/hd3ss3220.c:179:21: warning: assignment to struct usb_role_switch * from int makes pointer from integer without a cast [-Wint-conversion]
hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector);
^
You might want to fix that so the series can be applied :(
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-18 6:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 9:59 [PATCH v7 0/7] Add USB3.0 and TI HD3SS3220 driver support Biju Das
2019-05-31 9:59 ` [PATCH v7 1/7] dt-bindings: usb: hd3ss3220 device tree binding document Biju Das
2019-06-11 21:55 ` Rob Herring
2019-05-31 9:59 ` [PATCH v7 2/7] dt-bindings: usb: renesas_usb3: Document usb role switch support Biju Das
2019-06-03 9:56 ` Yoshihiro Shimoda
2019-06-03 9:56 ` Yoshihiro Shimoda
2019-06-11 22:57 ` Rob Herring
2019-06-11 22:57 ` Rob Herring
2019-05-31 9:59 ` [PATCH v7 3/7] usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller Biju Das
2019-06-12 8:25 ` Heikki Krogerus
2019-06-12 8:42 ` Biju Das
2019-06-12 9:42 ` Heikki Krogerus
2019-06-18 6:47 ` Greg Kroah-Hartman [this message]
2019-06-18 6:57 ` Biju Das
2019-06-18 7:03 ` Greg Kroah-Hartman
2019-06-18 7:15 ` Biju Das
2019-05-31 9:59 ` [PATCH v7 4/7] usb: gadget: udc: renesas_usb3: Enhance role switch support Biju Das
2019-06-03 9:58 ` Yoshihiro Shimoda
2019-05-31 9:59 ` [PATCH v7 5/7] arm64: defconfig: enable TYPEC_HD3SS3220 config option Biju Das
2019-05-31 9:59 ` Biju Das
2019-06-12 11:59 ` Simon Horman
2019-06-12 11:59 ` Simon Horman
2019-05-31 9:59 ` [PATCH v7 6/7] arm64: dts: renesas: cat874: Enable USB3.0 host/peripheral device node Biju Das
2019-06-12 12:09 ` Simon Horman
2019-05-31 10:00 ` [PATCH v7 7/7] arm64: dts: renesas: cat874: Enable usb role switch support Biju Das
2019-06-12 12:09 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618064743.GA22269@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Chris.Paterson2@renesas.com \
--cc=balbi@kernel.org \
--cc=biju.das@bp.renesas.com \
--cc=chunfeng.yun@mediatek.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=heikki.krogerus@linux.intel.com \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.