From: Greg KH <gregkh@linuxfoundation.org>
To: dmg@turingmachine.org
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: Replace a < b ? a : b construct with min_t(type, a, b) in drivers/usb
Date: Tue, 18 Jun 2019 08:49:05 +0200 [thread overview]
Message-ID: <20190618064905.GA22457@kroah.com> (raw)
In-Reply-To: <20190617233050.21409-1-dmg@turingmachine.org>
On Mon, Jun 17, 2019 at 04:30:50PM -0700, dmg@turingmachine.org wrote:
> From: Daniel M German <dmg@turingmachine.org>
>
> Use min_t to find the minimum of two values instead of using the ?: operator.
Why is min_t() needed for all of these and not just min()?
>
> This change does not alter functionality. It is merely cosmetic intended to
> improve the readability of the code.
>
> Signed-off-by: Daniel M German <dmg@turingmachine.org>
> ---
> drivers/usb/gadget/function/u_ether.c | 2 +-
> drivers/usb/misc/adutux.c | 2 +-
> drivers/usb/storage/realtek_cr.c | 2 +-
Can you break this up into one patch per driver? That way you can
include the proper maintainers/reviewers when you resend them.
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-18 6:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 23:30 [PATCH] usb: Replace a < b ? a : b construct with min_t(type, a, b) in drivers/usb dmg
2019-06-18 6:49 ` Greg KH [this message]
2019-06-18 15:00 ` dmg
2019-06-18 15:26 ` Greg KH
2019-06-18 7:15 ` Felipe Balbi
2019-06-18 10:03 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618064905.GA22457@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dmg@turingmachine.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.