From: Tiwei Bie <tiwei.bie@intel.com>
To: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org
Cc: stable@dpdk.org
Subject: [dpdk-dev] [PATCH 3/4] net/virtio: fix memory leak in mergeable packed Rx
Date: Tue, 18 Jun 2019 15:41:58 +0800 [thread overview]
Message-ID: <20190618074159.3322-4-tiwei.bie@intel.com> (raw)
In-Reply-To: <20190618074159.3322-1-tiwei.bie@intel.com>
When there is no enough segments for a packet in mergeable
packed Rx path, we should free the whole mbuf chain instead
of just the last segment.
Fixes: a76290c8f1cf ("net/virtio: implement Rx path for packed queues")
Cc: stable@dpdk.org
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
drivers/net/virtio/virtio_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index 9cf422ffe..8b75291f5 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -1910,7 +1910,7 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,
} else {
PMD_RX_LOG(ERR,
"No enough segments for packet.");
- virtio_discard_rxbuf(vq, prev);
+ rte_pktmbuf_free(rx_pkts[nb_rx]);
rxvq->stats.errors++;
break;
}
--
2.17.1
next prev parent reply other threads:[~2019-06-18 7:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 7:41 [dpdk-dev] [PATCH 0/4] Some fixes for mergeable Rx Tiwei Bie
2019-06-18 7:41 ` [dpdk-dev] [PATCH 1/4] net/virtio: fix memory leak in in-order Rx Tiwei Bie
2019-06-19 12:34 ` Maxime Coquelin
2019-06-20 1:56 ` Tiwei Bie
2019-06-18 7:41 ` [dpdk-dev] [PATCH 2/4] net/virtio: fix memory leak in mergeable Rx Tiwei Bie
2019-06-19 12:37 ` Maxime Coquelin
2019-06-18 7:41 ` Tiwei Bie [this message]
2019-06-19 12:37 ` [dpdk-dev] [PATCH 3/4] net/virtio: fix memory leak in mergeable packed Rx Maxime Coquelin
2019-06-18 7:41 ` [dpdk-dev] [PATCH 4/4] net/virtio: fix packets check " Tiwei Bie
2019-06-19 13:08 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618074159.3322-4-tiwei.bie@intel.com \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.