From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stefan Roese <sr@denx.de>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Yegor Yefremov <yegorslists@googlemail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Giulio Benetti <giulio.benetti@micronovasrl.com>
Subject: Re: [PATCH 2/2 v5] tty/serial/8250: use mctrl_gpio helpers
Date: Tue, 18 Jun 2019 09:49:03 +0200 [thread overview]
Message-ID: <20190618074903.GA5216@kroah.com> (raw)
In-Reply-To: <20190611105603.4435-2-sr@denx.de>
On Tue, Jun 11, 2019 at 12:56:03PM +0200, Stefan Roese wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> This patch permits the usage for GPIOs to control
> the CTS/RTS/DTR/DSR/DCD/RI signals.
>
> Changed by Stefan:
> Only call mctrl_gpio_init(), if the device has no ACPI companion device
> to not break existing ACPI based systems. Also only use the mctrl_gpio_
> functions when "gpios" is available.
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Please do not add a signed-off-by from people for an old patch that was
reverted. It implies that I still agree with this change :(
greg k-h
prev parent reply other threads:[~2019-06-18 7:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 10:56 [PATCH 1/2 v5] serial: mctrl_gpio: Check if GPIO property exisits before requesting it Stefan Roese
2019-06-11 10:56 ` [PATCH 2/2 v5] tty/serial/8250: use mctrl_gpio helpers Stefan Roese
2019-06-11 12:44 ` Andy Shevchenko
2019-06-11 14:02 ` Stefan Roese
2019-06-11 14:48 ` Andy Shevchenko
2019-06-12 8:13 ` Stefan Roese
2019-06-12 9:16 ` Andy Shevchenko
2019-06-13 5:32 ` Stefan Roese
2019-06-13 11:05 ` Andy Shevchenko
2019-06-18 7:49 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618074903.GA5216@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=giulio.benetti@micronovasrl.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sr@denx.de \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.