All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Check visibility in icl_build_plane_wm
Date: Tue, 18 Jun 2019 14:44:00 +0300	[thread overview]
Message-ID: <20190618114400.GK5942@intel.com> (raw)
In-Reply-To: <9aa7d57c-8f9b-eeb9-16a9-718b4c6eae45@linux.intel.com>

On Tue, Jun 18, 2019 at 11:16:41AM +0200, Maarten Lankhorst wrote:
> Op 17-06-2019 om 14:34 schreef Ville Syrjälä:
> > On Fri, Jun 14, 2019 at 12:39:41PM +0200, Maarten Lankhorst wrote:
> >> When a planar YUV plane is configured, but the crtc is
> >> marked inactive, we can end up with a linked plane without
> >> visibility.
> > How is that possible? I don't think we should be adding the slave plane
> > if the master is not visible.
> 
> 
> DPMS off, we calculate the various fields as if the CRTC is on, then disable visibility.
> 
> crtc_state->nv12_planes etc still get set, so it works as if the crtc is on.
> 
> It's a way of not allowing an invalid result when dpms is off, then breaking on crtc enable.

Hmm. I wonder when we started to do that. If we're already doing this
much then I wonder how far we are from just dealing with the FIXME in
intel_wm_plane_visible() instead?

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-06-18 11:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 10:39 [PATCH] drm/i915: Check visibility in icl_build_plane_wm Maarten Lankhorst
2019-06-14 11:58 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-06-14 23:54 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-15 17:45 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-17 12:34 ` [PATCH] " Ville Syrjälä
2019-06-18  9:16   ` Maarten Lankhorst
2019-06-18 11:44     ` Ville Syrjälä [this message]
2019-06-18 11:59       ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190618114400.GK5942@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.