From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: martin.peres@intel.com
Subject: [igt-dev] [PATCH i-g-t 2/2] tests/kms_chamelium: fix read from uninitialized value in flatline audio test
Date: Tue, 18 Jun 2019 15:55:43 +0300 [thread overview]
Message-ID: <20190618125543.646-2-simon.ser@intel.com> (raw)
In-Reply-To: <20190618125543.646-1-simon.ser@intel.com>
streak isn't initialized, which makes the test fail in the case in which it's
not zero by chance. This bug has been seen in production™.
Signed-off-by: Simon Ser <simon.ser@intel.com>
---
tests/kms_chamelium.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index 94438e9ae0fc..378024d8fd05 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -1237,6 +1237,7 @@ static bool test_audio_flatline(struct audio_state *state)
recv = NULL;
recv_len = 0;
amp_success = false;
+ streak = 0;
while (!amp_success && state->msec < AUDIO_TIMEOUT) {
audio_state_receive(state, &recv, &recv_len);
--
2.22.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-18 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 12:55 [igt-dev] [PATCH i-g-t 1/2] lib/igt_eld: fix potential read from undefined value Simon Ser
2019-06-18 12:55 ` Simon Ser [this message]
2019-06-18 13:01 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_chamelium: fix read from uninitialized value in flatline audio test Peres, Martin
2019-06-18 13:01 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_eld: fix potential read from undefined value Peres, Martin
2019-06-18 14:18 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2019-06-19 2:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618125543.646-2-simon.ser@intel.com \
--to=simon.ser@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.