From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 07/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing Date: Tue, 18 Jun 2019 16:16:04 +0200 Message-ID: <20190618141604.GC12905@phenom.ffwll.local> References: <20190618135821.8644-1-kraxel@redhat.com> <20190618135821.8644-8-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28CB06E1B6 for ; Tue, 18 Jun 2019 14:16:08 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id k21so21983454edq.3 for ; Tue, 18 Jun 2019 07:16:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190618135821.8644-8-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: David Airlie , open list , dri-devel@lists.freedesktop.org, "open list:VIRTIO GPU DRIVER" List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdW4gMTgsIDIwMTkgYXQgMDM6NTg6MTVQTSArMDIwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiBVc2UgZ2VtIHJlc2VydmF0aW9uIGhlbHBlcnMgYW5kIGRpcmVjdCByZXNlcnZhdGlv bl9vYmplY3RfKiBjYWxscwo+IGluc3RlYWQgb2YgdHRtLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEdl cmQgSG9mZm1hbm4gPGtyYXhlbEByZWRoYXQuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v dmlydGlvL3ZpcnRncHVfaW9jdGwuYyB8IDM2ICsrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4g IDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1X2lvY3RsLmMgYi9kcml2 ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRncHVfaW9jdGwuYwo+IGluZGV4IDVjZmZkMmU1NGMwNC4u NmRiNmE2ZTkyZGRlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92aXJ0aW8vdmlydGdw dV9pb2N0bC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1X2lvY3RsLmMK PiBAQCAtMTA3LDEyICsxMDcsMTEgQEAgc3RhdGljIGludCB2aXJ0aW9fZ3B1X2V4ZWNidWZmZXJf aW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCXN0cnVjdCB2aXJ0 aW9fZ3B1X2Zwcml2ICp2ZnByaXYgPSBkcm1fZmlsZS0+ZHJpdmVyX3ByaXY7Cj4gIAlzdHJ1Y3Qg ZHJtX2dlbV9vYmplY3QgKmdvYmo7Cj4gIAlzdHJ1Y3QgdmlydGlvX2dwdV9mZW5jZSAqb3V0X2Zl bmNlOwo+IC0Jc3RydWN0IHZpcnRpb19ncHVfb2JqZWN0ICpxb2JqOwo+ICAJaW50IHJldDsKPiAg CXVpbnQzMl90ICpib19oYW5kbGVzID0gTlVMTDsKPiAgCXZvaWQgX191c2VyICp1c2VyX2JvX2hh bmRsZXMgPSBOVUxMOwo+ICAJc3RydWN0IGxpc3RfaGVhZCB2YWxpZGF0ZV9saXN0Owo+IC0Jc3Ry dWN0IHR0bV92YWxpZGF0ZV9idWZmZXIgKmJ1Zmxpc3QgPSBOVUxMOwo+ICsJc3RydWN0IGRybV9n ZW1fb2JqZWN0ICoqYnVmbGlzdCA9IE5VTEw7Cj4gIAlpbnQgaTsKPiAgCXN0cnVjdCB3d19hY3F1 aXJlX2N0eCB0aWNrZXQ7Cj4gIAlzdHJ1Y3Qgc3luY19maWxlICpzeW5jX2ZpbGU7Cj4gQEAgLTE1 NywxMiArMTU2LDExIEBAIHN0YXRpYyBpbnQgdmlydGlvX2dwdV9leGVjYnVmZmVyX2lvY3RsKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAo+ICAJSU5JVF9MSVNUX0hFQUQo JnZhbGlkYXRlX2xpc3QpOwo+ICAJaWYgKGV4YnVmLT5udW1fYm9faGFuZGxlcykgewo+IC0KPiAg CQlib19oYW5kbGVzID0ga3ZtYWxsb2NfYXJyYXkoZXhidWYtPm51bV9ib19oYW5kbGVzLAo+IC0J CQkJCSAgIHNpemVvZih1aW50MzJfdCksIEdGUF9LRVJORUwpOwo+ICsJCQkJCSAgICBzaXplb2Yo dWludDMyX3QpLCBHRlBfS0VSTkVMKTsKPiAgCQlidWZsaXN0ID0ga3ZtYWxsb2NfYXJyYXkoZXhi dWYtPm51bV9ib19oYW5kbGVzLAo+IC0JCQkJCSAgIHNpemVvZihzdHJ1Y3QgdHRtX3ZhbGlkYXRl X2J1ZmZlciksCj4gLQkJCQkJICAgR0ZQX0tFUk5FTCB8IF9fR0ZQX1pFUk8pOwo+ICsJCQkJCSBz aXplb2Yoc3RydWN0IGRybV9nZW1fb2JqZWN0KiksCj4gKwkJCQkJIEdGUF9LRVJORUwgfCBfX0dG UF9aRVJPKTsKPiAgCQlpZiAoIWJvX2hhbmRsZXMgfHwgIWJ1Zmxpc3QpIHsKPiAgCQkJcmV0ID0g LUVOT01FTTsKPiAgCQkJZ290byBvdXRfdW51c2VkX2ZkOwo+IEBAIC0xODEsMTkgKzE3OSwxNSBA QCBzdGF0aWMgaW50IHZpcnRpb19ncHVfZXhlY2J1ZmZlcl9pb2N0bChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJCQkJcmV0ID0gLUVOT0VOVDsKPiAgCQkJCWdvdG8gb3V0 X3VudXNlZF9mZDsKPiAgCQkJfQo+IC0KPiAtCQkJcW9iaiA9IGdlbV90b192aXJ0aW9fZ3B1X29i aihnb2JqKTsKPiAtCQkJYnVmbGlzdFtpXS5ibyA9ICZxb2JqLT50Ym87Cj4gLQo+IC0JCQlsaXN0 X2FkZCgmYnVmbGlzdFtpXS5oZWFkLCAmdmFsaWRhdGVfbGlzdCk7Cj4gKwkJCWJ1Zmxpc3RbaV0g PSBnb2JqOwoKSSBkaWRuJ3QgYm90aGVyIGxvb2tpbmcsIGJ1dCBJIGd1ZXNzIHRoZXJlJ3Mgc29t ZSByb29tIGZvciBhCmFycmF5LW9mLWdlbS1pZCB0byBnZW1fYm8tcG9pbnRlcnMgaGVscGVyIGZ1 bmN0aW9uPyBXb3VsZCBvbmx5IG1ha2Ugc2Vuc2UKaWYgd2UgY2FuIHNoYXJlIGl0IHdpdGggcGFu ZnJvc3QvdjNkIG1heWJlLgoKPiAgCQl9Cj4gIAkJa3ZmcmVlKGJvX2hhbmRsZXMpOwo+ICAJCWJv X2hhbmRsZXMgPSBOVUxMOwo+ICAJfQo+ICAKPiAtCXJldCA9IHZpcnRpb19ncHVfb2JqZWN0X2xp c3RfdmFsaWRhdGUoJnRpY2tldCwgJnZhbGlkYXRlX2xpc3QpOwo+ICsJcmV0ID0gZHJtX2dlbV9s b2NrX3Jlc2VydmF0aW9ucyhidWZsaXN0LCBleGJ1Zi0+bnVtX2JvX2hhbmRsZXMsICZ0aWNrZXQp Owo+ICAJaWYgKHJldCkKPiAtCQlnb3RvIG91dF9mcmVlOwo+ICsJCWdvdG8gb3V0X3VudXNlZF9m ZDsKPiAgCj4gIAlidWYgPSBtZW1kdXBfdXNlcih1NjRfdG9fdXNlcl9wdHIoZXhidWYtPmNvbW1h bmQpLCBleGJ1Zi0+c2l6ZSk7Cj4gIAlpZiAoSVNfRVJSKGJ1ZikpIHsKPiBAQCAtMjIyLDIxICsy MTYsMjUgQEAgc3RhdGljIGludCB2aXJ0aW9fZ3B1X2V4ZWNidWZmZXJfaW9jdGwoc3RydWN0IGRy bV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCXZpcnRpb19ncHVfY21kX3N1Ym1pdCh2Z2Rl diwgYnVmLCBleGJ1Zi0+c2l6ZSwKPiAgCQkJICAgICAgdmZwcml2LT5jdHhfaWQsIG91dF9mZW5j ZSk7Cj4gIAo+IC0JdHRtX2V1X2ZlbmNlX2J1ZmZlcl9vYmplY3RzKCZ0aWNrZXQsICZ2YWxpZGF0 ZV9saXN0LCAmb3V0X2ZlbmNlLT5mKTsKPiArCWZvciAoaSA9IDA7IGkgPCBleGJ1Zi0+bnVtX2Jv X2hhbmRsZXM7IGkrKykKPiArCQlyZXNlcnZhdGlvbl9vYmplY3RfYWRkX2V4Y2xfZmVuY2UoYnVm bGlzdFtpXS0+cmVzdiwgJm91dF9mZW5jZS0+Zik7CgpIZWxwZXIgdG8gdW5yZWYgYW4gYXJyYXkg b2YgZ2VtIGJvPyBQcm9iYWJseSBhbHNvIG5lZWRlZCBieSBvdGhlciBkcml2ZXJzLgoKCj4gKwlk cm1fZ2VtX3VubG9ja19yZXNlcnZhdGlvbnMoYnVmbGlzdCwgZXhidWYtPm51bV9ib19oYW5kbGVz LCAmdGlja2V0KTsKPiAgCj4gLQkvKiBmZW5jZSB0aGUgY29tbWFuZCBibyAqLwo+IC0JdmlydGlv X2dwdV91bnJlZl9saXN0KCZ2YWxpZGF0ZV9saXN0KTsKPiArCWZvciAoaSA9IDA7IGkgPCBleGJ1 Zi0+bnVtX2JvX2hhbmRsZXM7IGkrKykKPiArCQlpZiAoYnVmbGlzdFtpXSkKPiArCQkJZHJtX2dl bV9vYmplY3RfcHV0X3VubG9ja2VkKGJ1Zmxpc3RbaV0pOwoKSSBhbSBsZWZ0IHdvbmRlcmluZyB3 aG8ncyBob2xkaW5nIHJlZmVyZW5jZXMgb250byB0aGVzZSBidWZmZXJzIG5vdz8gSG93CmRvIHlv dSBtYWtlIHN1cmUgdGhleSBkb24ndCBkaXNhcHBlYXIgdW50aW1lbHk/CgpJIHRoaW5rIGF0bSBp dCdzIHR0bSBtYWtpbmcgc3VyZSBvZiB0aGF0LCBidXQgaWYgeW91IGRyb3AgdGhhdCBjb21wbGV0 ZWx5CnRoZXJlIG5lZWRzIHRvIGJlIHNvbWV0aGluZyBlbHNlLgoKPiAgCWt2ZnJlZShidWZsaXN0 KTsKPiAgCXJldHVybiAwOwo+ICAKPiAgb3V0X21lbWR1cDoKPiAgCWtmcmVlKGJ1Zik7Cj4gIG91 dF91bnJlc3Y6Cj4gLQl0dG1fZXVfYmFja29mZl9yZXNlcnZhdGlvbigmdGlja2V0LCAmdmFsaWRh dGVfbGlzdCk7Cj4gLW91dF9mcmVlOgo+IC0JdmlydGlvX2dwdV91bnJlZl9saXN0KCZ2YWxpZGF0 ZV9saXN0KTsKPiArCWRybV9nZW1fdW5sb2NrX3Jlc2VydmF0aW9ucyhidWZsaXN0LCBleGJ1Zi0+ bnVtX2JvX2hhbmRsZXMsICZ0aWNrZXQpOwo+ICBvdXRfdW51c2VkX2ZkOgo+ICAJa3ZmcmVlKGJv X2hhbmRsZXMpOwo+ICsJZm9yIChpID0gMDsgaSA8IGV4YnVmLT5udW1fYm9faGFuZGxlczsgaSsr KQo+ICsJCWlmIChidWZsaXN0ICYmIGJ1Zmxpc3RbaV0pCj4gKwkJCWRybV9nZW1fb2JqZWN0X3B1 dF91bmxvY2tlZChidWZsaXN0W2ldKTsKPiAgCWt2ZnJlZShidWZsaXN0KTsKPiAgCj4gIAlpZiAo b3V0X2ZlbmNlX2ZkID49IDApCgpQYXRjaCBpdHNlbGYgbG9va3MgY29ycmVjdCwganVzdCBwdXQg ZG93biBteSB0aG91Z2h0cyB3aGlsZSByZXZpZXdpbmcgaXQuCgpSZXZpZXdlZC1ieTogRGFuaWVs IFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0gCj4gMi4xOC4xCj4gCgotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDov L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05766C31E5B for ; Tue, 18 Jun 2019 14:16:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5C5921479 for ; Tue, 18 Jun 2019 14:16:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Mn/9T9RB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729452AbfFROQK (ORCPT ); Tue, 18 Jun 2019 10:16:10 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:36883 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726248AbfFROQJ (ORCPT ); Tue, 18 Jun 2019 10:16:09 -0400 Received: by mail-ed1-f67.google.com with SMTP id w13so22008378eds.4 for ; Tue, 18 Jun 2019 07:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=wDyr/Hayw2IId/qNGbRLKP0mrDW1etMQA1PqQ01Gh10=; b=Mn/9T9RBbKXfNDMa8owY91k+MzyKmTXct/gRR9pkGC5sb28PLS5L9iEMP+FZmAFPw/ nwcYkVIuVZ/ruRkYJiy/qr0IKuLKzkvmTQKUFFN64wRCq46JvEjab28ekRfZWFHW99BU s+ZJXt5+tn/X0ihJrtkCJrp54eaXZ/EFkx3GU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=wDyr/Hayw2IId/qNGbRLKP0mrDW1etMQA1PqQ01Gh10=; b=iaSKbEmF51N/xU3XM50M4oIy7CNhD+O3JbVuUZ8u/IpsFGTbe30E2RdfbYUwU+r6Hk 0n44rnK8ONAI+QiXbbG0m2emEcvtch6BUljVJBt1G/XYjjOp7KLKLcy9L2P/Cy8ckqp7 A1hedO66VzUfcefm0tFmEIxblYBH9UayaVIX8MUlSQS1iso+KsPyNn9RhyvJhG90uRzJ 0fT+ULfK95V43wBp/01SfOR+t+g9LX9DiZGKPIFbMU9bw84PFTjSClcZR/ltBRHiKVAH BCQBLi63y314h8ND8dpPB38aPhLvbazPTjrWm8OmMojB3E4lQfV7Km1BJA2yIozuMo1L xUaA== X-Gm-Message-State: APjAAAWkotfsvRAoqKC4PplOSYoHp1eo5lZXc0wqC2pCc4Kl2eJM04s0 he0i9EckCT4xxwyj7A4S2Y76Gw== X-Google-Smtp-Source: APXvYqzHXRYbcU+TSBG4oW3FDjsgiz3ekO87GItDZsVEAp5uoRHTuVJorSJpFrSxqXar92qtE0rl/g== X-Received: by 2002:a17:906:670c:: with SMTP id a12mr54979446ejp.290.1560867366769; Tue, 18 Jun 2019 07:16:06 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id i16sm2842945ejc.16.2019.06.18.07.16.05 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 18 Jun 2019 07:16:06 -0700 (PDT) Date: Tue, 18 Jun 2019 16:16:04 +0200 From: Daniel Vetter To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, David Airlie , Daniel Vetter , "open list:VIRTIO GPU DRIVER" , open list Subject: Re: [PATCH v2 07/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing Message-ID: <20190618141604.GC12905@phenom.ffwll.local> Mail-Followup-To: Gerd Hoffmann , dri-devel@lists.freedesktop.org, David Airlie , "open list:VIRTIO GPU DRIVER" , open list References: <20190618135821.8644-1-kraxel@redhat.com> <20190618135821.8644-8-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190618135821.8644-8-kraxel@redhat.com> X-Operating-System: Linux phenom 4.19.0-5-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 18, 2019 at 03:58:15PM +0200, Gerd Hoffmann wrote: > Use gem reservation helpers and direct reservation_object_* calls > instead of ttm. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 36 ++++++++++++-------------- > 1 file changed, 17 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c > index 5cffd2e54c04..6db6a6e92dde 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c > +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c > @@ -107,12 +107,11 @@ static int virtio_gpu_execbuffer_ioctl(struct drm_device *dev, void *data, > struct virtio_gpu_fpriv *vfpriv = drm_file->driver_priv; > struct drm_gem_object *gobj; > struct virtio_gpu_fence *out_fence; > - struct virtio_gpu_object *qobj; > int ret; > uint32_t *bo_handles = NULL; > void __user *user_bo_handles = NULL; > struct list_head validate_list; > - struct ttm_validate_buffer *buflist = NULL; > + struct drm_gem_object **buflist = NULL; > int i; > struct ww_acquire_ctx ticket; > struct sync_file *sync_file; > @@ -157,12 +156,11 @@ static int virtio_gpu_execbuffer_ioctl(struct drm_device *dev, void *data, > > INIT_LIST_HEAD(&validate_list); > if (exbuf->num_bo_handles) { > - > bo_handles = kvmalloc_array(exbuf->num_bo_handles, > - sizeof(uint32_t), GFP_KERNEL); > + sizeof(uint32_t), GFP_KERNEL); > buflist = kvmalloc_array(exbuf->num_bo_handles, > - sizeof(struct ttm_validate_buffer), > - GFP_KERNEL | __GFP_ZERO); > + sizeof(struct drm_gem_object*), > + GFP_KERNEL | __GFP_ZERO); > if (!bo_handles || !buflist) { > ret = -ENOMEM; > goto out_unused_fd; > @@ -181,19 +179,15 @@ static int virtio_gpu_execbuffer_ioctl(struct drm_device *dev, void *data, > ret = -ENOENT; > goto out_unused_fd; > } > - > - qobj = gem_to_virtio_gpu_obj(gobj); > - buflist[i].bo = &qobj->tbo; > - > - list_add(&buflist[i].head, &validate_list); > + buflist[i] = gobj; I didn't bother looking, but I guess there's some room for a array-of-gem-id to gem_bo-pointers helper function? Would only make sense if we can share it with panfrost/v3d maybe. > } > kvfree(bo_handles); > bo_handles = NULL; > } > > - ret = virtio_gpu_object_list_validate(&ticket, &validate_list); > + ret = drm_gem_lock_reservations(buflist, exbuf->num_bo_handles, &ticket); > if (ret) > - goto out_free; > + goto out_unused_fd; > > buf = memdup_user(u64_to_user_ptr(exbuf->command), exbuf->size); > if (IS_ERR(buf)) { > @@ -222,21 +216,25 @@ static int virtio_gpu_execbuffer_ioctl(struct drm_device *dev, void *data, > virtio_gpu_cmd_submit(vgdev, buf, exbuf->size, > vfpriv->ctx_id, out_fence); > > - ttm_eu_fence_buffer_objects(&ticket, &validate_list, &out_fence->f); > + for (i = 0; i < exbuf->num_bo_handles; i++) > + reservation_object_add_excl_fence(buflist[i]->resv, &out_fence->f); Helper to unref an array of gem bo? Probably also needed by other drivers. > + drm_gem_unlock_reservations(buflist, exbuf->num_bo_handles, &ticket); > > - /* fence the command bo */ > - virtio_gpu_unref_list(&validate_list); > + for (i = 0; i < exbuf->num_bo_handles; i++) > + if (buflist[i]) > + drm_gem_object_put_unlocked(buflist[i]); I am left wondering who's holding references onto these buffers now? How do you make sure they don't disappear untimely? I think atm it's ttm making sure of that, but if you drop that completely there needs to be something else. > kvfree(buflist); > return 0; > > out_memdup: > kfree(buf); > out_unresv: > - ttm_eu_backoff_reservation(&ticket, &validate_list); > -out_free: > - virtio_gpu_unref_list(&validate_list); > + drm_gem_unlock_reservations(buflist, exbuf->num_bo_handles, &ticket); > out_unused_fd: > kvfree(bo_handles); > + for (i = 0; i < exbuf->num_bo_handles; i++) > + if (buflist && buflist[i]) > + drm_gem_object_put_unlocked(buflist[i]); > kvfree(buflist); > > if (out_fence_fd >= 0) Patch itself looks correct, just put down my thoughts while reviewing it. Reviewed-by: Daniel Vetter > -- > 2.18.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch