From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Johannes Sixt <j6t@kdbg.org>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, Jeff King <peff@peff.net>,
Duy Nguyen <pclouds@gmail.com>,
Jonathan Tan <jonathantanmy@google.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 01/10] t: add helper to convert object IDs to paths
Date: Tue, 18 Jun 2019 18:55:25 +0200 [thread overview]
Message-ID: <20190618165525.GN31952@szeder.dev> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1906181647480.44@tvgsbejvaqbjf.bet>
On Tue, Jun 18, 2019 at 06:15:46PM +0200, Johannes Schindelin wrote:
> > Regardless of how it is implemented, I have another gripe with this
> > helper: the way it must be used requires a process: $(test_out_to_path
> > $foo)
>
> Indeed.
>
> > And looking through this patch series, I see a gazillion of *new*
> > process substitutions $(test_something...) and $(basename $whatever).
> > Can't we do something about it?
>
> I wish there was. Unix shell scripting has not evolved much in the past,
> what, 3 decades? So I don't really see a way to "pass variables by
> reference" to shell functions, short of calling `eval` (which buys
> preciously little as it _also_ has to spawn a new process [*1*]).
> Footnote *1*: Theoretically, it could be a *ton* faster by using threads
> on Windows. But threads are pretty much an afterthought on Unix/Linux, so
> no mainstream POSIX shell supports this. They all `fork()` to interpret an
> `eval` as far as I can tell.
'eval' doesn't fork(). It can't possibly fork(), because if it did,
then any variables set in the eval-ed code snippet couldn't be visible
outside the 'eval'.
next prev parent reply other threads:[~2019-06-18 16:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-16 18:53 [PATCH v2 00/10] Hash-independent tests, part 4 brian m. carlson
2019-06-16 18:53 ` [PATCH v2 01/10] t: add helper to convert object IDs to paths brian m. carlson
2019-06-17 19:05 ` Johannes Schindelin
2019-06-18 1:29 ` brian m. carlson
2019-06-18 6:14 ` Johannes Sixt
2019-06-18 16:15 ` Johannes Schindelin
2019-06-18 16:55 ` SZEDER Gábor [this message]
2019-06-19 19:56 ` Johannes Schindelin
2019-06-18 17:04 ` Jeff King
2019-06-19 19:55 ` Johannes Schindelin
2019-06-18 23:03 ` brian m. carlson
2019-06-16 18:53 ` [PATCH v2 02/10] t1410: make hash size independent brian m. carlson
2019-06-16 18:53 ` [PATCH v2 03/10] t1450: " brian m. carlson
2019-06-16 18:53 ` [PATCH v2 04/10] t5000: make hash independent brian m. carlson
2019-06-16 18:53 ` [PATCH v2 05/10] t6030: make test work with SHA-256 brian m. carlson
2019-06-16 18:53 ` [PATCH v2 06/10] t0027: make hash size independent brian m. carlson
2019-06-16 18:53 ` [PATCH v2 07/10] t0090: make test pass with SHA-256 brian m. carlson
2019-06-16 18:53 ` [PATCH v2 08/10] t1007: remove SHA1 prerequisites brian m. carlson
2019-06-16 18:53 ` [PATCH v2 09/10] t1710: make hash independent brian m. carlson
2019-06-16 18:53 ` [PATCH v2 10/10] t2203: avoid hard-coded object ID values brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618165525.GN31952@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jonathantanmy@google.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.