From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade
Date: Wed, 19 Jun 2019 09:03:52 -0300 [thread overview]
Message-ID: <20190619120346.GC26980@continental> (raw)
In-Reply-To: <20190619094540.GA26980@continental>
On Wed, Jun 19, 2019 at 06:45:43AM -0300, Marcos Paulo de Souza wrote:
> On Tue, Jun 18, 2019 at 11:21:22PM -0400, Martin K. Petersen wrote:
> >
> > Marcos,
> >
> > > Currently, all USB devices skip VPD pages, even when the device
> > > supports them (SPC-3 and later), but some of them support VPD, like
> > > Cruzer Blade.
> >
> > What's your confidence level wrt. all Cruzer Blades handling this
> > correctly? How many devices have you tested this change with?
>
> I've tested three Cruzer Blades that I have at hand, and all of them have VPD
> support, and also checked with a friend of mine that also have one. I can't say
> about "all others" but so far, 4/4 devices that I tested have VPD. (They were all
> SPC-3 or SPC-4 compliant).
>
My first idea was to add a vendor:product mapping at SCSI layer, but so far I
haven't found one, so I added the model/vendor found by INQUIRY. Would it be
better to check for prod:vendor (as values, instead of the description)?
Thanks,
Marcos
> >
> > --
> > Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-06-19 12:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 1:31 [PATCH 0/2] Honor VPD check in usb/storage for SanDisk device Marcos Paulo de Souza
2019-06-18 1:31 ` [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade Marcos Paulo de Souza
2019-06-19 3:21 ` Martin K. Petersen
2019-06-19 9:45 ` Marcos Paulo de Souza
2019-06-19 12:03 ` Marcos Paulo de Souza [this message]
2019-06-20 20:32 ` Martin K. Petersen
2019-07-02 23:09 ` Marcos Paulo de Souza
2019-06-20 20:31 ` Martin K. Petersen
2019-07-12 0:41 ` Martin K. Petersen
2019-06-18 1:31 ` [PATCH 2/2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set Marcos Paulo de Souza
2019-06-18 1:31 ` Marcos Paulo de Souza
2019-06-18 6:49 ` Greg Kroah-Hartman
2019-06-18 10:30 ` Marcos Paulo de Souza
2019-06-18 10:52 ` Greg Kroah-Hartman
2019-06-18 10:56 ` Marcos Paulo de Souza
2019-06-18 13:48 ` Alan Stern
2019-06-18 15:17 ` Marcos Paulo de Souza
2019-06-18 16:07 ` Greg Kroah-Hartman
2019-06-18 22:46 ` Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619120346.GC26980@continental \
--to=marcos.souza.org@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.