From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v2 1/2] dt-bindings: display: Add King Display KD035G6-54NT panel documentation Date: Wed, 19 Jun 2019 14:28:50 +0200 Message-ID: <20190619122850.GC29084@ravnborg.org> References: <20190603152555.23527-1-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190603152555.23527-1-paul@crapouillou.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Cercueil Cc: Mark Rutland , devicetree@vger.kernel.org, od@zcrc.me, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Thierry Reding List-Id: devicetree@vger.kernel.org T24gTW9uLCBKdW4gMDMsIDIwMTkgYXQgMDU6MjU6NTRQTSArMDIwMCwgUGF1bCBDZXJjdWVpbCB3 cm90ZToKPiBUaGUgS0QwMzVHNi01NE5UIGlzIGEgMy41IiAzMjB4MjQwIDI0LWJpdCBURlQgTENE IHBhbmVsLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhdWwgQ2VyY3VlaWwgPHBhdWxAY3JhcG91aWxs b3UubmV0PgpSZXZpZXdlZC1ieTogU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJvcmcub3JnPgoKUm9i IC0gcGluZyBmb3IgcmV2aWV3LgoKCVNhbQoKPiAtLS0KPiAKPiBOb3RlczoKPiAgICAgdjI6IC0g QWRkIGFuIGFkZHJlc3MgdG8gdGhlIHBhbmVsIG5vZGUKPiAgICAgCS0gQWRkIGluZm9ybWF0aW9u IGFib3V0IFNQSSBwcm9wZXJ0aWVzCj4gICAgIAktIEFkZCBpbmZvcm1hdGlvbiBhYm91dCB0aGUg J3BvcnQnIHN1Yi1ub2RlCj4gCj4gIC4uLi9wYW5lbC9raW5nZGlzcGxheSxrZDAzNWc2LTU0bnQu dHh0ICAgICAgICB8IDQyICsrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDQy IGluc2VydGlvbnMoKykKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL2tpbmdkaXNwbGF5LGtkMDM1ZzYtNTRudC50eHQK PiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3Bs YXkvcGFuZWwva2luZ2Rpc3BsYXksa2QwMzVnNi01NG50LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL2tpbmdkaXNwbGF5LGtkMDM1ZzYtNTRudC50 eHQKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMDAwMC4uZmE5NTk2MDgy ZTQ0Cj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9kaXNwbGF5L3BhbmVsL2tpbmdkaXNwbGF5LGtkMDM1ZzYtNTRudC50eHQKPiBAQCAtMCww ICsxLDQyIEBACj4gK0tpbmcgRGlzcGxheSBLRDAzNUc2LTU0TlQgMy41IiAoMzIweDI0MCBwaXhl bHMpIDI0LWJpdCBURlQgTENEIHBhbmVsCj4gKwo+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ICst IGNvbXBhdGlibGU6IHNob3VsZCBiZSAia2luZ2Rpc3BsYXksa2QwMzVnNi01NG50Igo+ICstIHBv d2VyLXN1cHBseTogU2VlIHBhbmVsLWNvbW1vbi50eHQKPiArLSByZXNldC1ncGlvczogU2VlIHBh bmVsLWNvbW1vbi50eHQKPiArCj4gK09wdGlvbmFsIHByb3BlcnRpZXM6Cj4gKy0gYmFja2xpZ2h0 OiBzZWUgcGFuZWwtY29tbW9uLnR4dAo+ICsKPiArVGhlIGdlbmVyaWMgYmluZGluZ3MgZm9yIHRo ZSBTUEkgc2xhdmVzIGRvY3VtZW50ZWQgaW4gWzFdIGFsc28gYXBwbHkuCj4gKwo+ICtUaGUgZGV2 aWNlIG5vZGUgY2FuIGNvbnRhaW4gb25lICdwb3J0JyBjaGlsZCBub2RlIHdpdGggb25lIGNoaWxk Cj4gKydlbmRwb2ludCcgbm9kZSwgYWNjb3JkaW5nIHRvIHRoZSBiaW5kaW5ncyBkZWZpbmVkIGlu IFsyXS4gVGhpcwo+ICtub2RlIHNob3VsZCBkZXNjcmliZSBwYW5lbCdzIHZpZGVvIGJ1cy4KPiAr Cj4gK1sxXTogRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NwaS9zcGktYnVzLnR4 dAo+ICtbMl06IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9ncmFwaC50eHQKPiAr Cj4gK0V4YW1wbGU6Cj4gKwo+ICsmc3BpIHsKPiArCXBhbmVsQDAgewo+ICsJCWNvbXBhdGlibGUg PSAia2luZ2Rpc3BsYXksa2QwMzVnNi01NG50IjsKPiArCQlyZWcgPSA8MD47Cj4gKwo+ICsJCXNw aS1tYXgtZnJlcXVlbmN5ID0gPDMxMjUwMDA+Owo+ICsJCXNwaS0zd2lyZTsKPiArCQlzcGktY3Mt aGlnaDsKPiArCj4gKwkJcmVzZXQtZ3Bpb3MgPSA8JmdwZSAyIEdQSU9fQUNUSVZFX0xPVz47Cj4g Kwo+ICsJCWJhY2tsaWdodCA9IDwmYmFja2xpZ2h0PjsKPiArCQlwb3dlci1zdXBwbHkgPSA8Jmxk bzY+Owo+ICsKPiArCQlwb3J0IHsKPiArCQkJcGFuZWxfaW5wdXQ6IGVuZHBvaW50IHsKPiArCQkJ CXJlbW90ZS1lbmRwb2ludCA9IDwmcGFuZWxfb3V0cHV0PjsKPiArCQkJfTsKPiArCQl9Owo+ICsJ fTsKPiArfTsKPiAtLSAKPiAyLjIxLjAuNTkzLmc1MTFlYzM0NWUxOApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B79F0C31E49 for ; Wed, 19 Jun 2019 12:28:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97A5C2182B for ; Wed, 19 Jun 2019 12:28:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731765AbfFSM2z (ORCPT ); Wed, 19 Jun 2019 08:28:55 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:57633 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbfFSM2y (ORCPT ); Wed, 19 Jun 2019 08:28:54 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 9517A20026; Wed, 19 Jun 2019 14:28:51 +0200 (CEST) Date: Wed, 19 Jun 2019 14:28:50 +0200 From: Sam Ravnborg To: Paul Cercueil , Rob Herring Cc: Thierry Reding , Rob Herring , Mark Rutland , od@zcrc.me, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: display: Add King Display KD035G6-54NT panel documentation Message-ID: <20190619122850.GC29084@ravnborg.org> References: <20190603152555.23527-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190603152555.23527-1-paul@crapouillou.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=7gkXJVJtAAAA:8 a=4-pPdtRa6f10XkIaLb0A:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=E9Po1WZjFZOl8hwRPBS3:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 03, 2019 at 05:25:54PM +0200, Paul Cercueil wrote: > The KD035G6-54NT is a 3.5" 320x240 24-bit TFT LCD panel. > > Signed-off-by: Paul Cercueil Reviewed-by: Sam Ravnborg Rob - ping for review. Sam > --- > > Notes: > v2: - Add an address to the panel node > - Add information about SPI properties > - Add information about the 'port' sub-node > > .../panel/kingdisplay,kd035g6-54nt.txt | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.txt b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.txt > new file mode 100644 > index 000000000000..fa9596082e44 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.txt > @@ -0,0 +1,42 @@ > +King Display KD035G6-54NT 3.5" (320x240 pixels) 24-bit TFT LCD panel > + > +Required properties: > +- compatible: should be "kingdisplay,kd035g6-54nt" > +- power-supply: See panel-common.txt > +- reset-gpios: See panel-common.txt > + > +Optional properties: > +- backlight: see panel-common.txt > + > +The generic bindings for the SPI slaves documented in [1] also apply. > + > +The device node can contain one 'port' child node with one child > +'endpoint' node, according to the bindings defined in [2]. This > +node should describe panel's video bus. > + > +[1]: Documentation/devicetree/bindings/spi/spi-bus.txt > +[2]: Documentation/devicetree/bindings/graph.txt > + > +Example: > + > +&spi { > + panel@0 { > + compatible = "kingdisplay,kd035g6-54nt"; > + reg = <0>; > + > + spi-max-frequency = <3125000>; > + spi-3wire; > + spi-cs-high; > + > + reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>; > + > + backlight = <&backlight>; > + power-supply = <&ldo6>; > + > + port { > + panel_input: endpoint { > + remote-endpoint = <&panel_output>; > + }; > + }; > + }; > +}; > -- > 2.21.0.593.g511ec345e18