All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Boeckel <mathstuf@gmail.com>
To: keyrings@vger.kernel.org
Subject: Re: keyctl_capabilities and buflen
Date: Wed, 19 Jun 2019 13:30:33 +0000	[thread overview]
Message-ID: <20190619133033.GA11027@rotor.kitware.com> (raw)
In-Reply-To: <20190605130247.GA21275@rotor.kitware.com>

On Wed, Jun 05, 2019 at 09:02:47 -0400, Ben Boeckel wrote:
> I'm looking at the implementation of `keyctl_capabilities` in the `next`
> branch and it's not clear if `buflen` is the size of the memory pointed
> to by `buffer` in array size or in byte size by its documentation. It
> seems to be the size in bytes by the code (the &3) could probably
> warrant a comment to make it clearer that it is related to
> sizeof(unsigned int) here). This seems very odd to me, or is it just a
> common kernel pattern I haven't seen before?

I see that this is now `unsigned char*` instead of `unsigned int` on
`next` now and in the kernel by the newest patch submission.

Thanks,

--Ben

  reply	other threads:[~2019-06-19 13:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 13:02 keyctl_capabilities and buflen Ben Boeckel
2019-06-19 13:30 ` Ben Boeckel [this message]
2019-06-19 14:56 ` David Howells
2019-06-19 15:15 ` Ben Boeckel
2019-06-19 15:22 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190619133033.GA11027@rotor.kitware.com \
    --to=mathstuf@gmail.com \
    --cc=keyrings@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.