From: "Woods, Brian" <Brian.Woods@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
"Woods, Brian" <Brian.Woods@amd.com>,
"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] AMD/IOMMU: revert "amd/iommu: assign iommu devices to Xen"
Date: Wed, 19 Jun 2019 16:29:07 +0000 [thread overview]
Message-ID: <20190619162904.GI20907@amd.com> (raw)
In-Reply-To: <5CF519E902000078002349FF@prv1-mh.provo.novell.com>
On Mon, Jun 03, 2019 at 07:00:25AM -0600, Jan Beulich wrote:
> [CAUTION: External Email]
>
> This reverts commit b6bd02b7a877f9fac2de69e64d8245d56f92ab25. The change
> was redundant with amd_iommu_detect_one_acpi() already calling
> pci_ro_device().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Brian Woods <brian.woods@amd.com>
> --- a/xen/drivers/passthrough/amd/iommu_init.c
> +++ b/xen/drivers/passthrough/amd/iommu_init.c
> @@ -1021,8 +1021,6 @@ static void * __init allocate_ppr_log(st
>
> static int __init amd_iommu_init_one(struct amd_iommu *iommu)
> {
> - pci_hide_device(iommu->seg, PCI_BUS(iommu->bdf), PCI_DEVFN2(iommu->bdf));
> -
> if ( map_iommu_mmio_region(iommu) != 0 )
> goto error_out;
>
>
>
--
Brian Woods
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-06-19 16:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 13:00 [PATCH] AMD/IOMMU: revert "amd/iommu: assign iommu devices to Xen" Jan Beulich
2019-06-03 13:00 ` [Xen-devel] " Jan Beulich
2019-06-04 8:48 ` Roger Pau Monné
2019-06-04 8:48 ` [Xen-devel] " Roger Pau Monné
2019-06-04 9:29 ` Jan Beulich
2019-06-04 9:29 ` [Xen-devel] " Jan Beulich
2019-06-04 13:02 ` Jan Beulich
2019-06-04 16:20 ` Roger Pau Monné
2019-06-05 7:55 ` Jan Beulich
2019-06-05 8:02 ` Jan Beulich
2019-06-05 9:52 ` Roger Pau Monné
2019-06-05 9:06 ` Roger Pau Monné
2019-06-05 9:12 ` Andrew Cooper
2019-06-05 9:14 ` Jan Beulich
2019-06-04 9:04 ` Andrew Cooper
2019-06-04 9:04 ` [Xen-devel] " Andrew Cooper
2019-06-04 9:21 ` Jan Beulich
2019-06-04 9:21 ` [Xen-devel] " Jan Beulich
2019-06-04 12:08 ` Jan Beulich
2019-06-19 16:29 ` Woods, Brian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619162904.GI20907@amd.com \
--to=brian.woods@amd.com \
--cc=JBeulich@suse.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.