From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05738C31E5B for ; Wed, 19 Jun 2019 19:47:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE63821721 for ; Wed, 19 Jun 2019 19:47:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730029AbfFSTrU (ORCPT ); Wed, 19 Jun 2019 15:47:20 -0400 Received: from mga05.intel.com ([192.55.52.43]:42929 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbfFSTrT (ORCPT ); Wed, 19 Jun 2019 15:47:19 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jun 2019 12:47:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,394,1557212400"; d="scan'208";a="358299752" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.36]) by fmsmga005.fm.intel.com with ESMTP; 19 Jun 2019 12:47:18 -0700 Date: Wed, 19 Jun 2019 12:47:18 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: Jim Mattson , Radim =?utf-8?B?S3LEjW3DocWZ?= , kvm list Subject: Re: [PATCH 2/2] KVM: nVMX: trace nested VM-Enter failures detected by H/W Message-ID: <20190619194718.GH1203@linux.intel.com> References: <20190308231645.25402-1-sean.j.christopherson@intel.com> <20190308231645.25402-3-sean.j.christopherson@intel.com> <20190314184540.GC4245@linux.intel.com> <0cb40615-de9e-4c3e-bcc7-68300a09481d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0cb40615-de9e-4c3e-bcc7-68300a09481d@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Mar 18, 2019 at 10:47:03AM +0100, Paolo Bonzini wrote: > On 15/03/19 20:53, Jim Mattson wrote: > > On Fri, Mar 15, 2019 at 11:15 AM Paolo Bonzini wrote: > >> > >> On 14/03/19 19:45, Sean Christopherson wrote: > >>>>> if (unlikely(vmx->fail)) { > >>>>> - pr_info_ratelimited("%s failed vm entry %x\n", __func__, > >>>>> - vmcs_read32(VM_INSTRUCTION_ERROR)); > >>>> I *love* the tracing, but I don't think we want to turn it on for > >>>> production. Can we keep the pr_info_ratelimited for when tracing is > >>>> disabled? > >>> Could we drop it to pr_debug_ratelimited()? Say "no" if it's at all > >>> inconvenient to use debug instead of info. The printing is nothing > >>> more than a minor annoyance when I'm running unit tests, i.e. any kind > >>> of actual use case trumps my partiality for a clean kernel log. > >>> > >> > >> I agree, it should be pr_debug_ratelimited (if anything). > > > > Let's go ahead and drop it, then. > > I'll add at least a vcpu_stat. Paolo, is this one of those series that you need to Google, or are you waiting on me for something? :-D