From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Brost Subject: Re: [PATCH 1/2] drm/i915/guc: reorder enable/disable communication steps Date: Wed, 19 Jun 2019 16:22:45 -0700 Message-ID: <20190619232244.GA75290@sdutt> References: <20190619214351.12000-1-daniele.ceraolospurio@intel.com> <20190619214351.12000-2-daniele.ceraolospurio@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id A6FDD6E495 for ; Wed, 19 Jun 2019 23:28:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190619214351.12000-2-daniele.ceraolospurio@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniele Ceraolo Spurio , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdW4gMTksIDIwMTkgYXQgMDI6NDM6NTBQTSAtMDcwMCwgRGFuaWVsZSBDZXJhb2xv IFNwdXJpbyB3cm90ZToKPk1ha2Ugc3VyZSB3ZSBhbHdheXMgaGF2ZSBDVCBidWZmZXJzIGVuYWJs ZWQgd2hlbiB0aGUgaW50ZXJydXB0cyBhcmUKPmVuYWJsZWQsIHNvIHdlIGNhbiBhbHdheXMgaGFu ZGxlIGludGVycnVwdHMgZnJvbSBHdUMuIEFsc28gbW92ZSB0aGUKPnNldHRpbmcgb2YgdGhlIGd1 Yy0+c2VuZCBhbmQgZ3VjLT5oYW5kbGVyIGZ1bmN0aW9ucyB0byB0aGUgR3VDCj5jb21tdW5pY2F0 aW9uIGNvbnRyb2wgZnVuY3Rpb25zIGZvciBjb25zaXN0ZW5jeS4KPgo+VGhlIHJlb3JkZXIgYWxz byBmaXhlcyB0aGUgb25pb24gdW53aW5kaW5nIG9mIGludGVsX3VjX2luaXRfaHcsIGJlY2F1c2UK Pmd1Y19lbmFibGVfY29tbXVuaWNhdGlvbiB3b3VsZCd2ZSBsZWZ0IGludGVycnVwdHMgZW5hYmxl ZCB3aGVuIGZhaWxpbmcKPnRvIGVuYWJsZSBDVEIuCj4KPkJ1Z3ppbGxhOiBodHRwczovL2J1Z3Mu ZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA5NDMKPlNpZ25lZC1vZmYtYnk6IERh bmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj5D YzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj5DYzogTWljaGFsIFdh amRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4tLS0KClJldmlld2VkLWJ5OiBN YXR0aGV3IEJyb3N0Cgo+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19jdC5jIHwgMTUg KysrLS0tLS0tLS0tLS0tCj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2N0LmggfCAg NCArKysrCj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYyAgICAgfCAxOSArKysrKysr KysrKysrKysrLS0tCj4gMyBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAxNSBkZWxl dGlvbnMoLSkKPgo+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19j dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2N0LmMKPmluZGV4IDM5MjE4MDlm ODEyYi4uOTJlYjQwYWFkZDliIDEwMDY0NAo+LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjX2N0LmMKPisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19jdC5jCj5A QCAtNTI5LDggKzUyOSw4IEBAIHN0YXRpYyBpbnQgY3RjaF9zZW5kKHN0cnVjdCBpbnRlbF9ndWNf Y3QgKmN0LAo+IC8qCj4gICogQ29tbWFuZCBUcmFuc3BvcnQgKENUKSBidWZmZXIgYmFzZWQgR3VD IHNlbmQgZnVuY3Rpb24uCj4gICovCj4tc3RhdGljIGludCBpbnRlbF9ndWNfc2VuZF9jdChzdHJ1 Y3QgaW50ZWxfZ3VjICpndWMsIGNvbnN0IHUzMiAqYWN0aW9uLCB1MzIgbGVuLAo+LQkJCSAgICAg dTMyICpyZXNwb25zZV9idWYsIHUzMiByZXNwb25zZV9idWZfc2l6ZSkKPitpbnQgaW50ZWxfZ3Vj X3NlbmRfY3Qoc3RydWN0IGludGVsX2d1YyAqZ3VjLCBjb25zdCB1MzIgKmFjdGlvbiwgdTMyIGxl biwKPisJCSAgICAgIHUzMiAqcmVzcG9uc2VfYnVmLCB1MzIgcmVzcG9uc2VfYnVmX3NpemUpCj4g ewo+IAlzdHJ1Y3QgaW50ZWxfZ3VjX2N0ICpjdCA9ICZndWMtPmN0Owo+IAlzdHJ1Y3QgaW50ZWxf Z3VjX2N0X2NoYW5uZWwgKmN0Y2ggPSAmY3QtPmhvc3RfY2hhbm5lbDsKPkBAIC04MzQsNyArODM0 LDcgQEAgc3RhdGljIHZvaWQgY3RfcHJvY2Vzc19ob3N0X2NoYW5uZWwoc3RydWN0IGludGVsX2d1 Y19jdCAqY3QpCj4gICogV2hlbiB3ZSdyZSBjb21tdW5pY2F0aW5nIHdpdGggdGhlIEd1QyBvdmVy IENULCBHdUMgdXNlcyBldmVudHMKPiAgKiB0byBub3RpZnkgdXMgYWJvdXQgbmV3IG1lc3NhZ2Vz IGJlaW5nIHBvc3RlZCBvbiB0aGUgUkVDViBidWZmZXIuCj4gICovCj4tc3RhdGljIHZvaWQgaW50 ZWxfZ3VjX3RvX2hvc3RfZXZlbnRfaGFuZGxlcl9jdChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4r dm9pZCBpbnRlbF9ndWNfdG9faG9zdF9ldmVudF9oYW5kbGVyX2N0KHN0cnVjdCBpbnRlbF9ndWMg Kmd1YykKPiB7Cj4gCXN0cnVjdCBpbnRlbF9ndWNfY3QgKmN0ID0gJmd1Yy0+Y3Q7Cj4KPkBAIC05 MDEsMTAgKzkwMSw2IEBAIGludCBpbnRlbF9ndWNfY3RfZW5hYmxlKHN0cnVjdCBpbnRlbF9ndWNf Y3QgKmN0KQo+IAlpZiAodW5saWtlbHkoZXJyKSkKPiAJCXJldHVybiBlcnI7Cj4KPi0JLyogU3dp dGNoIGludG8gY21kIHRyYW5zcG9ydCBidWZmZXIgYmFzZWQgc2VuZCgpICovCj4tCWd1Yy0+c2Vu ZCA9IGludGVsX2d1Y19zZW5kX2N0Owo+LQlndWMtPmhhbmRsZXIgPSBpbnRlbF9ndWNfdG9faG9z dF9ldmVudF9oYW5kbGVyX2N0Owo+LQlEUk1fSU5GTygiQ1Q6ICVzXG4iLCBlbmFibGVkZGlzYWJs ZWQodHJ1ZSkpOwo+IAlyZXR1cm4gMDsKPiB9Cj4KPkBAIC05MjEsOSArOTE3LDQgQEAgdm9pZCBp bnRlbF9ndWNfY3RfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZ3VjX2N0ICpjdCkKPiAJCXJldHVybjsK Pgo+IAljdGNoX2Rpc2FibGUoZ3VjLCBjdGNoKTsKPi0KPi0JLyogRGlzYWJsZSBzZW5kICovCj4t CWd1Yy0+c2VuZCA9IGludGVsX2d1Y19zZW5kX25vcDsKPi0JZ3VjLT5oYW5kbGVyID0gaW50ZWxf Z3VjX3RvX2hvc3RfZXZlbnRfaGFuZGxlcl9ub3A7Cj4tCURSTV9JTkZPKCJDVDogJXNcbiIsIGVu YWJsZWRkaXNhYmxlZChmYWxzZSkpOwo+IH0KPmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9ndWNfY3QuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19jdC5o Cj5pbmRleCA0MWJhNTkzYTRkZjcuLjBlYzE3NDkzZDgzYiAxMDA2NDQKPi0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2d1Y19jdC5oCj4rKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9ndWNfY3QuaAo+QEAgLTEwMSw0ICsxMDEsOCBAQCBzdGF0aWMgaW5saW5lIHZvaWQgaW50 ZWxfZ3VjX2N0X3N0b3Aoc3RydWN0IGludGVsX2d1Y19jdCAqY3QpCj4gCWN0LT5ob3N0X2NoYW5u ZWwuZW5hYmxlZCA9IGZhbHNlOwo+IH0KPgo+K2ludCBpbnRlbF9ndWNfc2VuZF9jdChzdHJ1Y3Qg aW50ZWxfZ3VjICpndWMsIGNvbnN0IHUzMiAqYWN0aW9uLCB1MzIgbGVuLAo+KwkJICAgICAgdTMy ICpyZXNwb25zZV9idWYsIHUzMiByZXNwb25zZV9idWZfc2l6ZSk7Cj4rdm9pZCBpbnRlbF9ndWNf dG9faG9zdF9ldmVudF9oYW5kbGVyX2N0KHN0cnVjdCBpbnRlbF9ndWMgKmd1Yyk7Cj4rCj4gI2Vu ZGlmIC8qIF9JTlRFTF9HVUNfQ1RfSF8gKi8KPmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF91Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+aW5kZXgg YWU0NTY1MWFjNzNjLi5jN2Y4MmM5NDRkZDYgMTAwNjQ0Cj4tLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF91Yy5jCj4rKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jCj5A QCAtMjM1LDkgKzIzNSwyMCBAQCBzdGF0aWMgdm9pZCBndWNfZGlzYWJsZV9pbnRlcnJ1cHRzKHN0 cnVjdCBpbnRlbF9ndWMgKmd1YykKPgo+IHN0YXRpYyBpbnQgZ3VjX2VuYWJsZV9jb21tdW5pY2F0 aW9uKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiB7Cj4rCWludCByZXQ7Cj4rCj4rCXJldCA9IGlu dGVsX2d1Y19jdF9lbmFibGUoJmd1Yy0+Y3QpOwo+KwlpZiAocmV0KQo+KwkJcmV0dXJuIHJldDsK PisKPisJZ3VjLT5zZW5kID0gaW50ZWxfZ3VjX3NlbmRfY3Q7Cj4rCWd1Yy0+aGFuZGxlciA9IGlu dGVsX2d1Y190b19ob3N0X2V2ZW50X2hhbmRsZXJfY3Q7Cj4rCj4gCWd1Y19lbmFibGVfaW50ZXJy dXB0cyhndWMpOwo+Cj4tCXJldHVybiBpbnRlbF9ndWNfY3RfZW5hYmxlKCZndWMtPmN0KTsKPisJ RFJNX0lORk8oIkd1QyBjb21tdW5pY2F0aW9uIGVuYWJsZWRcbiIpOwo+Kwo+KwlyZXR1cm4gMDsK PiB9Cj4KPiBzdGF0aWMgdm9pZCBndWNfc3RvcF9jb21tdW5pY2F0aW9uKHN0cnVjdCBpbnRlbF9n dWMgKmd1YykKPkBAIC0yNTAsMTIgKzI2MSwxNCBAQCBzdGF0aWMgdm9pZCBndWNfc3RvcF9jb21t dW5pY2F0aW9uKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPgo+IHN0YXRpYyB2b2lkIGd1Y19kaXNh YmxlX2NvbW11bmljYXRpb24oc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+IHsKPi0JaW50ZWxfZ3Vj X2N0X2Rpc2FibGUoJmd1Yy0+Y3QpOwo+LQo+IAlndWNfZGlzYWJsZV9pbnRlcnJ1cHRzKGd1Yyk7 Cj4KPiAJZ3VjLT5zZW5kID0gaW50ZWxfZ3VjX3NlbmRfbm9wOwo+IAlndWMtPmhhbmRsZXIgPSBp bnRlbF9ndWNfdG9faG9zdF9ldmVudF9oYW5kbGVyX25vcDsKPisKPisJaW50ZWxfZ3VjX2N0X2Rp c2FibGUoJmd1Yy0+Y3QpOwo+Kwo+KwlEUk1fSU5GTygiR3VDIGNvbW11bmljYXRpb24gZGlzYWJs ZWRcbiIpOwo+IH0KPgo+IGludCBpbnRlbF91Y19pbml0X21pc2Moc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmk5MTUpCj4tLSAKPjIuMjAuMQo+Cj5fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+SW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4