All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Display uncore prep patches (rev2)
Date: Thu, 20 Jun 2019 01:08:48 -0000	[thread overview]
Message-ID: <20190620010848.18133.53281@emeril.freedesktop.org> (raw)
In-Reply-To: <20190620010021.20637-1-daniele.ceraolospurio@intel.com>

== Series Details ==

Series: Display uncore prep patches (rev2)
URL   : https://patchwork.freedesktop.org/series/62232/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
d925fdfca22c drm/i915: use vfuncs for reg_read/write_fw_domains
-:62: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#62: FILE: drivers/gpu/drm/i915/intel_uncore.c:1155:
+#define __gen_reg_read_funcs(func) \
+static enum forcewake_domains \
+func##_reg_read_fw_domains(struct intel_uncore *uncore, i915_reg_t reg) { \
+	return __##func##_reg_read_fw_domains(uncore, i915_mmio_reg_offset(reg)); \
+} \
+\
+__gen_read(func, 8) \
+__gen_read(func, 16) \
+__gen_read(func, 32) \
+__gen_read(func, 64)

-:85: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#85: FILE: drivers/gpu/drm/i915/intel_uncore.c:1231:
 }
+__gen6_write(8)

-:116: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#116: FILE: drivers/gpu/drm/i915/intel_uncore.c:1247:
+#define __gen_reg_write_funcs(func) \
+static enum forcewake_domains \
+func##_reg_write_fw_domains(struct intel_uncore *uncore, i915_reg_t reg) { \
+	return __##func##_reg_write_fw_domains(uncore, i915_mmio_reg_offset(reg)); \
+} \
+\
+__gen_write(func, 8) \
+__gen_write(func, 16) \
+__gen_write(func, 32)

-:135: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects?
#135: FILE: drivers/gpu/drm/i915/intel_uncore.c:1265:
+#define ASSIGN_RAW_WRITE_MMIO_VFUNCS(uncore, x) \
 do { \
 	(uncore)->funcs.mmio_writeb = x##_write8; \
 	(uncore)->funcs.mmio_writew = x##_write16; \
 	(uncore)->funcs.mmio_writel = x##_write32; \
 } while (0)

-:143: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects?
#143: FILE: drivers/gpu/drm/i915/intel_uncore.c:1272:
+#define ASSIGN_RAW_READ_MMIO_VFUNCS(uncore, x) \
 do { \
 	(uncore)->funcs.mmio_readb = x##_read8; \
 	(uncore)->funcs.mmio_readw = x##_read16; \

-:151: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects?
#151: FILE: drivers/gpu/drm/i915/intel_uncore.c:1280:
+#define ASSIGN_WRITE_MMIO_VFUNCS(uncore, x) \
+do { \
+	ASSIGN_RAW_WRITE_MMIO_VFUNCS((uncore), x); \
+	(uncore)->funcs.write_fw_domains = x##_reg_write_fw_domains; \
+} while (0)

-:157: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects?
#157: FILE: drivers/gpu/drm/i915/intel_uncore.c:1286:
+#define ASSIGN_READ_MMIO_VFUNCS(uncore, x) \
+do { \
+	ASSIGN_RAW_READ_MMIO_VFUNCS(uncore, x); \
+	(uncore)->funcs.read_fw_domains = x##_reg_read_fw_domains; \
+} while (0)

total: 0 errors, 0 warnings, 7 checks, 258 lines checked
64e9e429a365 drm/i915: kill uncore_sanitize
a33912a9c7bb drm/i915: kill uncore_to_i915
7c1c30e3557c drm/i915: skip forcewake actions on forcewake-less uncore
-:246: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#246: FILE: drivers/gpu/drm/i915/intel_uncore.c:1691:
+		iosf_mbi_unregister_pmic_bus_access_notifier_unlocked(

total: 0 errors, 0 warnings, 1 checks, 224 lines checked
6186c2ceab1a drm/i915: dynamically allocate forcewake domains
776298c3ec6b drm/i915/gvt: decouple check_vgpu() from uncore_init()

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-06-20  1:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20  1:00 [PATCH v2 0/6] Display uncore prep patches Daniele Ceraolo Spurio
2019-06-20  1:00 ` [PATCH v2 1/6] drm/i915: use vfuncs for reg_read/write_fw_domains Daniele Ceraolo Spurio
2019-06-20  1:00 ` [PATCH v2 2/6] drm/i915: kill uncore_sanitize Daniele Ceraolo Spurio
2019-06-20  1:00 ` [PATCH v2 3/6] drm/i915: kill uncore_to_i915 Daniele Ceraolo Spurio
2019-06-20  1:00 ` [PATCH v2 4/6] drm/i915: skip forcewake actions on forcewake-less uncore Daniele Ceraolo Spurio
2019-06-20  7:43   ` Chris Wilson
2019-06-20  1:00 ` [PATCH v2 5/6] drm/i915: dynamically allocate forcewake domains Daniele Ceraolo Spurio
2019-06-20  7:55   ` Chris Wilson
2019-06-20  1:00 ` [PATCH v2 6/6] drm/i915/gvt: decouple check_vgpu() from uncore_init() Daniele Ceraolo Spurio
2019-06-20  2:15   ` Zhenyu Wang
2019-06-20  8:02     ` Chris Wilson
2019-06-20  1:08 ` Patchwork [this message]
2019-06-20  1:44 ` ✓ Fi.CI.BAT: success for Display uncore prep patches (rev2) Patchwork
2019-06-20 15:41   ` Tvrtko Ursulin
2019-06-20 15:00 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190620010848.18133.53281@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.