Re: [PATCH 4/4] gtk-icon-cache.bbclass: Depends on gtk+3

[Adrian Bunk <bunk@stusta.de>]

On Thu, Jun 20, 2019 at 04:15:26PM +0800, Robert Yang wrote:
> The gtk-update-icon-cache and gdk-pixbuf-query-loaders are provided by gtk+3.

gdk-pixbuf-query-loaders is provided by gdk-pixbuf,
which is not tied to a specific GTK version.

gtk-update-icon-cache is provided by both GTK 2 and GTK 3,
I haven't checked whether it will also be in GTK 4.

>...
> --- a/meta/classes/gtk-icon-cache.bbclass
> +++ b/meta/classes/gtk-icon-cache.bbclass
> @@ -4,6 +4,11 @@ DEPENDS +=" ${@['hicolor-icon-theme', '']['${BPN}' == 'hicolor-icon-theme']} gtk
>  
>  PACKAGE_WRITE_DEPS += "gtk+3-native gdk-pixbuf-native"
>  
> +inherit distro_features_check
> +ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
> +
> +DEPENDS += "gtk+3"
>...

This looks OK.

> @@ -45,10 +50,11 @@ python populate_packages_append () {
>          if not os.path.exists(icon_dir):
>              continue
>  
> -        bb.note("adding hicolor-icon-theme dependency to %s" % pkg)
> -        rdepends = ' ' + d.getVar('MLPREFIX', False) + "hicolor-icon-theme"
> -        d.appendVar('RDEPENDS_%s' % pkg, rdepends)
> -    
> +        for dep in ('hicolor-icon-theme', 'gtk+3'):
> +            bb.note("Adding %s dependency to %s" % (dep, pkg))
> +            rdepends = ' ' + d.getVar('MLPREFIX', False) + dep
> +            d.appendVar('RDEPENDS_%s' % pkg, rdepends)
>...

Why is this necessary?

I would expect there to always be a generated RDEPENDS on either
gtk+ or gtk+3 (or soon gtk4) that already covers this.
Anything I miss here?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed