From: Kees Cook <keescook@chromium.org>
To: Romain Perier <romain.perier@gmail.com>
Cc: Kernel Hardening <kernel-hardening@lists.openwall.com>
Subject: Re: Audit and fix all misuse of NLA_STRING: STATUS
Date: Thu, 20 Jun 2019 09:15:46 -0700 [thread overview]
Message-ID: <201906200913.D2698BD0@keescook> (raw)
In-Reply-To: <CABgxDoLSzkVJ7Vh8mLiZySz6uS+VEu+GUxRqX8EWHKQDyz2fSg@mail.gmail.com>
On Tue, Jun 18, 2019 at 07:56:42PM +0200, Romain Perier wrote:
> Hi !
>
> Here a first review, you can get the complete list here:
>
> https://salsa.debian.org/rperier-guest/linux-tree/raw/next/STATUS
Cool! You identified three issues:
net/netfilter/nfnetlink_cthelper.c:
NF_CT_HELPER_NAME_LEN is used instead of NF_CT_EXP_POLICY_NAME_LEN
net/netfilter/ipset/ip_set_list_set.c:
IPSET_ATTR_NAME and IPSET_ATTR_NAMEREF both have a len of
IPSET_MAXNAMELEN for a string of size IPSET_MAXNAMELEN
net/openvswitch/conntrack.c:
maxlen of NF_CT_HELPER_NAME_LEN with a string of size
NF_CT_HELPER_NAME_LEN. maxlen of CTNL_TIMEOUT_NAME_MAX with a
string of size CTNL_TIMEOUT_NAME_MAX
I haven't looked closely at this myself yet, but I think the next step
would be to write patches for each of these. And while doing that, have
an eye toward thinking about how each case could be made more robust in
the future to avoid these kinds of flaws returning.
Nice!
--
Kees Cook
next prev parent reply other threads:[~2019-06-20 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 17:56 Audit and fix all misuse of NLA_STRING: STATUS Romain Perier
2019-06-20 16:15 ` Kees Cook [this message]
2019-06-21 10:54 ` Romain Perier
2019-06-25 16:42 ` Romain Perier
2019-06-26 23:51 ` Kees Cook
[not found] ` <CABgxDoJJo=AUHc1vWMeBpZHnMeBdRHSFnXWuN4RZwWnmB-9nBg@mail.gmail.com>
2019-06-27 14:30 ` Fwd: " Romain Perier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201906200913.D2698BD0@keescook \
--to=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.