From: Mark Brown <broonie@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-spi@vger.kernel.org, kbuild test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Masahisa Kojima <masahisa.kojima@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH] spi/acpi: fix incorrect ACPI parent check
Date: Thu, 20 Jun 2019 12:19:05 +0100 [thread overview]
Message-ID: <20190620111905.GA5316@sirena.org.uk> (raw)
In-Reply-To: <20190620104128.GW2640@lahna.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
On Thu, Jun 20, 2019 at 01:41:28PM +0300, Mika Westerberg wrote:
> On Thu, Jun 20, 2019 at 12:33:41PM +0200, Ard Biesheuvel wrote:
> IMHO it's better to do:
> memset(&lookup, 0, sizeof(lookup));
> lookup.ctlr = ctlr;
> lookup.irq = -1;
> this also initializes chip_select and possibly other fields that get
> added to the lookup structure later.
I agree.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-20 11:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 9:52 [PATCH] spi/acpi: fix incorrect ACPI parent check Ard Biesheuvel
2019-06-19 10:16 ` Mika Westerberg
2019-06-19 11:58 ` Jarkko Nikula
2019-06-19 11:59 ` Ard Biesheuvel
2019-06-19 13:21 ` Jarkko Nikula
2019-06-19 13:58 ` Ard Biesheuvel
2019-06-19 14:17 ` Jarkko Nikula
2019-06-19 14:42 ` Mika Westerberg
2019-06-20 10:33 ` Ard Biesheuvel
2019-06-20 10:41 ` Mika Westerberg
2019-06-20 11:19 ` Mark Brown [this message]
2019-06-20 11:51 ` Ard Biesheuvel
2019-06-20 12:21 ` Jarkko Nikula
2019-06-20 12:25 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620111905.GA5316@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=ard.biesheuvel@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lukas@wunner.de \
--cc=masahisa.kojima@linaro.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.