From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/busybox: convert S10mdev to the canonical init script format
Date: Thu, 20 Jun 2019 14:52:50 +0300 [thread overview]
Message-ID: <20190620115250.GV9224@smile.fi.intel.com> (raw)
In-Reply-To: <5e25ef4f-97c0-0f0e-9fdb-de4c4300086b@railnova.eu>
On Thu, Jun 20, 2019 at 01:39:32PM +0200, Titouan Christophe wrote:
> On 6/20/19 12:44 PM, Titouan Christophe wrote:
> > Hello Andy,
> >
> > On 6/20/19 12:10 PM, Andy Shevchenko wrote:
> > > On Wed, Jun 19, 2019 at 06:42:56PM +0200, Titouan Christophe wrote:
> > > > Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>
> > >
> > > > -??? find /sys/ -name modalias -print0 | xargs -0 sort -u | tr
> > > > '\n' '\0' | \
> > > > -??????? xargs -0 modprobe -abq
> > >
> > > > +??? find /sys/ -name modalias -print0 | \
> > > > +??????? xargs -0 sort -u | \
> > > > +??????? tr '\n' '\0' | \
> > > > +??????? xargs -0 modprobe -abq
> > >
> > > How this indentation change related to the topic?
> > >
> >
> > This is a preparatory patch to convert this script to the canonical init
> > script format, as suggested by Arnout (see
> > http://lists.busybox.net/pipermail/buildroot/2019-May/251199.html)
>
>
> sorry I did not pay attention to the fact that you were only commenting on
> this particular hunk. I did reindent this command chain for better
> readability (in my opinion); I can rework that part to better suit the
> codestyle, if any.
It should be a separate patch explaining why you are doing that, but not in this one.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-06-20 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 16:42 [Buildroot] [PATCH 0/3] Update Busybox to 1.31 and use mdev daemon mode Titouan Christophe
2019-06-19 16:42 ` [Buildroot] [PATCH 1/3] package/busybox: bump version to 1.31.0 Titouan Christophe
2019-06-19 16:42 ` [Buildroot] [PATCH 2/3] package/busybox: convert S10mdev to the canonical init script format Titouan Christophe
2019-06-20 10:10 ` Andy Shevchenko
2019-06-20 10:44 ` Titouan Christophe
2019-06-20 11:39 ` Titouan Christophe
2019-06-20 11:52 ` Andy Shevchenko [this message]
2019-06-19 16:42 ` [Buildroot] [PATCH 3/3] package/busybox: run mdev in daemon mode Titouan Christophe
2019-06-20 14:31 ` [Buildroot] [PATCH 0/3] Update Busybox to 1.31 and use mdev " Thomas Petazzoni
2019-06-20 15:16 ` Peter Korsgaard
2019-06-20 16:02 ` Titouan Christophe
2019-06-23 13:20 ` Titouan Christophe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620115250.GV9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.