From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 539DAC43613 for ; Thu, 20 Jun 2019 12:10:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 227B92080C for ; Thu, 20 Jun 2019 12:10:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561032633; bh=gypvzOuIyGej/WLKSteaEHH1Cc+uthJD0zqXxf7LLJk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=IeuMPUE++PVx++MNSU2I0BdT1GedTUGqVoVrruBUAjWLNYPPV06XS90xBl4ftbCAC pkBJHOFDooURy/FvCrdP3qRilyWI4jIB+ISZeT+GpcxwcPSAP4SrkXGsiH8nALwq6m ++hnLYV6cTnhfVP3LQWLEBtOhFxEd2MooxXRnwx8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731678AbfFTMK2 (ORCPT ); Thu, 20 Jun 2019 08:10:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:39586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730596AbfFTMK2 (ORCPT ); Thu, 20 Jun 2019 08:10:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0906E2080C; Thu, 20 Jun 2019 12:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561032627; bh=gypvzOuIyGej/WLKSteaEHH1Cc+uthJD0zqXxf7LLJk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wKQFXj/Kk1YUVHNUjmFWLP/OYg2Z4cD55J+GL9FwDW4/YVfOMZ+Bm5ajPWetKYjUg UJ/J9WsCFYnWCc3j+g9/EEOocWMisPtXsvaQ6k8HlsrRbJy8sLYuAFVlad7O2gxuHA dOHkFYG1pY93D5BhBFAESLH8hCeT6OGJpSFWDyEc= Date: Thu, 20 Jun 2019 14:10:25 +0200 From: Greg Kroah-Hartman To: Yinbo Zhu Cc: Alan Stern , xiaobo.xie@nxp.com, jiafei.pan@nxp.com, Ramneek Mehresh , Nikhil Badola , Ran Wang , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 4/5] usb: host: Stops USB controller init if PLL fails to lock Message-ID: <20190620121025.GB19295@kroah.com> References: <20190614085433.22344-1-yinbo.zhu@nxp.com> <20190614085433.22344-4-yinbo.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190614085433.22344-4-yinbo.zhu@nxp.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Jun 14, 2019 at 04:54:32PM +0800, Yinbo Zhu wrote: > From: Ramneek Mehresh > > USB erratum-A006918 workaround tries to start internal PHY inside > uboot (when PLL fails to lock). However, if the workaround also > fails, then USB initialization is also stopped inside Linux. > Erratum-A006918 workaround failure creates "fsl,erratum_a006918" > node in device-tree. Presence of this node in device-tree is > used to stop USB controller initialization in Linux > > Signed-off-by: Ramneek Mehresh > Signed-off-by: Suresh Gupta > Signed-off-by: Yinbo Zhu > --- > Change in v7: > keep v5 version "fall through" > > drivers/usb/host/ehci-fsl.c | 9 +++++++++ > drivers/usb/host/fsl-mph-dr-of.c | 3 ++- > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c > index 8f3bf3efb038..ef3dfd33a62e 100644 > --- a/drivers/usb/host/ehci-fsl.c > +++ b/drivers/usb/host/ehci-fsl.c > @@ -236,6 +236,15 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd, > portsc |= PORT_PTS_PTW; > /* fall through */ > case FSL_USB2_PHY_UTMI: > + /* Presence of this node "has_fsl_erratum_a006918" > + * in device-tree is used to stop USB controller > + * initialization in Linux > + */ > + if (pdata->has_fsl_erratum_a006918) { > + dev_warn(dev, "USB PHY clock invalid\n"); > + return -EINVAL; > + } > + You need a /* fall through */ comment here, right? thanks, greg k-h