From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/imx: correct order of crtc disable Date: Thu, 20 Jun 2019 14:32:12 +0200 Message-ID: <20190620123212.GR12905@phenom.ffwll.local> References: <20190618155003.18499-1-bob.beckett@collabora.com> <1560937217.2398.1.camel@pengutronix.de> <4fceab36a9d800249b66bfd37114d63fc3386d29.camel@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 242A389341 for ; Thu, 20 Jun 2019 12:32:20 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id p15so4449857eds.8 for ; Thu, 20 Jun 2019 05:32:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <4fceab36a9d800249b66bfd37114d63fc3386d29.camel@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Robert Beckett Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMjAsIDIwMTkgYXQgMTI6MTI6MTNQTSArMDEwMCwgUm9iZXJ0IEJlY2tldHQg d3JvdGU6Cj4gT24gVGh1LCAyMDE5LTA2LTIwIGF0IDEwOjUwICswMjAwLCBEYW5pZWwgVmV0dGVy IHdyb3RlOgo+ID4gT24gV2VkLCBKdW4gMTksIDIwMTkgYXQgMTE6NDAgQU0gUGhpbGlwcCBaYWJl bCA8Cj4gPiBwLnphYmVsQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKPiA+ID4gCj4gPiA+IEhpIFJv YmVydCwKPiA+ID4gCj4gPiA+IHRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgo+ID4gPiAKPiA+ID4g T24gVHVlLCAyMDE5LTA2LTE4IGF0IDE2OjUwICswMTAwLCBSb2JlcnQgQmVja2V0dCB3cm90ZToK PiA+ID4gPiBOb3RpZnkgZHJtIGNvcmUgYmVmb3JlIHNlbmRpbmcgcGVuZGluZyBldmVudHMgZHVy aW5nIGNydGMKPiA+ID4gPiBkaXNhYmxlLgo+ID4gPiA+IFRoaXMgZml4ZXMgdGhlIGZpcnN0IGV2 ZW50IGFmdGVyIGRpc2FibGUgaGF2aW5nIGFuIG9sZCBzdGFsZQo+ID4gPiA+IHRpbWVzdGFtcAo+ ID4gPiA+IGJ5IGhhdmluZyBkcm1fY3J0Y192Ymxhbmtfb2ZmIHVwZGF0ZSB0aGUgdGltZXN0YW1w IHRvIG5vdy4KPiA+ID4gPiAKPiA+ID4gPiBUaGlzIHdhcyBzZWVuIHdoaWxlIGRlYnVnZ2luZyB3 ZXN0b24gbG9nIG1lc3NhZ2U6Cj4gPiA+ID4gV2FybmluZzogY29tcHV0ZWQgcmVwYWludCBkZWxh eSBpcyBpbnNhbmU6IC04MjEyIG1zZWMKPiA+ID4gPiAKPiA+ID4gCj4gPiA+IFdvdWxkIHlvdSBz YXkgdGhpcwo+ID4gPiBGaXhlczogYTQ3NDQ3ODY0MmQ1ICgiZHJtL2lteDogZml4IGNydGMgdmJs YW5rIHN0YXRlIHJlZ3Jlc3Npb24iKQo+ID4gPiA/Cj4gPiA+IAo+ID4gPiA+IFNpZ25lZC1vZmYt Ynk6IFJvYmVydCBCZWNrZXR0IDxib2IuYmVja2V0dEBjb2xsYWJvcmEuY29tPgo+ID4gPiA+IC0t LQo+ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaW14L2lwdXYzLWNydGMuYyB8IDYgKysrLS0tCj4g PiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4g PiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pbXgvaXB1djMtY3J0 Yy5jCj4gPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaW14L2lwdXYzLWNydGMuYwo+ID4gPiA+IGlu ZGV4IDljYzFkNjc4Njc0Zi4uYzQzNmEyOGQ1MGU0IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pbXgvaXB1djMtY3J0Yy5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2lteC9pcHV2My1jcnRjLmMKPiA+ID4gPiBAQCAtOTEsMTQgKzkxLDE0IEBAIHN0YXRpYyB2b2lk IGlwdV9jcnRjX2F0b21pY19kaXNhYmxlKHN0cnVjdAo+ID4gPiA+IGRybV9jcnRjICpjcnRjLAo+ ID4gPiA+ICAgICAgIGlwdV9kY19kaXNhYmxlKGlwdSk7Cj4gPiA+ID4gICAgICAgaXB1X3ByZ19k aXNhYmxlKGlwdSk7Cj4gPiA+ID4gCj4gPiA+ID4gKyAgICAgZHJtX2NydGNfdmJsYW5rX29mZihj cnRjKTsKPiA+ID4gPiArCj4gPiA+IAo+ID4gPiBUaGlzIGlzIGV4cGxhaW5lZCBpbiB0aGUgY29t bWl0IG1lc3NhZ2UgYW5kIGFsaWducyB3aXRoIHRoZQo+ID4gPiBkcm1fY3J0Y19zdGF0ZSBAZXZl bnQgZG9jdW1lbnRhdGlvbi4KPiA+IAo+ID4gVGhpcyBwYXJ0IGhlcmUgbG9va3MgZmlzaHkuIFRo ZSBkcm1fdmJsYW5rLmMgY29kZSBpcyBzdXBwb3NlZCB0byBkbwo+ID4gdGhlIHJpZ2h0IHRoaW5n LCBubyBtYXR0ZXIgd2hlcmUgb3Igd2hlbiB5b3UgYXNrIGl0IHRvIGdlbmVyYXRlIGFuCj4gPiBl dmVudC4gSXQgZGVmaW5pdGVseSBzaG91bGRuJ3QgZ2VuZXJhdGUgYSB0aW1lc3RhbXAgdGhhdCdz IGEgZmV3Cj4gPiBzZWNvbmRzIHRvbyBlYXJseS4gQnVuY2ggb2Ygb3B0aW9uczoKPiA+IC0gdGhl cmUncyBhIGJ1ZyBpbiBkcm1fdmJsYW5rLmMgYW5kIGl0J3MgbWl4aW5nIHVwIHNvbWV0aGluZyBh bmQKPiA+IGdlbmVyYXRpbmcgYSB0b3RhbGx5IGJvZ3VzIHZhbHVlLgo+ID4gLSB0aGVyZSdzIGEg bGllIGluIHlvdXIgaW14IHZibGFuayBjb2RlLCB3aGljaCB0cmlwcyB0aGUgZHJtX3ZibGFuay5j Cj4gPiBjb3VudGVyIGludGVycG9sYXRpb24gYW5kIHJlc3VsdHMgaW4gYSB0b3RhbGx5IGJvZ3Vz IHZhbHVlLgo+ID4gCj4gPiBkcm1fdmJsYW5rLmMgYXNzdW1lcyB0aGF0IGlmIHlvdSBkbyBjbGFp bSB0byBoYXZlIGEgaHcgY291bnRlciBhbmQKPiA+IGdlbmVyYXRlIHRpbWVzdGFtcHMsIHRoYXQg dGhvc2UgYXJlIHBlcmZlY3RseSBhY2N1cmF0ZS4gSXQgb25seSBmYWxscwo+ID4gYmFjayB0byBn dWVzdGltYXRpbmcgdXNpbmcgdGhlIHN5c3RlbSB0aW1lciBpZiB0aGF0J3Mgbm90IHByZXNlbnQu Cj4gPiAKPiA+IEVpdGhlciB3YXksIHRoaXMgdmVyeSBtdWNoIHNtZWxscyBsaWtlIHBhcGVyaW5n IG92ZXIgYSBidWcgaWYgdGhpcwo+ID4gY2hhbmdlIGluZGVlZCBmaXhlcyB5b3VyIHdyb25nIHZi bGFuayB0aW1lc3RhbXBzLgo+ID4gCj4gCj4gQSBxdWljayBleHBsYWluYXRpb24gb2Ygd2hlcmUg dGhlIGRvZGd5IHRpbWVzdGFtcCBjYW1lIGZyb206Cj4gMS4gZHJpdmVyIHN0YXJ0cyB1cAo+IDIu IGZiY29uIGNvbWVzIGFsb25nIGFuZCByZXN0b3JlcyBmYmRldiwgZW5hYmxpbmcgdmJsYW5rCj4g My4gdmJsYW5rX2Rpc2FibGVfZm4gZmlyZXMgdmlhIHRpbWVyIGRpc2FibGluZyB2YmxhbmssIGtl ZXBpbmcgdmJsYW5rCj4gc2VxIG51bWJlciBhbmQgdGltZSBzZXQgYXQgY3VycmVudCB2YWx1ZQo+ IChzb21lIHRpbWUgbGF0ZXIpCj4gNC4gd2VzdG9uIHN0YXJ0cyBhbmQgZG9lcyBhIG1vZGVzZXQK PiA1LiBhdG9taWMgY29tbWl0IGRpc2FibGVzIGNydGMgd2hpbGUgaXQgZG9lcyB0aGUgbW9kZXNl dAo+IDYuIGlwdV9jcnRjX2F0b21pY19kaXNhYmxlIHNlbmRzIHZibGFuayB3aXRoIG9sZCBzZXEg bnVtYmVyIGFuZCB0aW1lCj4gCj4gSXQgdHVybnMgb3V0IHRoZSBhY3R1YWwgZml4IGZvciB0aGUg b2xkIHZibGFuayBpcyB0aGUgbmV4dCBjaGFuZ2UsCj4gd2hpY2ggc3RvcHMgaXQgYmVpbmcgc2Vu dCBhdCBhbGwgZHVyaW5nIHRoZSBjcnRjIGRpc2FibGUgYXMgaXQgaXMgaXMKPiBzdGlsbCBhY3Rp dmUsIGl0IHdvdWxkIHRoZW4gZ28gdGhyb3VnaCBkcm1fY3J0Y192Ymxhbmtfb2ZmLCByZXNldGlu Zwo+IHRoZSB0aW1lc3RhbXAsIGFuZCBnZXQgZGVsaXZlcmVkIGR1cmluZyB0aGUgdmJsYW5rIGVu YWJsZSBhcyBwYXJ0IG9mCj4gdGhlIGF0b21pYyBjb21taXQuCgpUaGlzIHNob3VsZG4ndCBmaXgg eW91ciB2YmxhbmsgdGltZXN0YW1wIHRyb3VibGVzIGVpdGhlci4gSXQgbWlnaHQgbWVhbgp0aGF0 IHRoZSB0aW1lc3RhbXAgaXMgc2xpZ2h0bHkgdG9vIGVhcmx5IChiZWNhdXNlIHlvdSB0YWtlIGl0 IHdoaWxlCnNodXR0aW5nIGRvd24gdGhlIGNydGMsIG5vdCB3aGlsZSByZS1lbmFibGluZyksIGJ1 dCBub3QgYnkgc2Vjb25kcy4KClF1aWNrIGV4cGVyaW1lbnQ6IERpc2FibGUgdmJsYW5rIGRpc2Fi bGluZyB3aXRoIGRybS52YmxhbmtvZmZkZWxheSA9IDAuIElmCnRoYXQgYWxzbyBmaXhlcyB0aGUg dGltZXN0YW1wcywgdGhlbiBJJ20gcHJldHR5IHN1cmUgeW91IGhhdmUgYSBkcml2ZXIgYnVnCnNv bWV3aGVyZSBhbmQgbGllIHRvIHRoZSB2YmxhbmsgY29yZSBjb2RlIGFib3V0IHNvbWV0aGluZy4K LURhbmllbAoKPiAKPiBTbywgaW4gdGhlb3J5LCB3ZSBjb3VsZCBqdXN0IGhhdmUgdGhlIGZvbGxv d2luZyBjaGFuZ2UgdG8gZml4IHRoZQo+IHNwZWNpZmljIGlzc3VlIG9mIGEgc3RhbGUgdGltZXN0 YW1wLgo+IAo+IEhvd2V2ZXIsIGdpdmVuIHRoZSBkb2N1bWVudGF0aW9uIGZvciB0aGUgZXZlbnQg aW4KPiBpbmNsdWRlL2RybS9kcm1fY3J0Yy5oOgo+IAo+ICAgICAgICAgICogIC0gVGhlIGV2ZW50 IGlzIGZvciBhIENSVEMgd2hpY2ggaXMgYmVpbmcgZGlzYWJsZWQgdGhyb3VnaAo+IHRoaXMKPiAg ICAgICAgICAqICAgIGF0b21pYyBjb21taXQuIEluIHRoYXQgY2FzZSB0aGUgZXZlbnQgY2FuIGJl IHNlbmQgb3V0IGFueQo+IHRpbWUKPiAgICAgICAgICAqICAgIGFmdGVyIHRoZSBoYXJkd2FyZSBo YXMgc3RvcHBlZCBzY2FubmluZyBvdXQgdGhlIGN1cnJlbnQKPiAgICAgICAgICAqICAgIGZyYW1l YnVmZmVycy4gSXQgc2hvdWxkIGNvbnRhaW4gdGhlIHRpbWVzdGFtcCBhbmQgY291bnRlcgo+IGZv ciB0aGUKPiAgICAgICAgICAqICAgIGxhc3QgdmJsYW5rIGJlZm9yZSB0aGUgZGlzcGxheSBwaXBl bGluZSB3YXMgc2h1dCBvZmYuIFRoZQo+IHNpbXBsZXN0Cj4gICAgICAgICAgKiAgICB3YXkgdG8g YWNoaWV2ZSB0aGF0IGlzIGNhbGxpbmcKPiBkcm1fY3J0Y19zZW5kX3ZibGFua19ldmVudCgpCj4g ICAgICAgICAgKiAgICBzb21ld2hlbiBhZnRlciBkcm1fY3J0Y192Ymxhbmtfb2ZmKCkgaGFzIGJl ZW4gY2FsbGVkLgo+IAo+IFRoaXMgc3RpbGwgc2VlbXMgbGlrZSBhIHNlbnNpYmxlIGNoYW5nZSBm b3Igd2hlbiB0aGUgY3J0YyBpcyBiZWluZwo+IGRpc2FibGVkLgo+IAo+IAo+IAo+ID4gPiA+ICAg ICAgIHNwaW5fbG9ja19pcnEoJmNydGMtPmRldi0+ZXZlbnRfbG9jayk7Cj4gPiA+ID4gLSAgICAg aWYgKGNydGMtPnN0YXRlLT5ldmVudCkKPiA+ID4gPiB7Cj4gPiA+ID4gKyAgICAgaWYgKGNydGMt PnN0YXRlLT5ldmVudCAmJiAhY3J0Yy0+c3RhdGUtPmFjdGl2ZSkgewo+ID4gPiAKPiA+ID4gVGhp cyBpcyBub3QgbWVudGlvbmVkIHRob3VnaC4KPiA+ID4gCj4gPiA+IElmIHRoZSBwZW5kaW5nIGV2 ZW50IGlzIG5vdCBzZW50IGhlcmUsIEkgYXNzdW1lIGl0IHdpbGwgYmUgcGlja2VkCj4gPiA+IHVw IGJ5Cj4gPiA+IC5hdG9taWNfZmx1c2ggYW5kIHdpbGwgdGhlbiBiZSBzZW50IGFmdGVyIHRoZSBm aXJzdCBFT0YgaW50ZXJydXB0Cj4gPiA+IGFmdGVyCj4gPiA+IHRoZSBtb2Rlc2V0IGlzIGNvbXBs ZXRlLiBDYW4geW91IGV4cGxhaW4gdGhpcyBpbiB0aGUgY29tbWl0Cj4gPiA+IG1lc3NhZ2U/Cj4g PiAKPiA+IFllYWggbG9va3MgY29ycmVjdCAoeW91IG9ubHkgd2FudCB0byBnZW5lcmF0ZSB0aGUg ZXZlbnQgaGVyZSB3aGVuIHRoZQo+ID4gY3J0YyBzdGF5cyBvZmYpLCBpZiBpdCBnZXRzIHJlLWVu YWJsZWQgdGhlIGV2ZW50IHNob3VsZCBvbmx5IGJlCj4gPiBnZW5lcmF0ZWQgbGF0ZXIgb24gb25j ZSB0aGF0J3MgYWxsIGZpbmlzaGVkLiBCdXQgc2VwYXJhdGUgYnVnZml4Lgo+ID4gLURhbmllbAo+ ID4gCj4gCj4gSXQgbG9va3MgbGlrZSB0aGlzIGlzIGFjdHVhbGx5IHRoZSBmaXggbmVlZGVkIHRv IGF2b2lkIHRoZSBib2d1cwo+IHRpbWVzdGFtcC4KPiAKPiBJIGNhbiBzcGxpdCB0aGlzIHBhdGNo IHVwIGluIHRvIDIgY29tbWl0cyBpZiBkZXNpcmVkPwo+IAo+ID4gPiAKPiA+ID4gV2l0aCB0aGF0 LAo+ID4gPiBSZXZpZXdlZC1ieTogUGhpbGlwcCBaYWJlbCA8cC56YWJlbEBwZW5ndXRyb25peC5k ZT4KPiA+ID4gCj4gPiA+ID4gICAgICAgICAgICAgICBkcm1fY3J0Y19zZW5kX3ZibGFua19ldmVu dChjcnRjLCBjcnRjLT5zdGF0ZS0KPiA+ID4gPiA+ZXZlbnQpOwo+ID4gPiA+ICAgICAgICAgICAg ICAgY3J0Yy0+c3RhdGUtPmV2ZW50ID0gTlVMTDsKPiA+ID4gPiAgICAgICB9Cj4gPiA+ID4gICAg ICAgc3Bpbl91bmxvY2tfaXJxKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2spOwo+ID4gPiA+IC0KPiA+ ID4gPiAtICAgICBkcm1fY3J0Y192Ymxhbmtfb2ZmKGNydGMpOwo+ID4gPiA+ICB9Cj4gPiA+ID4g Cj4gPiA+ID4gIHN0YXRpYyB2b2lkIGlteF9kcm1fY3J0Y19yZXNldChzdHJ1Y3QgZHJtX2NydGMg KmNydGMpCj4gPiA+IAo+ID4gPiByZWdhcmRzCj4gPiA+IFBoaWxpcHAKPiA+ID4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gZHJpLWRldmVsIG1h aWxpbmcgbGlzdAo+ID4gPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4g PiAKPiA+IAo+ID4gCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVs