From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v5 0/4] syscalls/fanotify: FAN_REPORT_FID and Directory Modification Events
Date: Thu, 20 Jun 2019 15:24:36 +0200 [thread overview]
Message-ID: <20190620132436.GA9804@dell5510> (raw)
In-Reply-To: <cover.1561018312.git.mbobrowski@mbobrowski.org>
Hi Amir, Matthew,
LGTM. Just one of this commits fails on centos 6
https://api.travis-ci.org/v3/job/548162141/log.txt
https://travis-ci.org/pevik/ltp/jobs/548162141
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -W -Wold-style-definition -D_FORTIFY_SOURCE=2 -I/usr/src/ltp/include -I/usr/src/ltp/../ltp-build/include -I/usr/src/ltp/include/old/ -L/usr/src/ltp/../ltp-build/lib /usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify01.c -lltp -o fanotify01
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -W -Wold-style-definition -D_FORTIFY_SOURCE=2 -I/usr/src/ltp/include -I/usr/src/ltp/../ltp-build/include -I/usr/src/ltp/include/old/ -L/usr/src/ltp/../ltp-build/lib /usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify02.c -lltp -o fanotify02
In file included from /usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify01.c:21:
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:130: error: expected specifier-qualifier-list before '__kernel_fsid_t'
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:141: error: expected declaration specifiers or '...' before '__kernel_fsid_t'
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:142: warning: 'struct file_handle' declared inside parameter list
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:142: warning: its scope is only this definition or declaration, which is probably not what you want
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h: In function 'fanotify_get_fid':
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:150: error: 'fsid' undeclared (first use in this function)
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:150: error: (Each undeclared identifier is reported only once
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:150: error: for each function it appears in.)
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:144: warning: unused variable 'mount_id'
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:142: warning: unused parameter 'handle'
In file included from /usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify02.c:21:
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:130: error: expected specifier-qualifier-list before '__kernel_fsid_t'
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:141: error: expected declaration specifiers or '...' before '__kernel_fsid_t'
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:142: warning: 'struct file_handle' declared inside parameter list
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:142: warning: its scope is only this definition or declaration, which is probably not what you want
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h: In function 'fanotify_get_fid':
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:150: error: 'fsid' undeclared (first use in this function)
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:150: error: (Each undeclared identifier is reported only once
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:150: error: for each function it appears in.)
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:144: warning: unused variable 'mount_id'
/usr/src/ltp/testcases/kernel/syscalls/fanotify/fanotify.h:142: warning: unused parameter 'handle'
Kind regards,
Petr
> This patch series contains the changes needed to validate the new
> FAN_REPORT_FID flag and directory modification event functionality
> within the fanotify API.
> Changes since version 4:
> * Fixed problems with unbalanced file descriptor close.
> * Reorded functions in the test files fanotify13, fanotify14 and
> fanotify15 so that they all follow a basic template i.e.
> test()
> ...
> do_setup()
> do_cleanup()
> Thank you Amir for your feedback.
> Amir Goldstein (1):
> syscalls/fanotify13: add test coverage for fsid cache bug
> Matthew Bobrowski (3):
> syscalls/fanotify13: new test to verify FAN_REPORT_FID functionality
> syscalls/fanotify14: new test to validate FAN_REPORT_FID interface
> return values
> syscalls/fanotify15: verify fid for dirent events
> configure.ac | 1 +
> runtest/syscalls | 3 +
> testcases/kernel/syscalls/fanotify/.gitignore | 3 +
> testcases/kernel/syscalls/fanotify/fanotify.h | 81 +++++-
> testcases/kernel/syscalls/fanotify/fanotify05.c | 1 +
> testcases/kernel/syscalls/fanotify/fanotify13.c | 328 ++++++++++++++++++++++++
> testcases/kernel/syscalls/fanotify/fanotify14.c | 176 +++++++++++++
> testcases/kernel/syscalls/fanotify/fanotify15.c | 246 ++++++++++++++++++
> 8 files changed, 836 insertions(+), 3 deletions(-)
> create mode 100644 testcases/kernel/syscalls/fanotify/fanotify13.c
> create mode 100644 testcases/kernel/syscalls/fanotify/fanotify14.c
> create mode 100644 testcases/kernel/syscalls/fanotify/fanotify15.c
next prev parent reply other threads:[~2019-06-20 13:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 9:57 [LTP] [PATCH v5 0/4] syscalls/fanotify: FAN_REPORT_FID and Directory Modification Events Matthew Bobrowski
2019-06-20 9:57 ` [LTP] [PATCH v5 1/4] syscalls/fanotify13: new test to verify FAN_REPORT_FID functionality Matthew Bobrowski
2019-06-20 9:58 ` [LTP] [PATCH v5 2/4] syscalls/fanotify14: new test to validate FAN_REPORT_FID interface return values Matthew Bobrowski
2019-06-21 14:00 ` Cyril Hrubis
2019-06-23 17:13 ` Amir Goldstein
2019-06-24 8:38 ` Cyril Hrubis
2019-06-24 10:11 ` Matthew Bobrowski
2019-06-20 9:58 ` [LTP] [PATCH v5 3/4] syscalls/fanotify15: verify fid for dirent events Matthew Bobrowski
2019-06-20 9:59 ` [LTP] [PATCH v5 4/4] syscalls/fanotify13: add test coverage for fsid cache bug Amir Goldstein
2019-06-20 13:24 ` Petr Vorel [this message]
2019-06-20 13:57 ` [LTP] [PATCH v5 0/4] syscalls/fanotify: FAN_REPORT_FID and Directory Modification Events Amir Goldstein
2019-06-20 14:04 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620132436.GA9804@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.