From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: rk3399_gru_sound: Support 32, 44.1 and 88.2 kHz sample rates Date: Thu, 20 Jun 2019 16:41:50 +0100 Message-ID: <20190620154150.GE5316@sirena.org.uk> References: <20190620134708.28311-1-enric.balletbo@collabora.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rOnZ5ITIX7GHaQD9" Return-path: Content-Disposition: inline In-Reply-To: <20190620134708.28311-1-enric.balletbo@collabora.com> Sender: linux-kernel-owner@vger.kernel.org To: Enric Balletbo i Serra Cc: linux-kernel@vger.kernel.org, Collabora Kernel ML , Xing Zheng , Benson Leung , Jaroslav Kysela , alsa-devel@alsa-project.org, Heiko Stuebner , linux-rockchip@lists.infradead.org, Takashi Iwai , Liam Girdwood , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org --rOnZ5ITIX7GHaQD9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 20, 2019 at 03:47:08PM +0200, Enric Balletbo i Serra wrote: > According to the datasheet the max98357a also supports 32, 44.1 and > 88.2 kHz sample rate. This support was also introduced recently by > commit fdf34366d324 ("ASoC: max98357a: add missing supported rates"). > This patch adds support for these rates also for the machine driver so > we get rid of the errors like the below and we are able to play files > using these sample rates. Does the machine actually need to validate this at all? The component drivers can all apply whatever constraints are needed and do their own validation, the machine driver is just getting in the way here. --rOnZ5ITIX7GHaQD9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl0LqT0ACgkQJNaLcl1U h9Aomwf+IWYRVucBBZvhsm/gdBVe/B8CpBjmp/2qlcOTbdBRiwV3TGlwjFiWqyNF a/7criDs2zMUCDb4Ad2Xh7FoRj24dC+1QikkP64iwyN/Y5wJLwQhRRDuM60vjRGp waQP/rQ86h14cWtTi/+IE8Rm3nFcs/0J0S+87SVuW8kIifVcEAzUGYH8fhTwgkki SerVWbkR+weSZLJVq/cvR2CKQvt4qPaQ2AT2V7W9pCRzBJRza8CLIg+t7jaFUuLP EefouE+9/aOgtVf4NT+BPfcy7pptkMZwAsbX0Obcm6+1dmIpjffWRdRzki4AVnJD wUUi0N6O0HWIkSLhMnqzgBaOrZBMjg== =cr78 -----END PGP SIGNATURE----- --rOnZ5ITIX7GHaQD9-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E11FC43613 for ; Thu, 20 Jun 2019 15:42:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4232A20673 for ; Thu, 20 Jun 2019 15:42:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Nd0Gd+Gd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="jov01KPU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4232A20673 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PNH0t5cNRKL2yEu4ljWo9tbec28+chVFr4d1ILUhwds=; b=Nd0Gd+Gdgn1KtfleEcdhn89Wf BbEbGZLbLsCPMTFlzYhNemdPXR/GUIiOghcump8vILOOBr1bfE32EFhFg9F7EQhFiHQRTo9ZEQNGf ho4lgpp6P99pEmB1OZ8az4EJYLtyt26vD4niiYuDGs2mh6HoMzwNsw1BWy/m8Vt4O5bWl9OZBhZnQ 4KBZoNHePRpy3QtRAlnACYHc73fv54S2Zx0o64Pk0kf+N7pV9FDSu4GEeLet62gLPTizGsXA92SFt bDBWSb7PEyQeD3M019QPw5ZOug/8JSoq33yp2i3NgdXIAs3d01Yy/hJGdqP+JmKW7HYjo6jxLa7Vo sYgfw/c3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdzCL-0000bP-59; Thu, 20 Jun 2019 15:42:01 +0000 Received: from heliosphere.sirena.org.uk ([2a01:7e01::f03c:91ff:fed4:a3b6]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdzCI-0000al-49; Thu, 20 Jun 2019 15:41:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6s6aZu8b9dqDAqPoq81Bk78Hj/YlZ9Zu2gddBiQR0jA=; b=jov01KPU7Ey0HCtDvL/bMfUvM q+kHss2+okCgunU54lbz7AUEXxS2cz7t6hVp3TCiDXLIBSddCYMcK66KsNAYrByHqXzLdYmj5E8ms s98+kDkEwIFNMnhf/WgI7uAcAm8nRSMA5EA0gm8aA9dNtYxJ/3JhRSD6SoNS961M86AwU=; Received: from [2001:470:1f1d:6b5:7e7a:91ff:fede:4a45] (helo=finisterre.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hdzCB-0000qH-N9; Thu, 20 Jun 2019 15:41:51 +0000 Received: by finisterre.sirena.org.uk (Postfix, from userid 1000) id AF546440046; Thu, 20 Jun 2019 16:41:50 +0100 (BST) Date: Thu, 20 Jun 2019 16:41:50 +0100 From: Mark Brown To: Enric Balletbo i Serra Subject: Re: [PATCH] ASoC: rk3399_gru_sound: Support 32, 44.1 and 88.2 kHz sample rates Message-ID: <20190620154150.GE5316@sirena.org.uk> References: <20190620134708.28311-1-enric.balletbo@collabora.com> MIME-Version: 1.0 In-Reply-To: <20190620134708.28311-1-enric.balletbo@collabora.com> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_084158_311935_FE51591C X-CRM114-Status: UNSURE ( 9.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Heiko Stuebner , Xing Zheng , Liam Girdwood , Takashi Iwai , linux-kernel@vger.kernel.org, Jaroslav Kysela , linux-rockchip@lists.infradead.org, Collabora Kernel ML , Benson Leung , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1431034691895443451==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1431034691895443451== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rOnZ5ITIX7GHaQD9" Content-Disposition: inline --rOnZ5ITIX7GHaQD9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 20, 2019 at 03:47:08PM +0200, Enric Balletbo i Serra wrote: > According to the datasheet the max98357a also supports 32, 44.1 and > 88.2 kHz sample rate. This support was also introduced recently by > commit fdf34366d324 ("ASoC: max98357a: add missing supported rates"). > This patch adds support for these rates also for the machine driver so > we get rid of the errors like the below and we are able to play files > using these sample rates. Does the machine actually need to validate this at all? The component drivers can all apply whatever constraints are needed and do their own validation, the machine driver is just getting in the way here. --rOnZ5ITIX7GHaQD9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl0LqT0ACgkQJNaLcl1U h9Aomwf+IWYRVucBBZvhsm/gdBVe/B8CpBjmp/2qlcOTbdBRiwV3TGlwjFiWqyNF a/7criDs2zMUCDb4Ad2Xh7FoRj24dC+1QikkP64iwyN/Y5wJLwQhRRDuM60vjRGp waQP/rQ86h14cWtTi/+IE8Rm3nFcs/0J0S+87SVuW8kIifVcEAzUGYH8fhTwgkki SerVWbkR+weSZLJVq/cvR2CKQvt4qPaQ2AT2V7W9pCRzBJRza8CLIg+t7jaFUuLP EefouE+9/aOgtVf4NT+BPfcy7pptkMZwAsbX0Obcm6+1dmIpjffWRdRzki4AVnJD wUUi0N6O0HWIkSLhMnqzgBaOrZBMjg== =cr78 -----END PGP SIGNATURE----- --rOnZ5ITIX7GHaQD9-- --===============1431034691895443451== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1431034691895443451==--