From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD5E6C43613 for ; Thu, 20 Jun 2019 17:05:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9186820675 for ; Thu, 20 Jun 2019 17:05:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726649AbfFTRF0 (ORCPT ); Thu, 20 Jun 2019 13:05:26 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:37776 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726530AbfFTRF0 (ORCPT ); Thu, 20 Jun 2019 13:05:26 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1he0V0-0001Op-0g; Thu, 20 Jun 2019 19:05:22 +0200 Date: Thu, 20 Jun 2019 19:05:22 +0200 From: Florian Westphal To: wenxu@ucloud.cn Cc: pablo@netfilter.org, fw@strlen.de, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH nf-next] netfilter: bridge: Fix non-untagged fragment packet Message-ID: <20190620170522.cn6utaviil7gmldo@breakpoint.cc> References: <1560954907-20071-1-git-send-email-wenxu@ucloud.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1560954907-20071-1-git-send-email-wenxu@ucloud.cn> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org wenxu@ucloud.cn wrote: > From: wenxu > > ip netns exec ns1 ip a a dev eth0 10.0.0.7/24 > ip netns exec ns2 ip link a link eth0 name vlan type vlan id 200 > ip netns exec ns2 ip a a dev vlan 10.0.0.8/24 > > ip l add dev br0 type bridge vlan_filtering 1 > brctl addif br0 veth1 > brctl addif br0 veth2 > > bridge vlan add dev veth1 vid 200 pvid untagged > bridge vlan add dev veth2 vid 200 > > A two fragment packets send from ns2 contained with vlan tag 200. > In the bridge conntrack, packet will defrag to one skb with fraglist. > When the packet forward to ns1 through veth1, the first skb vlan tag > will be cleared for "untagged" flags. But the vlan tag in the second > skb still tagged, which lead the second fragment send with tag 200 to > ns1. > So if the first fragment packet don't contain vlan tag, all of the > remain should not contain vlan tag.. > > Fixes: 3c171f496ef5 ("netfilter: bridge: add connection tracking system") > Signed-off-by: wenxu Acked-by: Florian Westphal