Re: [Qemu-devel] [PATCH v4 0/5] network announce; interface selection & IDs

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Jason Wang (jasowang@redhat.com) wrote:
> 
> On 2019/6/13 下午5:59, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > Laine asked for some extra features on the network announce support;
> 
> 
> It's better to explain why this feature is needed.

Yes, I'll reword.

> Is this because libvirt
> can change the host network topology on the fly?

It's because something can change the network topology on the fly - not
necessarily just libvirt.  Where as previously we were using the
announce mechanism for mainly migration reasons, now we also want
to use it to announce topology changes; those include potentially things
that libvirt gets told by a higher management layer - such as the
failure or one network path.

Dave

> 
> Thanks
> 
> 
> > 
> > The first allows the announce timer to announce on a subset of the
> > interfaces.
> > 
> > The second allows there to be multiple timers, each with their own
> > parameters (including the interface list).
> > 
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > 
> > v4
> >    Minor typo fixes
> >    Expanded the test to check we can stop a running announce
> > 
> > Dr. David Alan Gilbert (5):
> >    net/announce: Allow optional list of interfaces
> >    net/announce: Add HMP optional interface list
> >    net/announce: Add optional ID
> >    net/announce: Add HMP optional ID
> >    net/announce: Expand test for stopping self announce
> > 
> >   hmp-commands.hx         |  7 +++-
> >   hmp.c                   | 41 +++++++++++++++++++-
> >   hw/net/virtio-net.c     |  4 +-
> >   include/net/announce.h  |  8 +++-
> >   net/announce.c          | 83 ++++++++++++++++++++++++++++++++++-------
> >   net/trace-events        |  3 +-
> >   qapi/net.json           | 16 ++++++--
> >   tests/virtio-net-test.c | 57 ++++++++++++++++++++++++++--
> >   8 files changed, 192 insertions(+), 27 deletions(-)
> > 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK